From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075094.outbound.protection.outlook.com [40.92.75.94]) by server2.sourceware.org (Postfix) with ESMTPS id EE2CD3947418 for ; Sun, 8 Mar 2020 14:57:36 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJS6mO3MGD7C3lGWVfGgMhiyvRR3Yf75sMwjsdGx7fZbLz7AW7aLeKT30G1v6TYiX9vQXn+yhw4TAXjNwUzEK1wHQB9EWFwpTDwIKDvW+Ie4jeNqnNe2XiY1yf7HkYv32a7e192fxvRmZ393ZaTjcG796+dW/u01NhQFh8ITnI5M5p6XKcw4zoLX5YHTTgvnznJTKCUYFJC/oyUjMQtL3rsekLCpefuhkEqIXJyTjVNpZx89sG0RMRIMBcd/F/8aPpH22po5MdQn7UQGkmnWhZnjozmiC7R1Kf/WmNQuqbqpQd49wCHLTaFFugIwtYrDlZm1SiU6dHrefUsAo8wbhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HS9fmwGfle0dfbApWrImLlzEb2QcufdQvvSxZc076oU=; b=YP660J+eWTXS/HA+IsSWXXdNbPFzrOD4VOAOfnDMIEbt+cdUdmYHLfUsahJdsCO00MYvb8DBuofx7B78P9u3CRBtOnJS271LtnMIY1hQlaqswP+AW3vRYxLKzcOXzJ+h3mVX1sYC/dWX7KZ0VyR9YIc1I7YLD4mCmuCsOvr81p6slzxNB7nU9pMJWj7AH3Johv6nbd6rzb7ZnQRXUj0BVU1ILYNNhL+WdUYcEJI+gYejrHFsVuE49De8ykaSNvh5rkvsEkvQaNTy1i/S2gDP9YBgbVFjHTJ8StXqH6CtI4fQ/50JDoqeurVCweGmsV4A8H2w93+HiKfTVr0218yacQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VI1EUR04FT042.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::3b) by VI1EUR04HT031.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.11; Sun, 8 Mar 2020 14:57:35 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (10.152.28.56) by VI1EUR04FT042.mail.protection.outlook.com (10.152.28.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.11 via Frontend Transport; Sun, 8 Mar 2020 14:57:35 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::1956:d274:cab3:b4dd]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::1956:d274:cab3:b4dd%6]) with mapi id 15.20.2772.019; Sun, 8 Mar 2020 14:57:35 +0000 Received: from [192.168.1.101] (92.77.140.102) by FR2P281CA0025.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.16 via Frontend Transport; Sun, 8 Mar 2020 14:57:34 +0000 From: Bernd Edlinger To: Andrew Burgess , "gdb-patches@sourceware.org" Subject: [PATCHv3] Fix range end handling of inlined subroutines Thread-Topic: [PATCHv3] Fix range end handling of inlined subroutines Thread-Index: AQHV9Vnnfl0sNxDehkmP0atZaQWPZQ== Date: Sun, 8 Mar 2020 14:57:35 +0000 Message-ID: References: <94e33268f64060fc887670f4ee5ed524050cbcc7.1580902412.git.andrew.burgess@embecosm.com> In-Reply-To: Accept-Language: en-US, en-GB, de-DE Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-clientproxiedby: FR2P281CA0025.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::12) To AM6PR03MB5170.eurprd03.prod.outlook.com (2603:10a6:20b:ca::23) x-incomingtopheadermarker: OriginalChecksum:A55F28F401FFCB15C6AF96AC42F0222E9919EB8E8EF477E960719764BEB2F5CC; UpperCasedChecksum:C146625E5194EEB076BC810AAC20D1B30EF603A201DE65EA805836F6103A8D66; SizeAsReceived:7860; Count:49 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [t9edqse7it1PM3ffnJzW2JedR4mqjIFk] x-microsoft-original-message-id: x-ms-publictraffictype: Email x-incomingheadercount: 49 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: 74f6c202-54bf-4db3-00da-08d7c3710942 x-ms-traffictypediagnostic: VI1EUR04HT031: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 02LRZw04DerG9QRmwiR9mvu9ajehsJYRBHVAZ+QN+137wcL62z8WsNPmdhqHoIJ6XM3OzTGNal68Bq0pKJQibfOTmFzv3QCVZmFi8xgUO6i6trk6ZP2X0h2a68d2Kxeya/DDFFpbQ7tnzPSkeZ+eVWlHISaYpeImj4YLSR6W4LdUfhJSwbB0UeMYpVR5LxK/FkAsZTaLFwgn8SyCVHYZEvCHCx3DIyi15umDMTcvoIA= x-ms-exchange-antispam-messagedata: tPbOh0TvUzVTQoDbzZFN+6PiK6Smmyl6pZj6smVELoARi5vA/G36BU5yZ/eqU2hxQoLfYumzEMWiXAGe68LWsMYohZD+wuWsAZIhA8FQwo/+2piKtEGrR98BE5qx75phDc3h3maE8O7qNS7t94y+iw== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 74f6c202-54bf-4db3-00da-08d7c3710942 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2020 14:57:35.5113 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1EUR04HT031 X-Spam-Status: No, score=-28.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Mar 2020 14:57:38 -0000 On 2/22/20 7:38 AM, Bernd Edlinger wrote: > On 2/9/20 10:07 PM, Bernd Edlinger wrote: >> Hi, >> >> this is based on Andrew's patch here: >> >> https://sourceware.org/ml/gdb-patches/2020-02/msg00092.html >> >> This and adds a heuristic to fix the case where caller >> and callee reside in the same subfile, it uses >> the recorded is-stmt bits and locates end of >> range infos, including the previously ignored empty >> range, and adjusting is-stmt info at this >> same pc, when the last item is not-is-stmt, the >> previous line table entries are dubious and >> we reset the is-stmt bit there. >> This fixes the new test case in Andrew's patch. >> >> It understood, that this is just a heuristic >> approach, since we do not have exactly the data, >> which is needed to determine at which of the identical >> PCs in the line table the subroutine actually ends. >> So, this tries to be as conservative as possible, >> just changing what is absolutely necessary. >> >> This patch itself is preliminary, since the is-stmt patch >> needs to be rebased after the refactoring of >> dwarf2read.c from yesterday, so I will have to rebase >> this patch as well, but decided to wait for Andrew. >> >> >=20 > So, this is an update to my previous patch above: > https://sourceware.org/ml/gdb-patches/2020-02/msg00262.html >=20 > It improves performance on big data, by using binary > search to locate the bogus line table entries. > Otherwise it behaves identical to the previous version, > and is still waiting for Andrew's patch before it can > be applied. >=20 >=20 Rebased to match Andrew's updated patch of today. Thanks Bernd.