From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AJ7pNpaZxl+bTgAAWB0awg (envelope-from ) for ; Tue, 01 Dec 2020 14:29:26 -0500 Received: by simark.ca (Postfix, from userid 112) id DDD441F0AB; Tue, 1 Dec 2020 14:29:26 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=FORGED_MUA_MOZILLA, FREEMAIL_FROM,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8CE551E58D for ; Tue, 1 Dec 2020 14:29:26 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3619B3851C19; Tue, 1 Dec 2020 19:29:26 +0000 (GMT) Received: from EUR06-AM7-obe.outbound.protection.outlook.com (mail-am7eur06olkn2031.outbound.protection.outlook.com [40.92.16.31]) by sourceware.org (Postfix) with ESMTPS id E4CA73851C19 for ; Tue, 1 Dec 2020 19:29:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E4CA73851C19 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aoUNvuWZ5TdP2iKu6yTSVLvvkPu9tdvgaULoNM+3ro6KVTZnnAZHEWdVG/LxGWl7UqqjfMdoGXvWWRMaMp8V06+83Suh2NcWrg6dz3PUW41Zwl/jQYAIrLiEGM/Pmi4tE2wBghSae8mTPLu2k0NQSMi6XQ2YDBgi3g2LopgI26vXUw+o9NgBw0E9ilwtqol31pb74WdQRuGsFWhwU66FswlwJGO3hbM9IieuuFZZ3X2YRiCplOF1eCIqkSStCiBRp8R3kcgrQNsjNv9q6+eHA8ojyIBAwBc6KxB4ybh4Vhp5ksNkp88XbaIxC0d1qimxOIcI3uhfbk9R/KKTdUE4+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mIAfdVBHsyMDSCi4hIlPbckUlaspCgkDW19YI26SR4k=; b=RU1bwhCrr6OqAPrhTGX6UusFaQJnrReY0N/bFmT2kpuhBNfCwHdBFKRDI4iBMIjH8P9gCEasSIsDdBdlBns/vJZwu7zmoJOH/Es4F0hbZVI2KwDka3jWDprVx9uy7fZNwhbZEKp+r1enEIXvUjwfLXHdEhjYnbQVPH3w+0QJ6Y/VK1fTF5DenqEhRrkZ28ty2LSEx4m5V+AgolwDe79n+rEXp/AGN9eFu6zJDTzgyMYzzUdWizJ8zXxFjD1/bZJ3T3mgC78ttoILz1INsMyCSSSBdZGQyHoavsEAJW+S67Xp613UhonOPVDrnnFbQMjqbjrmWnaccWzGmglYR0ABnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VI1EUR06FT057.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc37::49) by VI1EUR06HT040.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc37::144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.23; Tue, 1 Dec 2020 19:29:21 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (2a01:111:e400:fc37::45) by VI1EUR06FT057.mail.protection.outlook.com (2a01:111:e400:fc37::165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Tue, 1 Dec 2020 19:29:21 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:D36635C8E865C700ABBF8B8EB35300255D4391F40958A0F38843A72157C64920; UpperCasedChecksum:B22EEAFB6E739CF681C50748FAD6156E082356D019AEB818ACB9BC486CDAAD3A; SizeAsReceived:8433; Count:48 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::184e:5e8c:db8f:a596]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::184e:5e8c:db8f:a596%5]) with mapi id 15.20.3611.031; Tue, 1 Dec 2020 19:29:21 +0000 Subject: Re: [PATCH] Enable GDB build with in-tree GMP and MPFR From: Bernd Edlinger To: Joel Brobecker References: <1604817017-25807-1-git-send-email-brobecker@adacore.com> <1605429345-78384-1-git-send-email-brobecker@adacore.com> <1605429345-78384-2-git-send-email-brobecker@adacore.com> <20201116034518.GA609903@adacore.com> <20201118034455.GE617116@adacore.com> Message-ID: Date: Tue, 1 Dec 2020 20:29:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TMN: [ldNhLUbMGfFOQLaa/53gjF3hhoHsuJOM] X-ClientProxiedBy: AM4PR0202CA0006.eurprd02.prod.outlook.com (2603:10a6:200:89::16) To AM6PR03MB5170.eurprd03.prod.outlook.com (2603:10a6:20b:ca::23) X-Microsoft-Original-Message-ID: <1d43f6e7-ea94-6163-dad3-d66f8b7ea3fc@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (84.57.57.184) by AM4PR0202CA0006.eurprd02.prod.outlook.com (2603:10a6:200:89::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Tue, 1 Dec 2020 19:29:20 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 544e5d06-5e3c-4979-e2d2-08d8962f66ec X-MS-TrafficTypeDiagnostic: VI1EUR06HT040: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZJoqfYCEe4vDjF89HvDIM/IivvEj/2qEzVT8LMi7P0BoZDOgxPwhKbJMvHIJja6BAC6Z1rry1N8fgdScvydjTlCzN7NpkKurvy4DJYQBebx77YyfyOcAlvicw6JqLCzbiNXJ+oFRVaeqJ/xxrL7feFMMlpEYLAFqCY4xZTfUpwa3jK9JJtUD6wf6ejbUttv5M2OdHH8eeoAZZiTKlpWEkw== X-MS-Exchange-AntiSpam-MessageData: aHgd2VQf8fEhYgfHCFmdt7mg/f4IZRnvsBfeYg+iRziTn5efuD/pviVXuiYpFVtYejyzTPKjzxT3XV42olJoOOaV9sh3qA2SYEK4jZA9mKZDHFZYXlQmTebj0M72WNQzv/oj1FyA/38nM9gPrVXV6A== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 544e5d06-5e3c-4979-e2d2-08d8962f66ec X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2020 19:29:21.0423 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: VI1EUR06FT057.eop-eur06.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1EUR06HT040 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 11/18/20 9:14 AM, Bernd Edlinger wrote: > On 11/18/20 4:44 AM, Joel Brobecker wrote: >>> this enables GDB build with in-tree GMP and MPFR. >>> >>> This updated version of my patch added support for in-tree MPFR. >>> >>> While there is no preexisting --with-gmp configure option in gdb, >>> this leaves the current --with-mpfr=yes/no/auto as it is, since it seems >>> to work by accident. The top level config script thinks "no" is >>> a DIR, and skips the detection of in-tree MPFR in that case, while >>> gdb honors --with-mpfr=no, so that is what's expected. >>> >>> The in-tree build works only when no --with-mpfr and no >>> --with-gmp is given. While it does not advertise --with-gmp-prefix=DIR >>> and/or --with-mpfr-prefix=DIR with "./configure --help", I'll leave that >>> for another patch. >> >> I think we better sort the discrepancy between GCC and GDB >> if we can, but this is going to take time. From what you were >> explaining before, I believe you can separate this part of >> your patch (adding the above to GDB's configury) from the part >> where you're adding support for in-tree building? >> > > > 99% of the top-level configury is already there, but it needs > still a dependency between gdb and (in-tree) gmp / mpfr, > and pass the options where to find gmp and mpfr to gdb, > I don't know how to actually resolve the differences ATM. > If the top-level configure script advertises GDB-style options > It will at least have to translate them for in-tree MPFR, > MPC, and ISL. > > I believe this change is just the bare minimum and will not > cause additional incompatibilities with GCC. > > >>> Tested on x86_64-pc-linux-gnu and cross-build for arm. >>> Is it OK for the trunk? >> >> These are changes in areas I am not familiar with, and wouldn't >> have very much time to look into. I talked to Tom yesterday, >> and he kindly agreed to take a look. >> >>> From 503435680f463cf5ed060ce32b902051cb19e801 Mon Sep 17 00:00:00 2001 >>> From: Bernd Edlinger >>> Date: Sun, 15 Nov 2020 15:37:22 +0100 >>> Subject: [PATCH] Enable GDB build with in-tree GMP and MPFR >>> >>> With this patch GDB can be built with in-tree GMP and/or >>> MPFR. This works also for cross-builds. >>> >>> All that is needed, is a sym-link in the source tree, >>> like this: >>> >>> gmp -> ../gmp-6.1.0 >>> mpfr -> ../mpfr-3.1.4 >>> >>> 2020-11-15 Bernd Edlinger >>> >>> * Makefile.def: Prepare for GDB build with intree GMP. >>> * Makefile.in: Regenerate. >> >> I got the answer about approval for toplevel tree changes; we're still >> keeping in sync with GCC. However, Tom said that these kinds of changes >> are OK to discuss and eventually push locally, before we bring them >> to GCC next. It's better the other way around, but discussing them >> here is also an option, because it's a minor change taking advantage >> of infrastructure that's already in place. >> >> In this particular instance, I would indeed _not_ rush discussing >> with GCC, in case the tie with GDB affects the changes we would need >> in toplevel. >> > > Yep, agreed. > So, can this patch be applied ? I would really like to be able to build gdb with in-tree gmp / mpfr, just as it works for gcc. Thanks Bernd.