From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QErYAQbYtF/rHAAAWB0awg (envelope-from ) for ; Wed, 18 Nov 2020 03:15:02 -0500 Received: by simark.ca (Postfix, from userid 112) id 0572D1F08B; Wed, 18 Nov 2020 03:15:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.9 required=5.0 tests=FORGED_MUA_MOZILLA, FREEMAIL_FROM,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A23551E58E for ; Wed, 18 Nov 2020 03:15:01 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32E41386F00E; Wed, 18 Nov 2020 08:15:01 +0000 (GMT) Received: from EUR06-VI1-obe.outbound.protection.outlook.com (mail-vi1eur06olkn2011.outbound.protection.outlook.com [40.92.17.11]) by sourceware.org (Postfix) with ESMTPS id 4B3D9385800A for ; Wed, 18 Nov 2020 08:14:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4B3D9385800A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cbrvDO89Yria4YAEEffImWJLlIovEnNkldKNvBLYQv+zOmdJRLoIE/j8pLGd+AT5zc6cOo0ztRsoucY67mbh/OkIxhjctqNhs4/W0qHbFbns4/GN8mJgi6jeX9jwoG03g4R3bA3vyfmGZfT8wVQYWk7n6nIOmHm4OaUT19dXktJvIGkGoXgFli8oTBtO7Q2N434EfpkEbazLlXiSOf/fFFxOHXboVQLq9d+BFGtokr37iaau9cbH+w9cbq0RnzCGQW1z8FCeVz/wR44C8Tdipg5JyNnrdNT6w7qi+qnmF7/eb+RNgugl2f1Ec+NYaib2vNBfXLdwM2YPUzy187ResA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o192NFOte/8cvFoVlshz6EwsM6FvHtFNgg5z0TIbZIE=; b=Jt+2VGi7suRhGwAuetrRVjf2Teln8IdjKL9Hf1ZfhzdK1C6oXK6ZBg9MZ+UzGSb7NoZR2MtkH4IeliW6fOp/W2MeU9yXt0pYJnqCk7DilVCm3ROiKCjlamlZuWiqxwusLh3vrU3/rHofSi/YIbQi8YUxRXlaB8W1NrLeI9444wYTc2NNMDf9rjvlHxRL1UpdXf3dHpdsFofgkjFn0SK//s+suSwmT3dsEJ3SHPLQ+qgh285bjcMrGpCoSkgrjnqGfjfoNcH3M2UDlxR7DOJQDqeewm1kJ6GP1SmG2d+ml7JejV7xr24OMP8Pmt7vTN7hkNeJsIKAmHRw3KxYW/oOJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DB8EUR06FT031.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc35::47) by DB8EUR06HT083.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc35::396) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.22; Wed, 18 Nov 2020 08:14:56 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (2a01:111:e400:fc35::44) by DB8EUR06FT031.mail.protection.outlook.com (2a01:111:e400:fc35::112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Wed, 18 Nov 2020 08:14:56 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:2F385C1821436C161410394039EEEC8D4A321BDB0CA042AAF2015C0AAD251991; UpperCasedChecksum:AAC078CC23900898D23ABDAAFABD12A6586EED31C284D515044838FA7CC2FA32; SizeAsReceived:8308; Count:48 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::184e:5e8c:db8f:a596]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::184e:5e8c:db8f:a596%5]) with mapi id 15.20.3564.028; Wed, 18 Nov 2020 08:14:56 +0000 Subject: Re: [PATCH] Enable GDB build with in-tree GMP and MPFR To: Joel Brobecker References: <1604817017-25807-1-git-send-email-brobecker@adacore.com> <1605429345-78384-1-git-send-email-brobecker@adacore.com> <1605429345-78384-2-git-send-email-brobecker@adacore.com> <20201116034518.GA609903@adacore.com> <20201118034455.GE617116@adacore.com> From: Bernd Edlinger Message-ID: Date: Wed, 18 Nov 2020 09:14:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <20201118034455.GE617116@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TMN: [DVG4PEVeY2x1/MBp4MGnDlfxTiW5AwzO] X-ClientProxiedBy: AM8P189CA0008.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:218::13) To AM6PR03MB5170.eurprd03.prod.outlook.com (2603:10a6:20b:ca::23) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (84.57.57.184) by AM8P189CA0008.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:218::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Wed, 18 Nov 2020 08:14:56 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 8b19bc3c-7124-4cd3-7ada-08d88b9a08e1 X-MS-TrafficTypeDiagnostic: DB8EUR06HT083: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fVxZDhe3hjoCSn+Br7whPxEo56scTKM7ysHwq6lB6fXcuSjBR4wS1EFRDOfxalae/Wdk5QKLyOiDTWdJiRbMN1tSPP6IzFQTsVHsHmnf8Oxs5KrV9jmV5U2I6pSJ1mPgmowdxLkuxc7oUrCTPooCcCmgKn7+IYorbI4JqRVYzU+nsKlD8/wWXvo9MjkrfxuOoO5Z/z6wTgLM8m4ya+vxKQ== X-MS-Exchange-AntiSpam-MessageData: haSwFn5qayRwYMSptJnhE5Bf+wPJEyivAlVPbzQpkWKJl7sQuQz8UaWEePnhPwS1L2Rp0NaHNlL+QNdfaWe9vRyRTLXocgJswou4Gdf8KwvK2HjvfIlgz9NI2FzpvIuDbOJTSdAtKq6Uw0HS67ux1Q== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b19bc3c-7124-4cd3-7ada-08d88b9a08e1 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2020 08:14:56.6922 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DB8EUR06FT031.eop-eur06.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8EUR06HT083 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 11/18/20 4:44 AM, Joel Brobecker wrote: >> this enables GDB build with in-tree GMP and MPFR. >> >> This updated version of my patch added support for in-tree MPFR. >> >> While there is no preexisting --with-gmp configure option in gdb, >> this leaves the current --with-mpfr=yes/no/auto as it is, since it seems >> to work by accident. The top level config script thinks "no" is >> a DIR, and skips the detection of in-tree MPFR in that case, while >> gdb honors --with-mpfr=no, so that is what's expected. >> >> The in-tree build works only when no --with-mpfr and no >> --with-gmp is given. While it does not advertise --with-gmp-prefix=DIR >> and/or --with-mpfr-prefix=DIR with "./configure --help", I'll leave that >> for another patch. > > I think we better sort the discrepancy between GCC and GDB > if we can, but this is going to take time. From what you were > explaining before, I believe you can separate this part of > your patch (adding the above to GDB's configury) from the part > where you're adding support for in-tree building? > 99% of the top-level configury is already there, but it needs still a dependency between gdb and (in-tree) gmp / mpfr, and pass the options where to find gmp and mpfr to gdb, I don't know how to actually resolve the differences ATM. If the top-level configure script advertises GDB-style options It will at least have to translate them for in-tree MPFR, MPC, and ISL. I believe this change is just the bare minimum and will not cause additional incompatibilities with GCC. >> Tested on x86_64-pc-linux-gnu and cross-build for arm. >> Is it OK for the trunk? > > These are changes in areas I am not familiar with, and wouldn't > have very much time to look into. I talked to Tom yesterday, > and he kindly agreed to take a look. > >> From 503435680f463cf5ed060ce32b902051cb19e801 Mon Sep 17 00:00:00 2001 >> From: Bernd Edlinger >> Date: Sun, 15 Nov 2020 15:37:22 +0100 >> Subject: [PATCH] Enable GDB build with in-tree GMP and MPFR >> >> With this patch GDB can be built with in-tree GMP and/or >> MPFR. This works also for cross-builds. >> >> All that is needed, is a sym-link in the source tree, >> like this: >> >> gmp -> ../gmp-6.1.0 >> mpfr -> ../mpfr-3.1.4 >> >> 2020-11-15 Bernd Edlinger >> >> * Makefile.def: Prepare for GDB build with intree GMP. >> * Makefile.in: Regenerate. > > I got the answer about approval for toplevel tree changes; we're still > keeping in sync with GCC. However, Tom said that these kinds of changes > are OK to discuss and eventually push locally, before we bring them > to GCC next. It's better the other way around, but discussing them > here is also an option, because it's a minor change taking advantage > of infrastructure that's already in place. > > In this particular instance, I would indeed _not_ rush discussing > with GCC, in case the tie with GDB affects the changes we would need > in toplevel. > Yep, agreed. Thanks Bernd.