From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064086.outbound.protection.outlook.com [40.92.64.86]) by sourceware.org (Postfix) with ESMTPS id DDB80389852F for ; Sat, 25 Apr 2020 07:06:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DDB80389852F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U2eE/rVy6q5KJx60k4AoajLHpofL0UFPIX1lJT6ep86xlYDKMlkH8YJQNxA23XhEmoTRyt4vTdiwEs+Kwzpl9TifRPhKmAoj3PVmvTZvSrSMCL+DqC3M7YyjOc42UwWoZ9sFmc0SOT5R62o07sCpPqJYlr/KmnGfV+2VAqeeRVe+B/85ZhyTPw0sjTx14CFqqMR7cyeDavZNDsBnQpEh2Jn5+OWFhJg6596iO+Oacs/82JWcwd7JM63XIv2gVQzNAuM+o2vi2FK+72u7PqBoxg2it0bvdTvS8vrT9POejYiPDF3jLZSbFpgfJ/aHcDnY6w5e5Xsqs7aZYojM+juzKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F6h5jLIo6dWF0PHDww4TX7kdaf6KzTa73rDCRC9wpq0=; b=h8Lnbqo/tNoGdbefNcOpfLNHETH3IaRTAuEsenK+z5XQ+y+h9PZYUfpZfF6Y/rlYyXKUVZuCqTQHrfBYGgvzW/x8RtGt33hIit4dR4QLD9jBwQsAQrY/1D2aXBeUSUMyYeg6m//Rjo0MAygDpHnE1Ff9u0tlsmv4vItS+dp88mMFQIlM9OEMp24UbOAveFEnga/3Y33wBNDlwZ8Kz82YSfM5HfOtzF8PO5Jl23/sXo2WZZb9iINOKp3AtpE/Baoqx5OBBFe9UAs/hPRfAMRy/K4BojYDmHpldx0C325uedrNTGpxFWJ9kqiz8LtEnE1w4b6O2cBn4eiq6fQRuKch0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hotmail.de; dmarc=pass action=none header.from=hotmail.de; dkim=pass header.d=hotmail.de; arc=none Received: from VE1EUR01FT022.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e19::47) by VE1EUR01HT240.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e19::207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.15; Sat, 25 Apr 2020 07:06:35 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (2a01:111:e400:7e19::45) by VE1EUR01FT022.mail.protection.outlook.com (2a01:111:e400:7e19::233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.15 via Frontend Transport; Sat, 25 Apr 2020 07:06:35 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:A804B6E850348943EB9DD30D847C8BB7C5D934FB45AC8CF3C7372AD493A4B357; UpperCasedChecksum:1DFF861B96F0070D0DD9B960110AE80DF3A79FA7CCAFD42EB362EAA0625E7A44; SizeAsReceived:8411; Count:50 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::d57:5853:a396:969d]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::d57:5853:a396:969d%7]) with mapi id 15.20.2937.020; Sat, 25 Apr 2020 07:06:35 +0000 Subject: Re: [PATCH 2/2] gdb: Preserve is-stmt lines when switch between files To: Tom Tromey , Andrew Burgess Cc: gdb-patches@sourceware.org, Alexandre Oliva References: <6e9b21a0002164cec014dfe4d94d816a376989b4.1585952198.git.andrew.burgess@embecosm.com> <20200414112841.GC2366@embecosm.com> <20200416171809.GJ2366@embecosm.com> <87lfmnql4g.fsf@tromey.com> From: Bernd Edlinger Message-ID: Date: Sat, 25 Apr 2020 09:06:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <87lfmnql4g.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM3PR07CA0142.eurprd07.prod.outlook.com (2603:10a6:207:8::28) To AM6PR03MB5170.eurprd03.prod.outlook.com (2603:10a6:20b:ca::23) X-Microsoft-Original-Message-ID: <88943876-315d-e8d7-c45e-05b148666cfe@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.102] (92.211.182.71) by AM3PR07CA0142.eurprd07.prod.outlook.com (2603:10a6:207:8::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.14 via Frontend Transport; Sat, 25 Apr 2020 07:06:34 +0000 X-Microsoft-Original-Message-ID: <88943876-315d-e8d7-c45e-05b148666cfe@hotmail.de> X-TMN: [7zTIv90nFPZWR7gKapwXnw2pzRDXmdBO] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: a18bcb8d-e10a-44dc-4ce0-08d7e8e730be X-MS-TrafficTypeDiagnostic: VE1EUR01HT240: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DdmUIkzde8jY43xEweGkFPM5icA5oXVDWCu/0CdaBCn2sJ2oNu9+Hd4HaG9bCIdNA/OjeIfA9Zdhvom8W7jdZCuX47c/EP1nCnxF8EVmcORH71Lnfbf2ObbnX23rFte0CPVxpuZEAf8vBpmJlOf/OF9gCGpIElyJ4oEyGgXtFh1XF6AiTUTaskoWZ4BTPI8SJS+itsaX+RgZIp5jmwpRUw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR03MB5170.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; X-MS-Exchange-AntiSpam-MessageData: rDbXTOgc0KfnAL/K30eD8gZwM9SrSPaidxKUCZXCpZghh3bhAKKO+WoLa6kKhroCeBh+UkRNQoDtmLxnCj939Fd5YU1D16Umnnuswfh75/8Cbq/d3NWlsLMTELSpvOcqLUYAPyIDenX7i/zpzOw3dA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a18bcb8d-e10a-44dc-4ce0-08d7e8e730be X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2020 07:06:35.2869 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR01HT240 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Apr 2020 07:06:38 -0000 CC Alexandre Oliva, who maintains this part of GCC. On 4/22/20 11:13 PM, Tom Tromey wrote: >>>>>> "Andrew" == Andrew Burgess writes: > > I read through the various threads on this topic, though I think maybe > not very well. > > IIUC, the issue at hand is that there are two proposed patches to fix > various issues in this area. > > > Andrew's patch takes us roughly to the status quo from before is-stmt > landed. This patch takes the view that GCC is currently buggy, so one > test is partly disabled; and there's a new bug so we can fix GDB once > GCC is fixed. > > Bernd's patch takes the view that GCC won't be fixed and tries to work > around the problem; it drops at least one "FILE:LINE" case that > currently works. > > > Is that a fair summary? There were many messages and details, so I'm > not sure I either understood it all or that it can be summarized like > this. > Yes, I agree with this summary. > If that's fair, then my inclination is to move forward with Andrew's > patch for the time being, with the primary justification being > conservatism. Bernd's patch can always land if/when we have some > clarification from GCC about whether the bugs there will be fixed. > > Let me know what you think. > I think if we take Andrew's patch the only possible outcome will be that gcc will disable that statement frontiers debug option by default, because they do not understand what we want from them. (I am one of them, but I came here to understand you better) Bernd. > Tom >