From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-oln040092068021.outbound.protection.outlook.com [40.92.68.21]) by sourceware.org (Postfix) with ESMTPS id C51B3387700A for ; Tue, 17 Mar 2020 18:52:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C51B3387700A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LT0fMGIVzJgKE+XW8dWQ131gg0C6xk/jHG1wmA/Jb9VRwOYfhrCQmMy7yl31eows7M4Ewy5PCl4rbcoXF9xX86ezVaI6V+38iZT/50R8dm+dR9B/oamimZHKiVGixUSDfyzaqdrfRa1Ns4bHDuo6ROXA59BlQbxer3n+lxhl9snA97RGWqtXLwmpq1TfDvhsW4aWwZcHJXdNtjATLJsqaCSJSmGtW874g6hankZ4NG/y25bbjvzrRB8teyDwIn++GZ9UJxkujL+pTZe1FonTRcWz2lT4h00Kczgkmfc38fjdp3IGXT9VvGHTnTK9pvzkAnk5CVZFnZdwi+CwblccJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PPL8zuyhVmHrCHm6e9FASuSCwQ3g90jV2m19EnVCXCY=; b=XasM5wkfAhhu3m2g6uCwcs9u4+Eo4+EGHYbbyih1BAiELpMiS9y8vf4SFHfTCv4I+gE662iV+4bng1fqr6OdCeeQJiDeElFD6w1GposyaaOkyaWl1qj3pKeYebU8Y9qKHFfe7jTWh7fu62br8wJW9iphDXAqURzl0yclANZzmNnLp0w8TfTECDR9nQKEJpb3sIizr3hoJOMfwZr/dnHuXZGa2HyoyuTagoMgRB9Tm1LMXYAhX2mmRf0HIj5NWMmfEHp31TRfhrNvoHS003OabfDqztN0/BQzF2utO7dG8bkhCkYEz50eP2iO/l8sgiPeJ8rP3WoqFeuDd1IMlsOt5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hotmail.de; dmarc=pass action=none header.from=hotmail.de; dkim=pass header.d=hotmail.de; arc=none Received: from VE1EUR02FT047.eop-EUR02.prod.protection.outlook.com (2a01:111:e400:7e1e::3c) by VE1EUR02HT145.eop-EUR02.prod.protection.outlook.com (2a01:111:e400:7e1e::300) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.13; Tue, 17 Mar 2020 18:51:59 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (10.152.12.56) by VE1EUR02FT047.mail.protection.outlook.com (10.152.13.237) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.13 via Frontend Transport; Tue, 17 Mar 2020 18:51:59 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:3CB3C536F35909682605BA48AEB68D8957498C3ED7C2992B0CDDABB28DB5C93B; UpperCasedChecksum:33BB9B72933EA60B5EE55AE989B959ED4159799B6FABF890522F1E9C0A027D88; SizeAsReceived:8163; Count:50 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::1956:d274:cab3:b4dd]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::1956:d274:cab3:b4dd%6]) with mapi id 15.20.2814.021; Tue, 17 Mar 2020 18:51:58 +0000 Subject: Re: [PATCHv2 2/2] gdb: Add support for tracking the DWARF line table is-stmt field To: Tom Tromey Cc: Andrew Burgess , gdb-patches@sourceware.org References: <87d09c3tmu.fsf@tromey.com> <875zf34086.fsf@tromey.com> <875zf2zvpm.fsf@tromey.com> From: Bernd Edlinger Message-ID: Date: Tue, 17 Mar 2020 19:51:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <875zf2zvpm.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM3PR05CA0145.eurprd05.prod.outlook.com (2603:10a6:207:3::23) To AM6PR03MB5170.eurprd03.prod.outlook.com (2603:10a6:20b:ca::23) X-Microsoft-Original-Message-ID: <45f63c32-c74b-5925-2683-f9161ddc4df9@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (92.77.140.102) by AM3PR05CA0145.eurprd05.prod.outlook.com (2603:10a6:207:3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.19 via Frontend Transport; Tue, 17 Mar 2020 18:51:57 +0000 X-Microsoft-Original-Message-ID: <45f63c32-c74b-5925-2683-f9161ddc4df9@hotmail.de> X-TMN: [iC9ZnSWqqkKrswudtvwL11cmQZyFmumj] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: e405591c-7de5-48df-c9b6-08d7caa4453a X-MS-TrafficTypeDiagnostic: VE1EUR02HT145: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QGBtYGlr+ROJWWfbi+U2ojMUyURUAALAkfNVR5fD7JjqEbwpDWxN5/1V92QosrHLNuD8Evaw1DDmTIz6wBtLTspiRwu3F3Ak5T3+QsZ4vk3eAFwrovDDN7AYi6ObxjwEpJ0Dlq6KXHcykxFoAkTerEBw7zYWbUVUYpWgL75vi3N+qQaWkI9Gpb+C9n9YmXne X-MS-Exchange-AntiSpam-MessageData: c4zlELy5TApW9QPhV/I4LRTj9puP3TGSfNS+V+C+bRdnWUSkPWSG23mjJE8rZSsR2AbP+ZrMSwEkegfZwO2zZoOupa5HhOjRvvf2nNhPW0IPpshpv0afV5jFZM+9gG3fj+LIYmvCNWwch2dCp/wUsA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e405591c-7de5-48df-c9b6-08d7caa4453a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2020 18:51:58.5300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR02HT145 X-Spam-Status: No, score=-7.7 required=5.0 tests=FORGED_MUA_MOZILLA, FREEMAIL_FROM, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2020 18:52:04 -0000 On 3/17/20 7:23 PM, Tom Tromey wrote: > Tom> Actually, when I back out the hunk, I get: > Tom> Breakpoint 1 at 0x80000042: file r.h, line 6. > Tom> However, in the past it appears this mentioned the function name. > > I think I'm mistaken about this, so IMO we can just drop this part and > focus on whether we should remove that buildsym.c hunk. > Agreed, I'd just remove that for now --- a/gdb/buildsym.c +++ b/gdb/buildsym.c @@ -683,20 +683,6 @@ struct blockvector * m_have_line_numbers = true; } - if (subfile->line_vector->nitems > 0) - { - /* If we have a duplicate for the previous entry then ignore the new - entry, except, if the new entry is setting the is_stmt flag, then - ensure the previous entry respects the new setting. */ - e = subfile->line_vector->item + subfile->line_vector->nitems - 1; - if (e->line == line && e->pc == pc) - { - if (is_stmt && !e->is_stmt) - e->is_stmt = 1; - return; - } - } - Andrew? > thanks, > Tom >