From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17879 invoked by alias); 10 Feb 2020 18:30:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17842 invoked by uid 89); 10 Feb 2020 18:30:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:190, H*r:208, H*f:sk:cover.1 X-HELO: EUR05-AM6-obe.outbound.protection.outlook.com Received: from mail-am6eur05olkn2070.outbound.protection.outlook.com (HELO EUR05-AM6-obe.outbound.protection.outlook.com) (40.92.91.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Feb 2020 18:30:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U+cYnC57DS1XMBLlNSSBLC5fB4hpw5FlvKAbSelIWrVwJcvgtEEQK+obsP3mP/SDUs0mGfZgIbjlS9OZv4fy5TU4p/9bu8v22blaVEmcFl6l/XNpA+OZra/yoLVoEdGttyRlPD9WcepuT2QPS+pOlGB+sbogauG5/jWcLY4Kv5qiuuNNHaVQ0RvI4jGy8tUcRI/clrvYILJle6S5Armz9SXfwk9yIumaIpsP/qvMNZD1egBjIu14ZsYAjTuoyQ5Mdra+ld13kTRti/SUpUPrjV5egT11nLviNwulr+s8Tp/79zXPmXg+060G4Ui/txcldcdNHM1sInu7meHUaTiY0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HrQyR1JoedkfvcYfuyzLyN/NAN8RiO9j9p7/AyY9YIw=; b=hrlmt5Lfswhyeg6VFiMmDBdrZTudJpFtWj+R4KRVK6W+FW2AfYrTD+fmPoECVaM75Sv8NjrZHTMqyZZ3UuLuxfgvm6gKYL6e97DfBrx+GVywFcBeG60qlKdRddc2RUR1x9Pe0Z0jnyhlnRtxxePNgDFInB/k7CdS8KE+qJcdMUIeZu+KgGizxXjt2QMMmh9kI7O1FTwIwytWsZv16oIaxj/36fYeIBo/QaWZF2A/+1/v4Hub7GD7wt3TiJ4YNP4haGBtKEwKwcR2rxc6fBrVP7/1c/N7+QkSy2ubf/HuU5hUULV9qYoLphrLUaB/A4M2RNCvJlxXT2l16xIrvWxP9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DB8EUR05FT005.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc0f::33) by DB8EUR05HT057.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc0f::178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21; Mon, 10 Feb 2020 18:30:53 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (10.233.238.56) by DB8EUR05FT005.mail.protection.outlook.com (10.233.239.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21 via Frontend Transport; Mon, 10 Feb 2020 18:30:53 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::1956:d274:cab3:b4dd]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::1956:d274:cab3:b4dd%6]) with mapi id 15.20.2707.030; Mon, 10 Feb 2020 18:30:53 +0000 Received: from [192.168.1.101] (92.77.140.102) by AM0P190CA0009.EURP190.PROD.OUTLOOK.COM (2603:10a6:208:190::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.23 via Frontend Transport; Mon, 10 Feb 2020 18:30:52 +0000 From: Bernd Edlinger To: Andrew Burgess , "gdb-patches@sourceware.org" Subject: Re: [PATCH 2/2] gdb: Add support for tracking the DWARF line table is-stmt field Date: Mon, 10 Feb 2020 18:30:00 -0000 Message-ID: References: <94e33268f64060fc887670f4ee5ed524050cbcc7.1580902412.git.andrew.burgess@embecosm.com> In-Reply-To: x-microsoft-original-message-id: <53609466-9fad-5d13-9f93-dfa8c7c8f039@hotmail.de> x-ms-exchange-antispam-messagedata: 6JSVWOmmUPauxDhl3jwRidvPV0ld6vYr2Nd/hn9NP2GuQRX61JoCjkX3091rvY6edwdEuDj60lc873L23RVK59eEnyttynD4NkUUT1KH11jGKL+DH22Pw1FDqenkrHvxAgIsSeXv0lG02l8wunI9Nw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2020-02/txt/msg00291.txt.bz2 Hi, I just did a rebase of your patch, (and was surprised that it worked), but got an interesting message from git: First, rewinding head to replay your work on top of it... Applying: - is-stmt patch Using index info to reconstruct a base tree... A gdb/dwarf2read.c :874: space before tab in indent. [expr [gdb_get_line_number "main end"] \ :1128: space before tab in indent. [expr [gdb_get_line_number "main, set var to 0"] \ :1143: space before tab in indent. [expr [gdb_get_line_number "main end"] \ warning: 3 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging gdb/dwarf2/read.c and indeed there are SPACE followed by TAB in gdb/testsuite/gdb.dwarf2/dw2-is-stmt-2.exp not sure if that is only because I copied these lines out of the E-mail and messed it up by doing so, or if the whitespace is wrong in the original patch as well. Thanks Bernd.