From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-oln040092067043.outbound.protection.outlook.com [40.92.67.43]) by sourceware.org (Postfix) with ESMTPS id E1FD1385DC06 for ; Wed, 1 Apr 2020 18:40:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E1FD1385DC06 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hLUmIcxxgxj1UCt6c09au6OyJXeGR+mYX2oIJMBifuTDUcEy/T+HkS8jtUwHBFt2V+eOixRZJpAewOYmdhpGRhE50mAFYkdtvwXgEz1WCo+Jqdmti3NqFtxn0EEPmbqEPulgby2Q2h547h3HxG+Up7JOr2niYXRlodQ/msU4uZdPrUEtGwKjkNaTAeHI3nZWNx9s22x33VAtJ74nhlC2Md4N/0z4gDAxk5dAfn+Z7EJjMjpaNA1yl71wLwj/eDy8YKgEHzc3VMcu1ILc/+nG+C/XTdF3L5oT40Qwk5XsVwPyiceMC8VAIsF5KY1xATgy7gM4XktRwBrwIP3OkSEvVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hvJsNwO6Z8J638ZDTrHN8ZHFK52W9VQRvk34gDyeZ2Y=; b=VQpzZzQrFTgO6PD/3WXHYRaz1C6R/6lLpLupyYj2GxTbZUGSbWSKWp77IUnBAJ84tv/IYLDwwEaR8omqxFgulFM1Nz9tyHTyfIOnE43lCbtmlk5VBetL6w5Rh8Nxkd9lkKdu6HTbKR1W/FOVY2+og0ffqx7ObFKYVST1tER9N3D24UvMjZzzRoPIX0mA8a1QDhufqiGG6B9135nTPIpyfaIC0QKbPEIFIPyJmtntjaHJAadI3afhe9vMqB444LZBOBDtFC7tta3JrJrNLdXS4ErWkWs1QdP1SoSfEbxD1p67rgLxcgtnoOGGVBwzlZFPzCehHbKUnLZDahY1Wpi9Yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hotmail.de; dmarc=pass action=none header.from=hotmail.de; dkim=pass header.d=hotmail.de; arc=none Received: from HE1EUR02FT003.eop-EUR02.prod.protection.outlook.com (2a01:111:e400:7e1d::4b) by HE1EUR02HT126.eop-EUR02.prod.protection.outlook.com (2a01:111:e400:7e1d::187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17; Wed, 1 Apr 2020 18:40:02 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (2a01:111:e400:7e1d::43) by HE1EUR02FT003.mail.protection.outlook.com (2a01:111:e400:7e1d::98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15 via Frontend Transport; Wed, 1 Apr 2020 18:40:02 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:05D70B478611E344881F7FEBECECA4A0A6724BFE14F11FD7387F14AF29BBF91C; UpperCasedChecksum:E5490F8046C280685C8344C5CD95892617C84A3B6564DB29420469260AE28E09; SizeAsReceived:8191; Count:50 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::d57:5853:a396:969d]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::d57:5853:a396:969d%7]) with mapi id 15.20.2856.019; Wed, 1 Apr 2020 18:40:02 +0000 Subject: Re: [PATCH v3 2/2] Fix an undefined behavior in record_line From: Bernd Edlinger To: Tom Tromey Cc: "gdb-patches@sourceware.org" , Andrew Burgess References: <87eet741k5.fsf@tromey.com> Message-ID: Date: Wed, 1 Apr 2020 20:40:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR07CA0029.eurprd07.prod.outlook.com (2603:10a6:208:ac::42) To AM6PR03MB5170.eurprd03.prod.outlook.com (2603:10a6:20b:ca::23) X-Microsoft-Original-Message-ID: <28446846-64f3-7322-3f33-6614d030720a@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (92.77.140.102) by AM0PR07CA0029.eurprd07.prod.outlook.com (2603:10a6:208:ac::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.12 via Frontend Transport; Wed, 1 Apr 2020 18:40:01 +0000 X-Microsoft-Original-Message-ID: <28446846-64f3-7322-3f33-6614d030720a@hotmail.de> X-TMN: [zR1NXLSprX6YywAJdIzGF1AidBoF11s+] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: e09a4a2d-00e4-41da-fe89-08d7d66c1690 X-MS-TrafficTypeDiagnostic: HE1EUR02HT126: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RPlxLHt5hkpVJmmFvK76fRMXjZcEamlUY3v4ytS3AQLRNN13sHmXtTQ4YN8XItQZfwinr/XGbbagNGw3sT3IayqkLKOSv5k1V5yeC+bJDdtobf9Iz15fZ2qyAeS3cykujwpKCE5D+gR0J5OMYqrVDDsX94X8aqyXkm2ck9S7OQrg7fjn7I6Opd6b5sFuklcT X-MS-Exchange-AntiSpam-MessageData: LyA6GGp0ceS62tFIRZ6OGmaxsuQ99XvaDyYbllMIJ4j54maI209GsDxOPCDhv7RcQAo0J5+oqtvuYtjXhrRNIxNIu8NTCBdFK5ehbKBrSvaJZKDmDWBtJge9xcrjlOoXFiIi5YGwQNMVnCmYVVN3bQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e09a4a2d-00e4-41da-fe89-08d7d66c1690 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2020 18:40:02.3705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR02HT126 X-Spam-Status: No, score=1.0 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 18:40:06 -0000 On 4/1/20 6:52 PM, Bernd Edlinger wrote: > On 4/1/20 6:23 PM, Tom Tromey wrote: >>>>>>> "Bernd" == Bernd Edlinger writes: >> >> Bernd> Additionally do not completely remove symbols >> Bernd> at the same PC than the end marker, instead >> Bernd> make them non-is-stmt breakpoints. >> >> Bernd> 2020-03-27 Bernd Edlinger >> Bernd> * buildsym.c (record_line): Fix undefined behavior and preserve >> Bernd> lines at eof. >> >> IIUC this fixes: >> >> Bernd> + give surprising results. Expect gdb.cp/step-and-next-inline.exp >> Bernd> + to fail if these lines are not modified here. */ >> >> ... but doesn't regress anything else? >> > > I did my best to compare the test results with and without this > patch, but I have plenty of time, and can repeat that test before > I commit, just to make sure that it is still the case. > >> In that case I think it's fine. Thank you. >> >> Tom >> > > Thanks > Bernd. > One last question, does this approval also include part 1/2 "Fix the resizing condition of the line table" ? Thanks Bernd.