From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075033.outbound.protection.outlook.com [40.92.75.33]) by sourceware.org (Postfix) with ESMTPS id 10E87385DC00 for ; Sat, 4 Apr 2020 16:34:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 10E87385DC00 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GE3yEVBeI8srNNqIFl1lE9yCmPUOc+3AX/Gz9j14Vc3lFze4tmbfuukpX3p9WR2EIHn4kUQ7EzmvVY8RWVuV6qgiZzcWb+Fi1S1nrTY0bcCA3y/VwPEpqLlmiX0g83yTWNrhv1E9lcmYA96xjbDo2aYb5N6awmkEDURc16hH85w5bg4V2EaxEC6mYnpyaUKcpoFtWvxOtH7dEMqNPQCcMoVYWx2wW/S96mbD/cQpigVFfobV5noa6OiWxoCT2x+z4p68ca2EYG/JA9QeE04isxMO7d5X/DNhnPj5ff4vb5cscnERGlw3r9UxolX98BMKgU6iC4oZXp4yaKMB+4vGOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BA0AMoZVw2ir4J+kWEQAZU5BZBY/hx4vHYgKs9luIr8=; b=WGgSWLin5oYeKbCoVymUEs5xcTRKMT1sHgV5lmUeY+M1L6j6N9s31CN84UnIZE0ZQBshKe603WHOKwxpDc/fQEFoTzDvTm7L9qEZSJv5d2WLRdXWCNISu8ef6N+sVC36kBYsE8JQqrY+j35G3t+2K7Ms0UfviWfsE6/kui2XLDdIECiMEy9gAqOjOlLf0chewoB/+ynAEJ/uHaN/oFDW5v8D+yg4YiL9iCol8RADrogMmNhIwLburOJdcn0w3vhY4V4lY1TjDBHFvXD34zliUwN5Fuk2hOX5dR3Ek4bieHnCtipF65+4yKz+zMPIaYCVZuNCzrgmjqP83GtDiBs+TA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hotmail.de; dmarc=pass action=none header.from=hotmail.de; dkim=pass header.d=hotmail.de; arc=none Received: from DB3EUR04FT049.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0c::4b) by DB3EUR04HT209.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0c::190) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Sat, 4 Apr 2020 16:34:08 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (2a01:111:e400:7e0c::4f) by DB3EUR04FT049.mail.protection.outlook.com (2a01:111:e400:7e0c::295) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15 via Frontend Transport; Sat, 4 Apr 2020 16:34:08 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:2F22F208F4C604E28EBD843ADBC1650615E2BE985E906F21974886CB4B6F2EE4; UpperCasedChecksum:847D75CC8829D6D6AB93FF34BA5A2BB2B18970AAFEEB9E0423F937B111FA5969; SizeAsReceived:8445; Count:49 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::d57:5853:a396:969d]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::d57:5853:a396:969d%7]) with mapi id 15.20.2878.018; Sat, 4 Apr 2020 16:34:08 +0000 Subject: Re: [PATCH v3 2/2] Fix an undefined behavior in record_line To: Luis Machado , "gdb-patches@sourceware.org" , Andrew Burgess References: <3a407c0c-e63b-4c3f-dec2-57ff7470164b@linaro.org> <37b43cd4-de96-7e5c-7c17-09e5887af5d0@linaro.org> From: Bernd Edlinger Message-ID: Date: Sat, 4 Apr 2020 18:34:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <37b43cd4-de96-7e5c-7c17-09e5887af5d0@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::14) To AM6PR03MB5170.eurprd03.prod.outlook.com (2603:10a6:20b:ca::23) X-Microsoft-Original-Message-ID: <84380dcb-91a5-ff8d-047d-558b918db0cb@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (92.77.140.102) by FRYP281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.19 via Frontend Transport; Sat, 4 Apr 2020 16:34:08 +0000 X-Microsoft-Original-Message-ID: <84380dcb-91a5-ff8d-047d-558b918db0cb@hotmail.de> X-TMN: [wXl3YmOe2rP5Uy1IJXki8AUlXgysI3Ok] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 988bdccf-e1a4-4eb5-b117-08d7d8b5ff77 X-MS-TrafficTypeDiagnostic: DB3EUR04HT209: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mnB2OQMMCi7snIzQuuXJ0gDbLipn2lh6K/mS0AZWCe3otHmomtAoOspOIhxnzKFWHYlg/BRzzyviOD9Vhl7ev9+huhfa9Ops/Qaam39Rcm1Wexf7esCom8i9zByGuwqIz1OscfrYPtLGkC1pEaSNyuexpjLLMabrdf7einpMJNGAZ+58h0BsDLpAlrWiXA5c X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR03MB5170.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; X-MS-Exchange-AntiSpam-MessageData: O0hlKMAmPJdBuyRAYl6G1QyDYxsvvgD5kDNygdx2mtyjYIhmTtf7C6r7IXnCrXTaGg10XHi/UYEtBfFL3dcbQGFXfZmZfH1cYG0vpyNIPBM9HVwtKlXyAA5UI5UVxkE5jVIe4K9840oy2yY7CLBNIw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 988bdccf-e1a4-4eb5-b117-08d7d8b5ff77 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2020 16:34:08.5907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3EUR04HT209 X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Apr 2020 16:34:11 -0000 Okay, I think I see what is wrong. Line Number Statements: [0x000000b4] Extended opcode 2: set Address to 0x73c [0x000000bf] Advance Line by 75 to 76 [0x000000c2] Copy .... [0x00000129] Extended opcode 2: set Address to 0x73c [0x00000134] Advance Line by 1 to 73 [0x00000136] Copy [0x00000137] Extended opcode 1: End of Sequence so the second line was previously deleted, but now it is a non-is-stmt line. The address is the same, There was previously a discussion that two consecutive line-entries are a rogue method to notify the debugger of where the end of header is. I don't recall in the moment where this code is located. But if someone could point out the place to me, I could probably add code to ignore non-is-stmt lines, Andrew, are you already on that target, with one of your patches from yesterday? Thanks Bernd.