From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83574 invoked by alias); 20 Mar 2018 14:29:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83562 invoked by uid 89); 20 Mar 2018 14:28:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:15.20.0609.010, H*RU:15.20.0609.010, H*r:15.20.0609.010, officer X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0081.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Mar 2018 14:28:57 +0000 Received: from AM3PR08MB0625.eurprd08.prod.outlook.com (10.163.188.151) by AM3PR08MB0280.eurprd08.prod.outlook.com (10.161.35.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Tue, 20 Mar 2018 14:28:54 +0000 Received: from AM3PR08MB0625.eurprd08.prod.outlook.com ([fe80::f4e6:1ec6:cfa:fcd2]) by AM3PR08MB0625.eurprd08.prod.outlook.com ([fe80::f4e6:1ec6:cfa:fcd2%2]) with mapi id 15.20.0609.010; Tue, 20 Mar 2018 14:28:54 +0000 From: Stephen Roberts To: "gdb-buildbot@sergiodj.net" , "gdb-patches@sourceware.org" CC: nd Subject: Re: Oh dear. I regret to inform you that commit 4ee89e903de920496a69c01df70db13a70a2a0be might be unfortunate Date: Tue, 20 Mar 2018 14:29:00 -0000 Message-ID: References: <4ee89e903de920496a69c01df70db13a70a2a0be-master-breakage@gdb-build> In-Reply-To: <4ee89e903de920496a69c01df70db13a70a2a0be-master-breakage@gdb-build> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Stephen.Roberts@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0280;6:eHfZA0ZDJH9LpR0iq+ZFSEG+l2i2ReXdPg2jh07q8Ou4A0nqFEC7Hfwbjyp9mjCN9jGDxrWSo+0CYe3cEzCybnAwvSbclbQNx0i5laiYRexKg/gccgAuuPHDkzRzBR1mrtHK4hpFkppTiL58zEJZXDCdv87JCts6fhpESH4hxnCgqF18c/PG0WmdH9HH2mJIUwxzwyCWY8fIrfzL1ROVjTIyR3U3I/prbMpAMmDD6yqB7JAY/eA+situcqTJaw/jwZ/BhPP0MaJSpsQoecKKg3PawXljytLLsRV6zp2esqES5xorewqoK/prVsPCH38vD/K3o/MCSmYW/NJVoGwPNbJ+5kSIgIDF95L1gm+LMTqUHAQw8E9ihF9/mDk9uXVU;5:47CdrqSSnYJ+qyipUHgnC0KQ7uCFJyrxQctDahDX9RFF6bf2xxtA9F6287tWCt7GontckAPVWflgXAlCZUfNSSSEWFErkNxDy+1+wn3Y+dACcOaOxJbCUJ4z058HmwHNIzVAgM1wt6AYxvhmj2pimh3y3QYqglIwoT0z7ATZ5K4=;24:Vu27LnKYi0tAS50osPWlUP9geo3NrSvSRghPmX5VySOKe+k0NdWEnmm+VGmlNmd0oz+EGSLXUtz4tPCumiK5eZnT2GfRtBWIRVYfxBKatn0=;7:KbbQIOi/TRseoP7BRReX8Mkhxbtxjve491VBMxs0jg4nuLXeKIJd3ptL4gNrbsvp/UGIuDsXemP1h3lvoW0AlpUqLkQ16+N2TXh1zfGvJoLnLuEdHHrYKqL5ngCWmbvCnAsahQdcXa67F7JGQslPimv5y6vjD2h7PTyx6A4iFTsdOkqemWznJ+VN44HBXKiUwq4X6IEjWnIxTtzWW+lsEIYk6DwJ6I7JgutL3/eN+tmDOUliC6V749Xzw/TbkCE+ x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c00515bb-cac6-4220-be1d-08d58e6ee8ba x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603328)(7153060)(7193020);SRVR:AM3PR08MB0280; x-ms-traffictypediagnostic: AM3PR08MB0280: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(788757137089); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231221)(944501311)(52105095)(10201501046)(6055026)(6041310)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011);SRVR:AM3PR08MB0280;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0280; x-forefront-prvs: 061725F016 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(39860400002)(376002)(396003)(39380400002)(346002)(199004)(189003)(15760500003)(25786009)(68736007)(26005)(86362001)(316002)(8676002)(575784001)(4326008)(7696005)(81166006)(81156014)(110136005)(8936002)(53546011)(102836004)(66066001)(2900100001)(76176011)(97736004)(6506007)(99286004)(105586002)(6246003)(55016002)(9686003)(6116002)(2906002)(3280700002)(3660700001)(14454004)(2950100002)(3846002)(229853002)(7736002)(6436002)(5250100002)(74316002)(305945005)(33656002)(53936002)(5660300001)(2501003)(106356001)(72206003)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0280;H:AM3PR08MB0625.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: yCpZkqSBrSbkUpY+jAtQHAfE+o2VU6WUPVT87SYp7ywhugEUZvCh1N0cJNypKK1RMTWVAUtrPGBHnFZzVeHED9M/x//uhf/VRbovkd81M4GZCjmjPXfdJzBtwS95IC5dhVOGZ30Vg10VlKALlKEb14vWHhMhDuG/WwL3EpABHKeLAJUPY1rm40I0Gz36SAIaYMnKf5ZN6TWxzTJyrdRHKoWnpnDx0ntfZbH7lgiZFTMyIinT+uZRDxHpS8P/6XNXQqF/yuG4ZcWmAOCExcJB/vof7syPC9qBh2z6o4HaBXNphPZvvscxf1wd86lh9PtwK3G80w5MKAsf8lc4muV0/Q== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: c00515bb-cac6-4220-be1d-08d58e6ee8ba X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2018 14:28:54.3751 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0280 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00378.txt.bz2 Apologies, I'm looking into this as a matter of urgency. It appears that my= patch has caused the indentation of the following block to become incorrec= t. Sorry,=20 Stephen R. --------- From: gdb-buildbot@sergiodj.net Sent: 20 March 2018 14:14 To: Stephen Roberts; gdb-patches@sourceware.org Subject: Oh dear. I regret to inform you that commit 4ee89e903de920496a69c0= 1df70db13a70a2a0be might be unfortunate =A0=20 My lords, ladies, gentlemen, members of the public. It is a matter of great regret and sadness to inform you that commit: =A0=A0=A0=A0=A0=A0=A0 Replace the linear search in find_pc_sect_line with a= binary search. =A0=A0=A0=A0=A0=A0=A0 4ee89e903de920496a69c01df70db13a70a2a0be might have made GDB unwell.=A0 Since I am just your Butler BuildBot, I kindly ask that a human superior officer double-check this. Please note that if you are reading this message on gdb-patches, there might be other builders broken. You can find more details about the unfortunate breakage in the next messag= es. Cheers, Your GDB BuildBot. =20=20=20=20 >From gdb-patches-return-146050-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Mar 20 15:11:45 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 117680 invoked by alias); 20 Mar 2018 15:11:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 117670 invoked by uid 89); 20 Mar 2018 15:11:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Mar 2018 15:11:43 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BE7B180AD238; Tue, 20 Mar 2018 15:11:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16E2410B0F5B; Tue, 20 Mar 2018 15:11:40 +0000 (UTC) Subject: Re: [RFA v2] (x86) Fix watchpoint using hardware breakpoint for some distro To: Xavier Roirand , gdb-patches@sourceware.org References: <1521209212-11264-1-git-send-email-roirand@adacore.com> <9c7c8586-2940-bea9-d3fb-a13b0d38a32e@adacore.com> Cc: brobecker@adacore.com From: Pedro Alves Message-ID: Date: Tue, 20 Mar 2018 15:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <9c7c8586-2940-bea9-d3fb-a13b0d38a32e@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-03/txt/msg00379.txt.bz2 Content-length: 1151 On 03/20/2018 02:28 PM, Xavier Roirand wrote: > Hello Pedro, > > I've replied to your comments and attached a v2 patch. > > Le 3/19/18 à 3:28 PM, Pedro Alves a écrit : >> A few things are missing here: >> >> #1 - kernel versions where this was observed. >> > > CentOS: 2.6.18-419.el5 > Suse: 2.6.27.19-5-pae > >> #2 - If it's not equal to TRAP_HWBKPT, then what's it equal to? >>       I assume zero? > > No, it's equal to 1. Hmm, that's TRAP_BRKPT nowadays. What was '1' supposed to mean in kernels of such vintage? What was it's symbolic name back then? In the table in linux-ptrace.h, we see that modern kernels report TRAP_BRKPT/1 for the "single-stepping a syscall" case. What do those older kernels report in that case then? >> Does the step-into-watchpoint case result in TRAP_TRACE, or does >> that result in 0 too?  That affects the "continue" in the comment above. > > This results to a value of 1 too. What do those kernels report for hardware _breakpoints_? Is it 1 too? Wondering whether we should make GDB_ARCH_IS_TRAP_HWBKPT return true for 1 too... Please provide a more complete picture. Thanks, Pedro Alves