From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98092 invoked by alias); 14 Dec 2019 13:57:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98083 invoked by uid 89); 14 Dec 2019 13:57:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=formatpatch, entities, format-patch, sendemail X-HELO: EUR02-VE1-obe.outbound.protection.outlook.com Received: from mail-oln040092069070.outbound.protection.outlook.com (HELO EUR02-VE1-obe.outbound.protection.outlook.com) (40.92.69.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Dec 2019 13:57:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AYqEUPBv15JjHkSXxmIzy/qIvhvtCPCD5S7sQQB8Rk95XahbZ40s9CYbnypxacJM2RRULrV5O93y4IKdYsUKEKLbLfnIs6NO4bHCW2iQiwb3D3QxqirTiJb311trYuYDMKqeMgFxJ7hVsHYHHKNW5aC3Gl2oTVVmg6Sk8B6E4B9srHO2eJkGyIJRZ34cHvr61gOHpdz/hNJAXk1dPyTHmSHi/DBQ9YXufwyhfk8kW6BgfUQ7Ihc5lnrD/+e1qmBRWJmSDA4NQ9VGK6n3pz8bD7/TZxrvrfh8WYNis88eOYfkkTT7/62ykhgn77X7phezDVFOIFwaUZOImvbkeV3+Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NZDqeFToB5NQ6brttjbhcA+Kz03E1c1JFnt0sbTMxhQ=; b=VM3E0xxqVaz/xj2iXv/R263VWg+5jJE7YmeysVk5kdIDlaRap7eISn4ifzwSLwMCKIzNFKVKiQMoRaGpZRiylDm0cPHofzU/W7kNiJmShUpFfhXp1HBcenPumTIvzA8y5U1kyz8ZUl1W3Yo4HbFij28qeFTUWdip9xQoFVi1b7bCKk0QMeKgTNlcCU48ZEAFxEyDDPcKESKOQ3r6mt4Tj0NuYKPsRFnZ98P7pMDCa9j0s1pp0Kf18Q/36BTwzlurK+mddkIbjWF9wKzxkwcvJz7AU3qjNQVhw40PqvOa7lHoYvl0QSZ8EBOBZl6e3kXDTkefgN9IrK5R/Tfg9aXCsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from HE1EUR02FT016.eop-EUR02.prod.protection.outlook.com (10.152.10.52) by HE1EUR02HT182.eop-EUR02.prod.protection.outlook.com (10.152.11.190) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14; Sat, 14 Dec 2019 13:57:04 +0000 Received: from AM0PR08MB3714.eurprd08.prod.outlook.com (10.152.10.53) by HE1EUR02FT016.mail.protection.outlook.com (10.152.10.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14 via Frontend Transport; Sat, 14 Dec 2019 13:57:04 +0000 Received: from AM0PR08MB3714.eurprd08.prod.outlook.com ([fe80::8dd1:fb18:6271:f769]) by AM0PR08MB3714.eurprd08.prod.outlook.com ([fe80::8dd1:fb18:6271:f769%7]) with mapi id 15.20.2538.019; Sat, 14 Dec 2019 13:57:03 +0000 From: Bernd Edlinger To: Andrew Burgess CC: "gdb-patches@sourceware.org" Subject: [PING] [PATCHv2] Fix setting breakpoints or stepping on line 65535 Date: Sat, 14 Dec 2019 13:57:00 -0000 Message-ID: References: <20191201220818.GI3410@embecosm.com> In-Reply-To: x-microsoft-original-message-id: <6ac7bca2-7b8d-53a6-0a35-cc55165aedac@hotmail.de> x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-ID: <86C247A3B1CAF44B93BCD70A3FCDB902@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2019-12/txt/msg00661.txt.bz2 Ping... I'd like to ping for this patch here: https://sourceware.org/ml/gdb-patches/2019-12/msg00049.html Thanks Bernd. On 12/2/19 7:04 PM, Bernd Edlinger wrote: > Hi Andrew, >=20 > On 12/1/19 11:08 PM, Andrew Burgess wrote: >> * Bernd Edlinger [2019-11-24 11:54:23 +0000]: >> >>> Hi, >>> >>> this removes code that is present from the very first git revisison >>> 7b4ac7e1ed2c4616bce56d1760807798be87ac9e from 1988. It was in the >>> gdb/dbxread.c at the time (and makes more sense for dbx line info format >>> since line numbers are 16-bit entities in that debug format and debuggi= ng >>> files with more than 65535 lines would not work anyway) but moved from >>> there to gdb/buildsym.c which is used for dwarf line info as well, and >>> excluding an arbitrary line number does certainly not make sense nowada= ys. >>> >>> >>> Thanks >>> Bernd. >> >>> From f202ae765b72ad6d17600eb661993a63191309f7 Mon Sep 17 00:00:00 2001 >>> From: Bernd Edlinger >>> Date: Sat, 23 Nov 2019 07:37:26 +0100 >>> Subject: [PATCH 1/2] Fix setting breakpoints or stepping on line 65535 >>> >> >> Bernd, >> >> Thanks for looking into this, and especially thanks for adding a test! >> >> Normally you should include the git commit message and ChangeLog along >> with your patch submission so that these can be reviewed too. 'git >> format-patch' and 'git send-email' can be useful for this, if you can >> get them setup. >> >=20 > Okay, I added changelog messages for gdb/ChangeLog and gdb/testsuite/Chan= geLog, > and improved the commit messages. > I hope you can handle the format-patch files as attachments.=20 >=20 >> Given the age of the code you're removing I think this change sounds >> reasonable. I assume there's no test that covers why this code should >> be there, so you see no regressions with this code removed? >> >=20 > No, there were no regressions (last full test on 24-11-19). >=20 >> I have a couple of minor issues with the test. If you address those >> and repost with commit message and ChangeLog this can be approved. >> >=20 > Fixed the test. >=20 > Thanks a lot for your review. > Is it OK for trunk? >=20 >=20 > Thanks > Bernd. >=20 >> Thanks, >> Andrew >> >> >> >> >>> --- >>> gdb/buildsym.c | 6 ------ >>> 1 file changed, 6 deletions(-) >>> >>> diff --git a/gdb/buildsym.c b/gdb/buildsym.c >>> index 79f8305..6c14f3f 100644 >>> --- a/gdb/buildsym.c >>> +++ b/gdb/buildsym.c >>> @@ -670,12 +670,6 @@ buildsym_compunit::record_line (struct subfile *su= bfile, int line, >>> { >>> struct linetable_entry *e; >>>=20=20 >>> - /* Ignore the dummy line number in libg.o */ >>> - if (line =3D=3D 0xffff) >>> - { >>> - return; >>> - } >>> - >>> /* Make sure line vector exists and is big enough. */ >>> if (!subfile->line_vector) >>> { >>> --=20 >>> 1.9.1 >>> >> >>> From 54a7631206a2cf54573fb4cc94474cb2f6f99245 Mon Sep 17 00:00:00 2001 >>> From: Bernd Edlinger >>> Date: Sun, 24 Nov 2019 09:37:22 +0100 >>> Subject: [PATCH 2/2] Add a test case for line 65535 >>> >>> --- >>> gdb/testsuite/gdb.base/line65535.c | 19 +++++++++++++++++++ >>> gdb/testsuite/gdb.base/line65535.exp | 26 ++++++++++++++++++++++++++ >>> 2 files changed, 45 insertions(+) >>> create mode 100644 gdb/testsuite/gdb.base/line65535.c >>> create mode 100644 gdb/testsuite/gdb.base/line65535.exp >>> >>> diff --git a/gdb/testsuite/gdb.base/line65535.c b/gdb/testsuite/gdb.bas= e/line65535.c >>> new file mode 100644 >>> index 0000000..d80a294 >>> --- /dev/null >>> +++ b/gdb/testsuite/gdb.base/line65535.c >>> @@ -0,0 +1,19 @@ >>> +/* This testcase is part of GDB, the GNU debugger. >>> + >>> + Copyright 2019 Free Software Foundation, Inc. >>> + >>> + This program is free software; you can redistribute it and/or modify >>> + it under the terms of the GNU General Public License as published by >>> + the Free Software Foundation; either version 3 of the License, or >>> + (at your option) any later version. >>> + >>> + This program is distributed in the hope that it will be useful, >>> + but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + GNU General Public License for more details. >>> + >>> + You should have received a copy of the GNU General Public License >>> + along with this program. If not, see . */ >>> + >>> +#line 65535 "line65535.c" >>> +int main() { return 0; } >>> diff --git a/gdb/testsuite/gdb.base/line65535.exp b/gdb/testsuite/gdb.b= ase/line65535.exp >>> new file mode 100644 >>> index 0000000..2535ba5 >>> --- /dev/null >>> +++ b/gdb/testsuite/gdb.base/line65535.exp >>> @@ -0,0 +1,26 @@ >>> +# Copyright 2019 Free Software Foundation, Inc. >>> + >>> +# This program is free software; you can redistribute it and/or modify >>> +# it under the terms of the GNU General Public License as published by >>> +# the Free Software Foundation; either version 3 of the License, or >>> +# (at your option) any later version. >>> +# >>> +# This program is distributed in the hope that it will be useful, >>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> +# GNU General Public License for more details. >>> +# >>> +# You should have received a copy of the GNU General Public License >>> +# along with this program. If not, see . >>> + >> >> Normally we like to add a short description of what the test is doing >> here - for new tests. Many old ones don't have this thought. >> >=20 > Okay, done. >=20 >>> +standard_testfile >>> + >>> +if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]= } { >>> + return -1 >>> +} >>> + >>> +gdb_test "break $srcfile:65535" \ >>> + ".*Breakpoint 1 at .*: file $srcfile, line 65535\\..*" \ >>> + "break at line 65535" >>> + >>> +return 0 >> >> I don't think this return is needed at the end of a test. >> >=20 > Okay, done. Works without. >=20 >>> --=20 >>> 1.9.1 >>> >>