From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48865 invoked by alias); 17 Dec 2019 14:56:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48857 invoked by uid 89); 17 Dec 2019 14:56:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=am, UD:a.m, a.m, gcc7 X-HELO: EUR05-AM6-obe.outbound.protection.outlook.com Received: from mail-am6eur05olkn2020.outbound.protection.outlook.com (HELO EUR05-AM6-obe.outbound.protection.outlook.com) (40.92.91.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Dec 2019 14:56:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TP3J0iQ13VuSP55IbF4X/BSI2rZpoaWiXGNpqKAo5N0EN4s53O6OTzazupX6zcoP/n03NAD88ri9e1k4adh8nNvr+IUguLPKiVHZhA5HnDHUQQ7vEJBH3WUMeD90ovzTnTBb28kyKOVcFPNiLCxR5wgg+SlbSxppmmwn3KbKvrTMXW/ccPcG1ZhXM02hr5axQ1RK1Ua1472OAIb5RVhgEESsjFf4UeOugr9825ylJyEOrPhYMjN16wxolSq8eXOoKyqwV0B+3/BLwK0G/XTPWerrvB9vQEUNlQ0aQiI/WaZvw2RwhFwduCP9QQ2rxmSNNP3HlUmiHsHbtFnPTnnX1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XYU3uUWGsa5nN13avr1JlPEgGZlntfhS5hgO9uXomHs=; b=Kttt3+0frZwWsL+MJ88tALkbF3ICxkBU7Sp8hDwSImibb+54G5mo4shi2+1kil961z5ywLenRF3Wgw2vz+OaWpSo9D3AHIHirevNO3V2GFygy3KJy6AU4zmLZz+OmwARu/GnKiIerErX/L12teNX4d3+iPyk/Xb4fHsxDrcxmrC1Xyj3EAwtpRp5soSh2ipPs8oYxtwyMtb9jlxBxckSkZatxRnjeIg3RD3oYlTw+gRBZJVU5422uP4IzzJejoib512Trd0/kJr6mejl3gy50qEkP4SLVPixQ64fOXBDqwxOzSU1ombw42mGFeO5wLWrfV+/ksW0ckwo2vnvEDwQsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VI1EUR05FT062.eop-eur05.prod.protection.outlook.com (10.233.242.51) by VI1EUR05HT015.eop-eur05.prod.protection.outlook.com (10.233.243.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14; Tue, 17 Dec 2019 14:56:24 +0000 Received: from AM0PR08MB3714.eurprd08.prod.outlook.com (10.233.242.53) by VI1EUR05FT062.mail.protection.outlook.com (10.233.243.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14 via Frontend Transport; Tue, 17 Dec 2019 14:56:24 +0000 Received: from AM0PR08MB3714.eurprd08.prod.outlook.com ([fe80::8dd1:fb18:6271:f769]) by AM0PR08MB3714.eurprd08.prod.outlook.com ([fe80::8dd1:fb18:6271:f769%7]) with mapi id 15.20.2538.019; Tue, 17 Dec 2019 14:56:24 +0000 From: Bernd Edlinger To: Simon Marchi , "gdb-patches@sourceware.org" Subject: [PATCHv2] Fix skip.exp test failure observed with gcc-9.2.0 Date: Tue, 17 Dec 2019 14:56:00 -0000 Message-ID: References: <505a3a3a-37e8-bdae-cd4e-3ab691270d59@simark.ca> In-Reply-To: <505a3a3a-37e8-bdae-cd4e-3ab691270d59@simark.ca> x-microsoft-original-message-id: <4155c8e5-738b-676e-bddd-1355b8db4980@hotmail.de> x-ms-exchange-transport-forked: True Content-Type: multipart/mixed; boundary="_003_AM0PR08MB3714A989DDE06BFDA1F60EABE4500AM0PR08MB3714eurp_" MIME-Version: 1.0 X-SW-Source: 2019-12/txt/msg00743.txt.bz2 --_003_AM0PR08MB3714A989DDE06BFDA1F60EABE4500AM0PR08MB3714eurp_ Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: quoted-printable Content-length: 3109 On 12/17/19 3:44 AM, Simon Marchi wrote: > On 2019-12-15 1:12 p.m., Bernd Edlinger wrote: >> On 12/15/19 2:05 PM, Simon Marchi wrote: >>> On 2019-12-15 6:30 a.m., Bernd Edlinger wrote: >>>> Hi, >>>> >>>> this is the split out patch on skip.exp which fixes a pre-existing >>>> compatibilty issue with that test case and gcc-9.2.0 (and gcc-10 from >>>> trunk of a few weeks ago at least, likely other versions too). >>>> >>>> >>>> Is it OK for trunk? >>>> >>>> >>>> Thanks >>>> Bernd. >>>> >>>> >>> >>> Hi Bernd, >>> >>> Just wondering, were you able to figure out which change in debug info = lead >>> to this behavior change? The behavior with gcc 9.2.0 seems better to b= e me, >>> I think your patch is ok. >>> >> >> Yes indeed. The change started with gcc-8.1.0 when -gcolumn-info was en= abled >> by default. -gcolumn-info was first implemented in gcc-7.1.0 but defaul= t-disabled, >> so you can get the altered behavior already with gcc-7 if you manually e= nable >> -gcolumn-info. >> >> So previously there was just one point where line line 30 (of skip.c) st= arted: >> >> [0x00000032] Advance Line by 27 to 28 >> [0x00000034] Copy >> [0x00000035] Special opcode 63: advance Address by 4 to 0x4004cb and = Line by 2 to 30 >> [0x00000036] Advance PC by constant 17 to 0x4004dc >> [0x00000037] Special opcode 7: advance Address by 0 to 0x4004dc and L= ine by 2 to 32 >> >> with column-info we have line 30 three times with different column: >> >> [0x00000034] Advance Line by 27 to 28 >> [0x00000036] Copy >> [0x00000037] Set column to 9 >> [0x00000039] Special opcode 63: advance Address by 4 to 0x4004c6 and = Line by 2 to 30 >> [0x0000003a] Set column to 17 >> [0x0000003c] Special opcode 75: advance Address by 5 to 0x4004cb and = Line by 0 to 30 >> [0x0000003d] Set column to 3 >> [0x0000003f] Special opcode 75: advance Address by 5 to 0x4004d0 and = Line by 0 to 30 >> [0x00000040] Special opcode 105: advance Address by 7 to 0x4004d7 and= Line by 2 to 32 >> >> >> That could probably be filtered in dwarf2read.c to keep the old behavior= , but I agree >> that the new behavior makes still sense, even if we cannot really use th= e column info >> in the line number info. >=20 > That is actually some very good info for anyone wondering why this change= was introduced! >=20 > Could you please put it in the commit message for posterity? >=20 Sure, good point. Attached is the new, reworded version of the patch. When I looked at it again, I stumbled over two wrong comments nearby, telling "# Return from foo()" when we actually return from bar(), and "# Return from bar()" when we actually return from foo()... :) >>> I would just remove the unrelated whitespace fix before merging. >>> >> >> Okay, I just replicated you advice regarding 8-space tab columns on >> skip-inline.exp in the other patch. Exactly those 2 lines were copied >> where the tabs were not used correctly. >=20 > Great thanks. Note that we can also fix skip.exp, just in another, obvio= us patch. >=20 Okay, will send a separate patch for the whitespace. Thanks Bernd. --_003_AM0PR08MB3714A989DDE06BFDA1F60EABE4500AM0PR08MB3714eurp_ Content-Type: text/plain; name="changelog.txt" Content-Description: changelog.txt Content-Disposition: attachment; filename="changelog.txt"; size=136; creation-date="Tue, 17 Dec 2019 14:56:23 GMT"; modification-date="Tue, 17 Dec 2019 14:56:23 GMT" Content-ID: Content-Transfer-Encoding: base64 Content-length: 188 Z2RiL3Rlc3RzdWl0ZToKMjAxOS0xMi0xNSAgQmVybmQgRWRsaW5nZXIgIDxi ZXJuZC5lZGxpbmdlckBob3RtYWlsLmRlPgoKCSogZ2RiLmJhc2Uvc2tpcC5l eHA6IEZpeCB0ZXN0IGZhaWx1cmUgb2JzZXJ2ZWQgd2l0aCBnY2MtOS4yLjAu Cg== --_003_AM0PR08MB3714A989DDE06BFDA1F60EABE4500AM0PR08MB3714eurp_ Content-Type: text/x-patch; name="0001-Fix-skip.exp-test-failure-observed-with-gcc-9.2.0.patch" Content-Description: 0001-Fix-skip.exp-test-failure-observed-with-gcc-9.2.0.patch Content-Disposition: attachment; filename="0001-Fix-skip.exp-test-failure-observed-with-gcc-9.2.0.patch"; size=3926; creation-date="Tue, 17 Dec 2019 14:56:23 GMT"; modification-date="Tue, 17 Dec 2019 14:56:23 GMT" Content-ID: <3E46031818736E4182C64D5E07624E54@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 Content-length: 5324 RnJvbSA1ODg0NzEzZWU4Nzk5MmM0MDExYWU5YjJkNDVmYmUxYmQyOWI5MTQw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuZCBFZGxpbmdl ciA8YmVybmQuZWRsaW5nZXJAaG90bWFpbC5kZT4KRGF0ZTogU3VuLCAxNSBE ZWMgMjAxOSAxMTowNTo0NyArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBz a2lwLmV4cCB0ZXN0IGZhaWx1cmUgb2JzZXJ2ZWQgd2l0aCBnY2MtOS4yLjAK CldlIG5lZWQgdG8gc3RlcCBhIHNlY29uZCB0aW1lIHdpdGggdGhpcyBnY2Mg dmVyc2lvbi4KVGhlIGZpcnN0IHN0ZXAganVtcHMgYmFjayB0byBtYWluIGJl Zm9yZSBlbnRlcmluZyBmb28uClByZXZpb3VzbHkgdGhlIGNvbnRyb2wgZmxv dyB3YXMgZnJvbSBiYXIgZGlyZWN0bHkgdG8gZm9vLgoKRnVydGhlciBhbmFu bHlzaXMgc3VnZ2VzdHMsIHRoYXQgdGhpcyBjaGFuZ2UgaW4gYmVoYXZpb3Ig c3RhcnRlZAp3aXRoIGdjYy04LjEuMCB3aGVuIC1nY29sdW1uLWluZm8gd2Fz IGVuYWJsZWQgYnkgZGVmYXVsdC4KVGhlIG9wdGlvbiAtZ2NvbHVtbi1pbmZv IHdhcyBmaXJzdCBpbXBsZW1lbnRlZCBpbiBnY2MtNy4xLjAgYnV0CmRlZmF1 bHQtZGlzYWJsZWQsIHNvIHlvdSBjYW4gZ2V0IHRoZSBhbHRlcmVkIGJlaGF2 aW9yIGFscmVhZHkgd2l0aApnY2MtNyBpZiB5b3UgbWFudWFsbHkgZW5hYmxl IC1nY29sdW1uLWluZm8uCgpQcmV2aW91c2x5IHRoZXJlIHdhcyBqdXN0IG9u ZSBwb2ludCB3aGVyZSBsaW5lIDMwIChvZiBza2lwLmMpIHN0YXJ0ZWQ6Cgog IFsweDAwMDAwMDMyXSAgQWR2YW5jZSBMaW5lIGJ5IDI3IHRvIDI4CiAgWzB4 MDAwMDAwMzRdICBDb3B5CiAgWzB4MDAwMDAwMzVdICBTcGVjaWFsIG9wY29k ZSA2MzogYWR2YW5jZSBBZGRyZXNzIGJ5IDQgdG8gMHg0MDA0Y2IgYW5kIExp bmUgYnkgMiB0byAzMAogIFsweDAwMDAwMDM2XSAgQWR2YW5jZSBQQyBieSBj b25zdGFudCAxNyB0byAweDQwMDRkYwogIFsweDAwMDAwMDM3XSAgU3BlY2lh bCBvcGNvZGUgNzogYWR2YW5jZSBBZGRyZXNzIGJ5IDAgdG8gMHg0MDA0ZGMg YW5kIExpbmUgYnkgMiB0byAzMgoKQnV0IHdpdGggLWdjb2x1bW4taW5mbyBl bmFibGVkLCB3ZSBoYXZlIGxpbmUgMzAgdGhyZWUgdGltZXMgd2l0aCBkaWZm ZXJlbnQgY29sdW1uOgoKICBbMHgwMDAwMDAzNF0gIEFkdmFuY2UgTGluZSBi eSAyNyB0byAyOAogIFsweDAwMDAwMDM2XSAgQ29weQogIFsweDAwMDAwMDM3 XSAgU2V0IGNvbHVtbiB0byA5CiAgWzB4MDAwMDAwMzldICBTcGVjaWFsIG9w Y29kZSA2MzogYWR2YW5jZSBBZGRyZXNzIGJ5IDQgdG8gMHg0MDA0YzYgYW5k IExpbmUgYnkgMiB0byAzMAogIFsweDAwMDAwMDNhXSAgU2V0IGNvbHVtbiB0 byAxNwogIFsweDAwMDAwMDNjXSAgU3BlY2lhbCBvcGNvZGUgNzU6IGFkdmFu Y2UgQWRkcmVzcyBieSA1IHRvIDB4NDAwNGNiIGFuZCBMaW5lIGJ5IDAgdG8g MzAKICBbMHgwMDAwMDAzZF0gIFNldCBjb2x1bW4gdG8gMwogIFsweDAwMDAw MDNmXSAgU3BlY2lhbCBvcGNvZGUgNzU6IGFkdmFuY2UgQWRkcmVzcyBieSA1 IHRvIDB4NDAwNGQwIGFuZCBMaW5lIGJ5IDAgdG8gMzAKICBbMHgwMDAwMDA0 MF0gIFNwZWNpYWwgb3Bjb2RlIDEwNTogYWR2YW5jZSBBZGRyZXNzIGJ5IDcg dG8gMHg0MDA0ZDcgYW5kIExpbmUgYnkgMiB0byAzMgoKVGhhdCBjb3VsZCBw cm9iYWJseSBiZSBmaWx0ZXJlZCBpbiBkd2FyZjJyZWFkLmMgdG8ga2VlcCB0 aGUgb2xkIGJlaGF2aW9yLCBidXQKdGhlIG5ldyBiZWhhdmlvciBtYWtlcyBz dGlsbCBzZW5zZSwgZXZlbiBpZiB3ZSBjYW5ub3QgcmVhbGx5IG1ha2UgdXNl IG9mIHRoZQpjb2x1bW4gaW4gdGhlIGxpbmUgbnVtYmVyIGluZm8gZm9yIG5v dy4KLS0tCiBnZGIvdGVzdHN1aXRlL2dkYi5iYXNlL3NraXAuZXhwIHwgMTYg KysrKysrKysrKystLS0tLQogMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlv bnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3Rz dWl0ZS9nZGIuYmFzZS9za2lwLmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJh c2Uvc2tpcC5leHAKaW5kZXggZDc2MzE5NC4uY2YyN2Q1YiAxMDA2NDQKLS0t IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9za2lwLmV4cAorKysgYi9nZGIv dGVzdHN1aXRlL2dkYi5iYXNlL3NraXAuZXhwCkBAIC0xNDEsOSArMTQxLDEx IEBAIHdpdGhfdGVzdF9wcmVmaXggInN0ZXAgYWZ0ZXIgZGlzYWJsaW5nIDMi IHsKICAgICB9CiAKICAgICBnZGJfdGVzdCAic3RlcCIgImJhciBcXChcXCkg YXQuKiIgInN0ZXAgMSIKLSAgICBnZGJfdGVzdCAic3RlcCIgIi4qIiAic3Rl cCAyIjsgIyBSZXR1cm4gZnJvbSBmb28oKQotICAgIGdkYl90ZXN0ICJzdGVw IiAiZm9vIFxcKFxcKSBhdC4qIiAic3RlcCAzIgotICAgIGdkYl90ZXN0ICJz dGVwIiAiLioiICJzdGVwIDQiOyAjIFJldHVybiBmcm9tIGJhcigpCisgICAg Z2RiX3Rlc3QgInN0ZXAiICIuKiIgInN0ZXAgMiI7ICMgUmV0dXJuIGZyb20g YmFyKCkKKyAgICAjIFdpdGggZ2NjIDkuMi4wIHdlIGp1bXAgb25jZSBiYWNr IHRvIG1haW4gYmVmb3JlIGVudGVyaW5nIGZvbyBoZXJlLgorICAgICMgSWYg dGhhdCBoYXBwZW5zIHRyeSB0byBzdGVwIGEgc2Vjb25kIHRpbWUuCisgICAg Z2RiX3Rlc3QgInN0ZXAiICJmb28gXFwoXFwpIGF0LioiICJzdGVwIDMiICJt YWluIFxcKFxcKSBhdCAuKiIgInN0ZXAiCisgICAgZ2RiX3Rlc3QgInN0ZXAi ICIuKiIgInN0ZXAgNCI7ICMgUmV0dXJuIGZyb20gZm9vKCkKICAgICBnZGJf dGVzdCAic3RlcCIgIm1haW4gXFwoXFwpIGF0LioiICJzdGVwIDUiCiB9CiAK QEAgLTI2MSw3ICsyNjMsOSBAQCB3aXRoX3Rlc3RfcHJlZml4ICJzdGVwIHVz aW5nIC1mdSBmb3IgYmF6IiB7CiAgICAgZ2RiX3Rlc3Rfbm9fb3V0cHV0ICJz a2lwIGVuYWJsZSA3IgogICAgIGdkYl90ZXN0ICJzdGVwIiAiYmFyIFxcKFxc KSBhdC4qIiAic3RlcCAxIgogICAgIGdkYl90ZXN0ICJzdGVwIiAiLioiICJz dGVwIDIiOyAjIFJldHVybiBmcm9tIGJhcigpCi0gICAgZ2RiX3Rlc3QgInN0 ZXAiICJmb28gXFwoXFwpIGF0LioiICJzdGVwIDMiCisgICAgIyBXaXRoIGdj YyA5LjIuMCB3ZSBqdW1wIG9uY2UgYmFjayB0byBtYWluIGJlZm9yZSBlbnRl cmluZyBmb28gaGVyZS4KKyAgICAjIElmIHRoYXQgaGFwcGVucyB0cnkgdG8g c3RlcCBhIHNlY29uZCB0aW1lLgorICAgIGdkYl90ZXN0ICJzdGVwIiAiZm9v IFxcKFxcKSBhdC4qIiAic3RlcCAzIiAibWFpbiBcXChcXCkgYXQuKiIgInN0 ZXAiCiAgICAgZ2RiX3Rlc3QgInN0ZXAiICIuKiIgInN0ZXAgNCI7ICMgUmV0 dXJuIGZyb20gZm9vKCkKICAgICBnZGJfdGVzdCAic3RlcCIgIm1haW4gXFwo XFwpIGF0LioiICJzdGVwIDUiCiB9CkBAIC0yNzYsNyArMjgwLDkgQEAgd2l0 aF90ZXN0X3ByZWZpeCAic3RlcCB1c2luZyAtcmZ1IGZvciBiYXoiIHsKICAg ICBnZGJfdGVzdF9ub19vdXRwdXQgInNraXAgZW5hYmxlIDgiCiAgICAgZ2Ri X3Rlc3QgInN0ZXAiICJiYXIgXFwoXFwpIGF0LioiICJzdGVwIDEiCiAgICAg Z2RiX3Rlc3QgInN0ZXAiICIuKiIgInN0ZXAgMiI7ICMgUmV0dXJuIGZyb20g YmFyKCkKLSAgICBnZGJfdGVzdCAic3RlcCIgImZvbyBcXChcXCkgYXQuKiIg InN0ZXAgMyIKKyAgICAjIFdpdGggZ2NjIDkuMi4wIHdlIGp1bXAgb25jZSBi YWNrIHRvIG1haW4gYmVmb3JlIGVudGVyaW5nIGZvbyBoZXJlLgorICAgICMg SWYgdGhhdCBoYXBwZW5zIHRyeSB0byBzdGVwIGEgc2Vjb25kIHRpbWUuCisg ICAgZ2RiX3Rlc3QgInN0ZXAiICJmb28gXFwoXFwpIGF0LioiICJzdGVwIDMi ICJtYWluIFxcKFxcKSBhdC4qIiAic3RlcCIKICAgICBnZGJfdGVzdCAic3Rl cCIgIi4qIiAic3RlcCA0IjsgIyBSZXR1cm4gZnJvbSBmb28oKQogICAgIGdk Yl90ZXN0ICJzdGVwIiAibWFpbiBcXChcXCkgYXQuKiIgInN0ZXAgNSIKIH0K LS0gCjEuOS4xCgo= --_003_AM0PR08MB3714A989DDE06BFDA1F60EABE4500AM0PR08MB3714eurp_--