Re: [PATCH 2/3] gdb: Don't reorder line table entries too much when sorting.

[Bernd Edlinger <bernd.edlinger@hotmail.de>]

Hi,

when I tried this patch, git am says this:

+foreach p $patterns {
+    gdb_test "step" "/\\* $p \\*/" \
+	"step to '$p'"
+}
+
-- 
2.14.5

Applying: gdb: Don't reorder line table entries too much when sorting.
/home/ed/gnu/binutils-gdb/.git/rebase-apply/patch:294: new blank line at EOF.
+
warning: 1 line adds whitespace errors.


I just was curious to try this patch series,
since this has some overlap with a patch I posted here:
https://sourceware.org/ml/gdb-patches/2019-11/msg00792.html

we both want to add end_sequence here:
> @@ -21330,7 +21331,8 @@ lnp_state_machine::record_line (bool end_sequence)
>    else if (m_op_index == 0 || end_sequence)
>      {
>        fe->included_p = 1;
> -      if (m_record_lines_p && (producer_is_codewarrior (m_cu) || m_is_stmt))
> +      if (m_record_lines_p
> +         && (producer_is_codewarrior (m_cu) || m_is_stmt || end_sequence))
>         {
>           if (m_last_subfile != m_cu->get_builder ()->get_current_subfile ()
>               || end_sequence)

I was not sure, if m_is_stmt is ever false when end_sequence is true,
but considered that to be safer this way too.
Does that actually happen?


Bernd.