Re: [PATCHv2] Fix setting breakpoints or stepping on line 65535

Simon Marchi
2019-12-29T20:41:20Z

On 2019-12-29 3:32 p.m., Andrew Burgess wrote:
> I place more value on having tests and changes in the same commit - I
> find it more useful the other way around, when I find some code I
> don't understand and I figure out which commit it came from, having
> the tests in the same commit means it is easy to know "this test"
> should check "this code".
>
> If the test and changes are separate I have to do more work. Boo!
>
> For this reason, if you've not already pushed this patch, could you
> collapse the test and change into a single commit please before
> pushing.

FWIW, that's my preference too.

Simon