From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gQtcBIfm/18ZGQAAWB0awg (envelope-from ) for ; Thu, 14 Jan 2021 01:36:55 -0500 Received: by simark.ca (Postfix, from userid 112) id 02E371EF80; Thu, 14 Jan 2021 01:36:55 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=FORGED_MUA_MOZILLA, FREEMAIL_FROM,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8B29B1E590 for ; Thu, 14 Jan 2021 01:36:54 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 018AE3858012; Thu, 14 Jan 2021 06:36:54 +0000 (GMT) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-oln040092072071.outbound.protection.outlook.com [40.92.72.71]) by sourceware.org (Postfix) with ESMTPS id 0ABB33858012 for ; Thu, 14 Jan 2021 06:36:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0ABB33858012 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fkCK/jRimklVo/lKpWobN9gBO615vPanL3peSrvLsDgIH/eAV31H4PyIOkVixpJR3Wx54uW348GNaKGf6TlvfnCpatEpkFTgXS06/VdXFSWjeIfDsJZDkVz4svrLj8mSqpWYTjv5xxzygvhz04QFFEWu+O+4o2NB3F6OnXqOJ7kd1v/1clFdIn0EQRPBVe4pRDeAgkIHnMpgUaauMjg8TSmawMoCFfpNpHKIClOhMaV7teR46etHUWLVpq1ZVCk+YW0IsDbMeCBI82hrfTJ7QdqENG4TPGcUv9xqmPn6TERe1qyqG/ASqlXKLhNiXWkhElWgnWERpX9KFzYL+AJELA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qj4hSfr0zjP4L1HE8K27gTTEQzHZnKSdEsYu8aG2jwc=; b=Z2gb/hvNV6OmxvkO9QP0IogeQtOw1yej6E5lkYjpN5EBuPpEKQ4uAfTAtapMQpunlm83Wgq+IV31ZmCHHzQRlbfgt0U+Yj4Qs20VZN47genmTJK/89WryvS7uhd7b7B0GLUfoTmM1JBHqWEdKVR9PWmIwAnlqIccoxN+aiDr05LNBU/lOdJkPDLJiqmOS4YNUkQFfugz8wYf4I82G+P2JPMHEh4dUh1V4viNVsl3kz6IwjnNFnp21y+VNRl0XQilm5aIwANYEja80cmNAB1fw9Sv/2TOOaGxDcRIcB7aGL/uaOfQxIcoDnM9+1oQkGvJ3NyH9S/cCeDrbsgGSVYkxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com (2a01:111:e400:7e08::4f) by AM5EUR03HT064.eop-EUR03.prod.protection.outlook.com (2a01:111:e400:7e08::445) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10; Thu, 14 Jan 2021 06:36:47 +0000 Received: from AM0PR0602MB3410.eurprd06.prod.outlook.com (2a01:111:e400:7e08::4f) by AM5EUR03FT043.mail.protection.outlook.com (2a01:111:e400:7e08::299) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Thu, 14 Jan 2021 06:36:47 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:F9FDCDBE94EE9C4197A7EA49C1B57BAEBFF4EAE85EB57C86C39143D393AA1FF5; UpperCasedChecksum:C8FD768F8130630555885A08DC9D4C96A18D64B07FAE5085D076A598EE5389B6; SizeAsReceived:7953; Count:46 Received: from AM0PR0602MB3410.eurprd06.prod.outlook.com ([fe80::60c8:86c2:bdaa:f0d2]) by AM0PR0602MB3410.eurprd06.prod.outlook.com ([fe80::60c8:86c2:bdaa:f0d2%3]) with mapi id 15.20.3763.010; Thu, 14 Jan 2021 06:36:47 +0000 Subject: Re: [PATCH] Fix building gdb with gcc-4.x To: Simon Marchi , "gdb-patches@sourceware.org" , Luis Machado References: <13ad5646-78f6-27dc-2e26-f250bb4b8c52@polymtl.ca> From: Bernd Edlinger Message-ID: Date: Thu, 14 Jan 2021 07:36:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <13ad5646-78f6-27dc-2e26-f250bb4b8c52@polymtl.ca> Content-Type: multipart/mixed; boundary="------------8B5F6846B15A908AF2570082" Content-Language: en-US X-TMN: [Ym3GoXqz15hbNL9CfSnRsKZp3M0PT8V2] X-ClientProxiedBy: AM0PR02CA0136.eurprd02.prod.outlook.com (2603:10a6:20b:28c::33) To AM0PR0602MB3410.eurprd06.prod.outlook.com (2603:10a6:208:21::24) X-Microsoft-Original-Message-ID: <3b360397-f386-c3b2-5052-ef247e58fbd7@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (88.68.3.2) by AM0PR02CA0136.eurprd02.prod.outlook.com (2603:10a6:20b:28c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.11 via Frontend Transport; Thu, 14 Jan 2021 06:36:46 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 607bedda-9c24-42b4-2ab1-08d8b856c477 X-MS-TrafficTypeDiagnostic: AM5EUR03HT064: X-MS-Exchange-MinimumUrlDomainAge: sourceware.org#6996 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G3PD3Ve9C+E6pmKcdrp75uNMFaS9LhL3V9iYxwpPm5kkNPZKcyyLm6TwOPGYbKoS3gWpQYBUXy2U+lSNtYmSu0OgXeg7Fqv2ATidG+YId4YuAZbWHDUFoM9gBYOhPGahxqUkycsmxSHJHcX9gtD9i7uxd6p0vu3gDwpqnA7GuRVGGS4Sqbx2K8h5kFEzY8r2SZg1Zo+RlFD6ZZ2whGf8sVUC6n9qyf94cL2XoC5pNOy89h5+6j44PtrqalXnzXq6gWquUnfXuoBRyRLbEwg6CYBvUM9QzHWNYyvzh/8SQZI= X-MS-Exchange-AntiSpam-MessageData: ZzI0NPpnXh+NmcLKr2A+9YrIJTSmUuWuA0WWAf0kcbbzExd6VmdTyMma+21weBAbe6cDL8fXhUcpOX27YGy0UYwAVesvzA2fkzQ5n6+m7Duy06T5txLiVmVev8iqeu1G7OL4NPWvEB2eFfGngmrugw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2021 06:36:47.5357 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: 607bedda-9c24-42b4-2ab1-08d8b856c477 X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5EUR03HT064 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" --------------8B5F6846B15A908AF2570082 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 1/4/21 10:30 PM, Simon Marchi wrote: > On 2021-01-04 3:57 p.m., Bernd Edlinger wrote: >> Hi, >> >> with Luis' commit of today the trunk is no longer able to >> be compiled with gcc-4.x. >> >> The problem is std::is_trivially_default_constructible is >> not defined before gcc-5 although the compiler supports C++11 >> >> I am not sure about what's the best approach for conditionally >> enabling the code, especially for compilers other than g++. >> >> >> This fixes the build for me. >> Is it OK for trunk? >> >> >> Thanks >> Bernd. >> > > We have other instances of this, I'd suggest inspiring yourself from: > > https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gdb/unittests/enum-flags-selftests.c;h=e3b6cf81d07f1eaefec72bce131d1c75ce00ef82;hb=HEAD#l66 > > These defines are defined here: > > https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gdbsupport/traits.h;h=f545edbb0d93e95f65e954fbf54cbc8843e5239a;hb=HEAD#l28 > > As you see, we already have a HAVE_IS_TRIVIALLY_CONSTRUCTIBLE, we could > use it. The code in trad-frame.c could be changed to use > std::is_trivially_constructible instead of > std::is_trivially_default_constructible, I believe it's the same when > passing no Args... to is_trivially_constructible. See "Possible > implementation" in: > > https://en.cppreference.com/w/cpp/types/is_default_constructible > > Simon > Okay, good point. I updated the patch following your suggestion. Is the updated patch OK? Thanks Bernd. --------------8B5F6846B15A908AF2570082 Content-Type: text/x-patch; name="0001-Fix-building-gdb-with-gcc-4.x.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-building-gdb-with-gcc-4.x.patch" RnJvbSA1ODhlN2E1NzA1NmU4YWFiZGQ2OTA2OTkzZGQzZDI3MzU0Y2M3MGZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuZCBFZGxpbmdlciA8YmVybmQuZWRsaW5nZXJAaG90bWFp bC5kZT4KRGF0ZTogTW9uLCA0IEphbiAyMDIxIDIxOjQwOjQxICswMTAwClN1YmplY3Q6IFtQQVRD SF0gRml4IGJ1aWxkaW5nIGdkYiB3aXRoIGdjYy00LngKTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVu dC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rp bmc6IDhiaXQKClNpbmNlIGlzX3RyaXZpYWxseV9kZWZhdWx0X2NvbnN0cnVjdGlibGUgd2FzIG5v dCBpbXBsZW1lbnRlZCBiZWZvcmUgZ2NjLTUKaXQgY2Fubm90IGJlIHVzZWQgd2l0aCBnY2MtNC54 LgoKLi4vLi4vYmludXRpbHMtZ2RiL2dkYi90cmFkLWZyYW1lLmM6IEluIGZ1bmN0aW9uIOKAmHRy YWRfZnJhbWVfc2F2ZWRfcmVnKiB0cmFkX2ZyYW1lX2FsbG9jX3NhdmVkX3JlZ3MoZ2RiYXJjaCop 4oCZOgouLi8uLi9iaW51dGlscy1nZGIvZ2RiL3RyYWQtZnJhbWUuYzo2NDoyMjogZXJyb3I6IOKA mGlzX3RyaXZpYWxseV9kZWZhdWx0X2NvbnN0cnVjdGlibGXigJkgaXMgbm90IGEgbWVtYmVyIG9m IOKAmHN0ZOKAmQogICBnZGJfc3RhdGljX2Fzc2VydCAoc3RkOjppc190cml2aWFsbHlfZGVmYXVs dF9jb25zdHJ1Y3RpYmxlPHRyYWRfZnJhbWVfc2F2ZWRfcmVnPjo6dmFsdWUpOwoKRml4IHRoZSBi dWlsZCBieSB1c2luZyBjb25kaXRpb25hbCBjb21waWxhdGlvbiBhcm91bmQgdGhhdCBsaW5lLgpV c2UgdGhlIGVxdWl2YWxlbnQgaXNfdHJpdmlhbGx5X2NvbnN0cnVjdGlibGU8VD4gaW5zdGVhZCwg c2luY2UKd2UgYWxyZWFkeSBoYXZlIEhBVkVfSVNfVFJJVklBTExZX0NPTlNUUlVDVElCTEUgZm9y IHRoYXQgcHVycG9zZS4KCkZpeGVzOiAwOThjYWVmNDg1YSAoIlJlZmFjdG9yIHN0cnVjdCB0cmFk X2ZyYW1lX3NhdmVkX3JlZ3MiKQoKZ2RiOgoyMDIxLTAxLTE0ICBCZXJuZCBFZGxpbmdlciAgPGJl cm5kLmVkbGluZ2VyQGhvdG1haWwuZGU+CgoJKiB0cmFkLWZyYW1lLmMgKHRyYWRfZnJhbWVfYWxs b2Nfc2F2ZWRfcmVncyk6IEF2b2lkIGNvbXBpbGUtZXJyb3IKCWJlY2F1c2UgaXNfdHJpdmlhbGx5 X2RlZmF1bHRfY29uc3RydWN0aWJsZSB3YXMgZmlyc3QgaW1wbGVtZW50ZWQgd2l0aAoJZ2NjLTUu Ci0tLQogZ2RiL3RyYWQtZnJhbWUuYyB8IDUgKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9nZGIvdHJhZC1mcmFtZS5jIGIv Z2RiL3RyYWQtZnJhbWUuYwppbmRleCAxNzM3NWU4Li4zMjg0YzQ1IDEwMDY0NAotLS0gYS9nZGIv dHJhZC1mcmFtZS5jCisrKyBiL2dkYi90cmFkLWZyYW1lLmMKQEAgLTI1LDYgKzI1LDcgQEAKICNp bmNsdWRlICJ0YXJnZXQuaCIKICNpbmNsdWRlICJ2YWx1ZS5oIgogI2luY2x1ZGUgImdkYmFyY2gu aCIKKyNpbmNsdWRlICJnZGJzdXBwb3J0L3RyYWl0cy5oIgogCiBzdHJ1Y3QgdHJhZF9mcmFtZV9j YWNoZQogewpAQCAtNjAsNyArNjEsOSBAQCBzdHJ1Y3QgdHJhZF9mcmFtZV9jYWNoZSAqCiB0cmFk X2ZyYW1lX3NhdmVkX3JlZyAqCiB0cmFkX2ZyYW1lX2FsbG9jX3NhdmVkX3JlZ3MgKHN0cnVjdCBn ZGJhcmNoICpnZGJhcmNoKQogewotICBnZGJfc3RhdGljX2Fzc2VydCAoc3RkOjppc190cml2aWFs bHlfZGVmYXVsdF9jb25zdHJ1Y3RpYmxlPHRyYWRfZnJhbWVfc2F2ZWRfcmVnPjo6dmFsdWUpOwor I2lmZGVmIEhBVkVfSVNfVFJJVklBTExZX0NPTlNUUlVDVElCTEUKKyAgZ2RiX3N0YXRpY19hc3Nl cnQgKHN0ZDo6aXNfdHJpdmlhbGx5X2NvbnN0cnVjdGlibGU8dHJhZF9mcmFtZV9zYXZlZF9yZWc+ Ojp2YWx1ZSk7CisjZW5kaWYKIAogICBpbnQgbnVtcmVncyA9IGdkYmFyY2hfbnVtX2Nvb2tlZF9y ZWdzIChnZGJhcmNoKTsKICAgdHJhZF9mcmFtZV9zYXZlZF9yZWcgKnRoaXNfc2F2ZWRfcmVncwot LSAKMS45LjEKCg== --------------8B5F6846B15A908AF2570082--