From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CjXRDhbb7F9SEgAAWB0awg (envelope-from ) for ; Wed, 30 Dec 2020 14:55:02 -0500 Received: by simark.ca (Postfix, from userid 112) id 2F0CB1F0AA; Wed, 30 Dec 2020 14:55:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=FORGED_MUA_MOZILLA, FREEMAIL_FROM,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B78F41E965 for ; Wed, 30 Dec 2020 14:55:01 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B6073858038; Wed, 30 Dec 2020 19:55:01 +0000 (GMT) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-oln040092065043.outbound.protection.outlook.com [40.92.65.43]) by sourceware.org (Postfix) with ESMTPS id 24F073858038 for ; Wed, 30 Dec 2020 19:54:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 24F073858038 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n5oYZvsxtio1q3Pa8JY/cGhLLWp3p6yg2+Sg5eLZyWMyJjnUa9cqo3nJvkrPrTSs3lAPARwzPLnQsx0gkPF9dNTlbAaSZg3fsWjYpjy9rFara7DnEm2D1lxScssonVS+wmLDEkGTCNtEjz/tsYAupQb5t6Dgsy1Hbsr0PCMT+vjNeU0Zjbz/UqAbuQW/2kycxBMoNoPjh3ZPKYaTVseznUSTXSN/APGjJz3yPeJQY7dIoc7H2yNcIwnmVSZkFEIYxb9MSVPgFQUMctuH8LXBIMip5q0idwRluos+GjmLWx78Fjx0oUmCm9VGXfdTAxgA7dkH0esrpWOk6LbWX3kQKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=srzsWadL5FmkJK1XXeTBre5b2mNKO1QPxuFLzSiGh/g=; b=VOwaHuu2LbVN/gNkpTNGZe39HplBKqW3Z/1oakaBm68+sbfopXOo10kYiSJLQnTFQpT/j9Ux7WDCl5x/WxfWyODX8J0Z1ct9WZYlHuLGYYHAqvW9o/WL81u+IUrUfIEkYc/Ea+XIhUhFZn0UDDSKuckEwsuAunxouf3aVHHcTBHRnxj9u42+35NmbESQWEfZzw8leYObqquqO6cHOy5veeBFSxajcCX0wA/49uIOVnnCYNzy6yf06dW2g8dZfaht+oS8zmzlJaCbOFmD/CU/0aLjtgFfqK6vBxPkwCZdM+S/yfquG/ttIn34MGZRn+R5Os4aFSCDC0iniF1T2CILbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VE1EUR01FT020.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e19::4f) by VE1EUR01HT152.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e19::335) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 30 Dec 2020 19:54:55 +0000 Received: from AM0PR0602MB3410.eurprd06.prod.outlook.com (2a01:111:e400:7e19::46) by VE1EUR01FT020.mail.protection.outlook.com (2a01:111:e400:7e19::234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.20 via Frontend Transport; Wed, 30 Dec 2020 19:54:55 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:984D382E00ADD14AF93145A928930D4D6905229D55453975D33681D654B44610; UpperCasedChecksum:586C2359DBB16A8519D02D7FA8E3016EA2A6E0A4A7EEE33A76C430CE18D868FB; SizeAsReceived:8124; Count:46 Received: from AM0PR0602MB3410.eurprd06.prod.outlook.com ([fe80::60c8:86c2:bdaa:f0d2]) by AM0PR0602MB3410.eurprd06.prod.outlook.com ([fe80::60c8:86c2:bdaa:f0d2%3]) with mapi id 15.20.3721.019; Wed, 30 Dec 2020 19:54:55 +0000 Subject: Re: [PATCH v5] Fix range end handling of inlined subroutines To: Simon Marchi , "gdb-patches@sourceware.org" , Andrew Burgess , Joel Brobecker , Tom Tromey , Pedro Alves , Eli Zaretskii References: From: Bernd Edlinger Message-ID: Date: Wed, 30 Dec 2020 20:54:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: Content-Type: multipart/mixed; boundary="------------CC98B1196D4781ED3B9E3F9E" Content-Language: en-US X-TMN: [Vo+PsB97cDvusHZzO2qagBix8PckIsc7] X-ClientProxiedBy: AM0PR02CA0162.eurprd02.prod.outlook.com (2603:10a6:20b:28d::29) To AM0PR0602MB3410.eurprd06.prod.outlook.com (2603:10a6:208:21::24) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (88.68.3.2) by AM0PR02CA0162.eurprd02.prod.outlook.com (2603:10a6:20b:28d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27 via Frontend Transport; Wed, 30 Dec 2020 19:54:54 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 3e367108-7e33-4c34-ce89-08d8acfcc770 X-MS-TrafficTypeDiagnostic: VE1EUR01HT152: X-MS-Exchange-MinimumUrlDomainAge: sourceware.org#6981 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 75pPCuJeI/bzfKE3W/Z/53J3tIYl5DMbZt0ad3N/bLyJblSoIQBQcf6ZBCGXUVG92cXF2MNG4ebPcULBTocWG2sZr2qyjsqhGw6EYAF1oR4AR3b71jcE60qOt/Usn9VAYedk8UAmtLNdUKpAW25tgXfeYxq/i6/eqkM2YL2AlhNPrrGnztlVwKF4BDn/fESD+VMuhZyCrttJagqv6cwH8XiK9so7OC6XbLlef3kdm/DmtDVcdHDrJKp7wGiPWlpr061YVOSbFNGv2laVc6UkW7etIQ+E5IrAqTomWYUojxs= X-MS-Exchange-AntiSpam-MessageData: FC6CiPLaLaGjQTKTq547Q6CXMkQcoJIh79St62virGXhJTbz6Pl2Hm1CI79OXI2X885AJn8Pd1kKZksrkdp8s9mrZFXSF2cA3zmuwKDVrghohdHm0TTl1Z8Kkoh+oTGQBGKNV0QLuHe5Idnk4hYpNQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2020 19:54:54.9890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: 3e367108-7e33-4c34-ce89-08d8acfcc770 X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT020.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR01HT152 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" --------------CC98B1196D4781ED3B9E3F9E Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 12/30/20 6:17 PM, Simon Marchi wrote: > > > On 2020-12-29 4:10 a.m., Bernd Edlinger wrote: >> Hi, >> >> >> this is a minor update to the previous version here: >> https://sourceware.org/pipermail/gdb-patches/2020-November/173614.html >> >> The only real change is here: >> >> --- a/gdb/buildsym.c >> +++ b/gdb/buildsym.c >> @@ -429,7 +429,10 @@ struct block * >> { >> m_inline_end_vector.push_back (end_inclusive + 1); >> if (end_inclusive + 1 == start) >> - end_inclusive = start; >> + { >> + end_inclusive = start; >> + m_pending_addrmap_interesting = true; >> + } >> } >> >> if (m_pending_addrmap == nullptr) >> >> >> The test case with an empty inline that triggered this >> is from PR 25987. >> >> It is a real-world code that triggers both an empty inline >> function and the wrong call-stack immediately after >> the inline. So I added this test case as well. >> >> So this fixes PR 25987 as well as a lot of issues with >> debugging inlined functions in general. >> >> >> Thanks >> Bernd. >> > > I'll look at this patch to try to get the ball rolling, even though I do > not feel qualified at all. > > One quick thing, in this change here: > > --- a/gdb/testsuite/gdb.cp/step-and-next-inline.exp > +++ b/gdb/testsuite/gdb.cp/step-and-next-inline.exp > @@ -29,16 +29,9 @@ if {[test_compiler_info gcc*] && ![supports_statement_frontiers] } { > proc do_test { use_header } { > global srcfile testfile > > - if { $use_header } { > - # This test will not pass due to poor debug information > - # generated by GCC (at least upto 10.x). See > - # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94474 > - return > - } > - > set options {c++ debug nowarnings optimize=-O2} > if { [supports_statement_frontiers] } { > - lappend options -gstatement-frontiers > + lappend options additional_flags=-gstatement-frontiers > } > > You appear to fix a bug in the test where we were missing "additional_flags=", > causing -gstatement-frontiers not to be passed to the compiler. I think that > fix could be pushed separately immediately. > Yes. I can do that. I quickly extracted that one line change as follows. Is it ok to push? Thanks Bernd. --------------CC98B1196D4781ED3B9E3F9E Content-Type: text/x-patch; name="0001-Fix-passing-debug-options-for-gcc.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-passing-debug-options-for-gcc.patch" RnJvbSAxNWJhMWY4MDVlNjAyNjRhNTg0YjMyMWEwZWFiNTZmMzIzM2U4NTRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuZCBFZGxpbmdlciA8YmVybmQuZWRsaW5nZXJAaG90bWFp bC5kZT4KRGF0ZTogVHVlLCAzIE5vdiAyMDIwIDE4OjQxOjQzICswMTAwClN1YmplY3Q6IFtQQVRD SF0gRml4IHBhc3NpbmcgZGVidWcgb3B0aW9ucyBmb3IgZ2NjCgpGaXggYSBidWcgaW4gdGhlIHRl c3Qgd2hlcmUgd2Ugd2VyZSBtaXNzaW5nICJhZGRpdGlvbmFsX2ZsYWdzPSIsCmNhdXNpbmcgLWdz dGF0ZW1lbnQtZnJvbnRpZXJzIG5vdCB0byBiZSBwYXNzZWQgdG8gdGhlIGNvbXBpbGVyLgoKVGhl IGlzc3VlIHdhcyBpbnRyb2R1Y2VkIGluCmViMjQ2NDhjNDUzYzI4ZjI4OThmYjU5OTMxMWJhMDA0 Mzk0YThiNDEgKCJGaXggZ2RiLmNwL3N0ZXAtYW5kLW5leHQtaW5saW5lLmV4cCB3aXRoIENsYW5n IikuCgpnZGIvdGVzdHN1aXRlOgoyMDIwLTEyLTMwICBCZXJuZCBFZGxpbmdlciAgPGJlcm5kLmVk bGluZ2VyQGhvdG1haWwuZGU+CgoJKiBnZGIuY3Avc3RlcC1hbmQtbmV4dC1pbmxpbmUuZXhwOiBG aXggdGVzdCBjYXNlLgotLS0KIGdkYi90ZXN0c3VpdGUvZ2RiLmNwL3N0ZXAtYW5kLW5leHQtaW5s aW5lLmV4cCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlv bigtKQoKZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLmNwL3N0ZXAtYW5kLW5leHQtaW5s aW5lLmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLmNwL3N0ZXAtYW5kLW5leHQtaW5saW5lLmV4cApp bmRleCA0M2E3MTAxLi4wOGE0Yjg4IDEwMDY0NAotLS0gYS9nZGIvdGVzdHN1aXRlL2dkYi5jcC9z dGVwLWFuZC1uZXh0LWlubGluZS5leHAKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIuY3Avc3RlcC1h bmQtbmV4dC1pbmxpbmUuZXhwCkBAIC0zOCw3ICszOCw3IEBAIHByb2MgZG9fdGVzdCB7IHVzZV9o ZWFkZXIgfSB7CiAKICAgICBzZXQgb3B0aW9ucyB7YysrIGRlYnVnIG5vd2FybmluZ3Mgb3B0aW1p emU9LU8yfQogICAgIGlmIHsgW3N1cHBvcnRzX3N0YXRlbWVudF9mcm9udGllcnNdIH0gewotCWxh cHBlbmQgb3B0aW9ucyAtZ3N0YXRlbWVudC1mcm9udGllcnMKKwlsYXBwZW5kIG9wdGlvbnMgYWRk aXRpb25hbF9mbGFncz0tZ3N0YXRlbWVudC1mcm9udGllcnMKICAgICB9CiAgICAgaWYgeyAkdXNl X2hlYWRlciB9IHsKIAlsYXBwZW5kIG9wdGlvbnMgYWRkaXRpb25hbF9mbGFncz0tRFVTRV9ORVhU X0lOTElORV9ICi0tIAoxLjkuMQoK --------------CC98B1196D4781ED3B9E3F9E--