From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15028 invoked by alias); 17 Sep 2012 19:36:59 -0000 Received: (qmail 15019 invoked by uid 22791); 17 Sep 2012 19:36:59 -0000 X-SWARE-Spam-Status: No, hits=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from server-nat-6.cs.umd.edu (HELO bacon.cs.umd.edu) (128.8.127.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Sep 2012 19:36:46 +0000 Received: from [10.109.174.174] (129-2-129-155.wireless.umd.edu [129.2.129.155]) (Authenticated sender: khooyp) by bacon.cs.umd.edu (Postfix) with ESMTPSA id 01C40B40D15; Mon, 17 Sep 2012 15:36:43 -0400 (EDT) From: Khoo Yit Phang Content-Type: multipart/mixed; boundary=Apple-Mail-15-236210150 Subject: [PATCH] Warn about data-directory when failing to import Python "gdb" module Date: Mon, 17 Sep 2012 19:36:00 -0000 Message-Id: Cc: Khoo Yit Phang To: GDB Patches Mime-Version: 1.0 (Apple Message framework v1084) X-CSD-MailScanner-ID: 01C40B40D15.ABE4E X-CSD-MailScanner: Found to be clean X-CSD-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-50, required 5, autolearn=not spam, ALL_TRUSTED -50.00) X-CSD-MailScanner-From: khooyp@cs.umd.edu X-CSD-MailScanner-Watermark: 1348515403.09869@omt49exhqD1bph7WxzYOZQ Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00321.txt.bz2 --Apple-Mail-15-236210150 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Content-length: 291 Hi, I'd like to add a warning when failing to import the Python "gdb" module to= check that data-directory is set correctly, to address the confusion arisi= ng from the incompatibility between the old "gdb" module and the one I rece= ntly checked in. Thank you, Yit September 17, 2012 --Apple-Mail-15-236210150 Content-Disposition: attachment; filename=warn-gdb-python-compat.txt Content-Type: text/plain; name="warn-gdb-python-compat.txt" Content-Transfer-Encoding: quoted-printable Content-length: 666 gdb/ChangeLog 2012-09-17 Khoo Yit Phang * gdb/python.c (finish_python_initialization): Augment the warning when importing "gdb" fails, to check that data-directory is set correctly. diff --git a/gdb/python/python.c b/gdb/python/python.c --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -1484,6 +1484,7 @@ gdbpy_print_stack (); warning (_("Could not load the Python gdb module from `%s'."), gdb_pythondir); + warning (_("Please make sure that data-directory is set correctly.")= ); warning (_("Limited Python support is available from the _gdb module= .")); do_cleanups (cleanup); return; --Apple-Mail-15-236210150--