From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22189 invoked by alias); 19 Nov 2008 12:45:32 -0000 Received: (qmail 22155 invoked by uid 22791); 19 Nov 2008 12:45:30 -0000 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Nov 2008 12:44:43 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id F19EF290007; Wed, 19 Nov 2008 13:44:40 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9NC8QS4FOzMl; Wed, 19 Nov 2008 13:44:40 +0100 (CET) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.0.139]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 6E413290002; Wed, 19 Nov 2008 13:44:40 +0100 (CET) Cc: gdb-patches@sourceware.org Message-Id: From: Tristan Gingold To: Stan Shebs In-Reply-To: <49221AE9.5050600@codesourcery.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Subject: Re: [RFA] Darwin/x86 port (v4 - part 1/4: machoread.c) Date: Wed, 19 Nov 2008 21:21:00 -0000 References: <7B1402FF-6CAB-4C6A-AAB5-81E062080FB5@adacore.com> <49221AE9.5050600@codesourcery.com> X-Mailer: Apple Mail (2.929.2) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00499.txt.bz2 On Nov 18, 2008, at 2:31 AM, Stan Shebs wrote: > Tristan Gingold wrote: >> >> typedef struct oso_el >> { > Something about what this struct is for, please? Comments added. > And while you and I know that "oso" is short for "other source" and > refers to the collection of debug info from .o files, it's new to > everybody else. :-) I thought it means "object source". Anyway, I added comments. > (Getting function bounds set correctly is going to be loads of fun, > ahem, I had to look at Apple's hairy code for this several months > ago...) Yes, there is work to do in this area! >> DEF_VEC_O(oso_el); >> static VEC(oso_el) *oso_vector; > The vector macros should follow the "space before paren" just as > everybody else does, although I note that the doc in vec.h confuses > things by not following the general rule. I added a space. >> #define DSYM_SUFFIX ".dSYM/Contents/Resources/DWARF/" > Again, need to say what dSYM files are, and maybe mention that the > yucky wired-in string is guaranteed to have that form (or at least > that we're doing the same thing as Apple's GDB). Done. > In comments, we should prefer to say "Mach-O" rather than "macho" or > "mach-o", since that is the proper name of the file format. I think I fixed all. 'macho' is still used in functions name. > With these doc and formatting changes, machoread.c is OK to go into > the trunk. Thanks. > (Ideally we will migrate this file to the list of generic files, but > we will need to check that it compiles on other hosts first.) Tristan.