Hi Joel, Thanks for the second review. > You don't need the func_end variable, here, as you can just pass NULL instead. Ok, I've updated that. > That being said, I'm afraid that you won't be > able to commit this patch until the sim > counterpart is approved. This is due to the > two dependencies (one in configure.tgt, and one > in lm32-tdep.c) that you have. Have you > heard from the sim maintainers? I haven't heard anything yet. Cheers, Jon ChangeLog gdb 2009-05-08 Jon Beniston * MAINTAINERS: Add lm32 target. * Makefile.in: Add lm32 dependencies. * NEWS: Indicate lm32 is a new target. * configure.tgt: Add lm32 targets. * lm32-tdep.c: New file. gdb/testsuite 2009-05-08 Jon Beniston * gdb.asm/asm-source.exp: Add lm32 target.