From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80357 invoked by alias); 21 Oct 2017 10:48:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61667 invoked by uid 89); 21 Oct 2017 10:47:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=facts, examination X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 21 Oct 2017 10:47:36 +0000 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2017 03:47:30 -0700 X-ExtLoop1: 1 Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga006.fm.intel.com with ESMTP; 21 Oct 2017 03:47:29 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by IRSMSX106.ger.corp.intel.com ([169.254.8.36]) with mapi id 14.03.0319.002; Sat, 21 Oct 2017 11:47:28 +0100 From: "Tedeschi, Walfred" To: Pedro Alves , Simon Marchi , Simon Marchi CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH V4] symlookup: improves symbol lookup when a file is specified. Date: Sat, 21 Oct 2017 10:48:00 -0000 Message-ID: References: <1508317280-31265-1-git-send-email-walfred.tedeschi@intel.com> <327caaf3429595c07a29d455ea3ed6a0@polymtl.ca> In-Reply-To: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGFjNTIzMzktYTgxMi00YzNmLTgzYmQtNjZhZDNhMzA5ZDU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIzNnpvSTd2dzhTMmtcL0JkMW9NejNvK2dINjBWXC9JRWJnTm0zZmtFQTFxSzltcVJDT1pGZzhqb0Zuc04rSFdhWDEifQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00692.txt.bz2 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBQZWRybyBB bHZlcyBbbWFpbHRvOnBhbHZlc0ByZWRoYXQuY29tXQ0KPiBTZW50OiBGcmlk YXksIE9jdG9iZXIgMjAsIDIwMTcgNToyOSBQTQ0KPiBUbzogU2ltb24gTWFy Y2hpIDxzaW1vbi5tYXJjaGlAZXJpY3Nzb24uY29tPjsgVGVkZXNjaGksIFdh bGZyZWQNCj4gPHdhbGZyZWQudGVkZXNjaGlAaW50ZWwuY29tPjsgU2ltb24g TWFyY2hpIDxzaW1vbi5tYXJjaGlAcG9seW10bC5jYT4NCj4gQ2M6IGdkYi1w YXRjaGVzQHNvdXJjZXdhcmUub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0gg VjRdIHN5bWxvb2t1cDogaW1wcm92ZXMgc3ltYm9sIGxvb2t1cCB3aGVuIGEg ZmlsZSBpcw0KPiBzcGVjaWZpZWQuDQo+IA0KPiBPbiAxMC8yMC8yMDE3IDAz OjI4IFBNLCBTaW1vbiBNYXJjaGkgd3JvdGU6DQo+ID4gT24gMjAxNy0xMC0y MCAwMzo0NSBBTSwgVGVkZXNjaGksIFdhbGZyZWQgd3JvdGU6DQo+ID4+IEhp IFNpbW9uLA0KPiA+Pg0KPiA+PiBUaGFua3MgZm9yIHlvdXIgcmV2aWV3IQ0K PiA+PiBGb3IgYWxsIHRoZSBjb21tZW50IGFib3ZlIEkgYWdyZWUsIFRoYW5r cyBhZ2FpbiENCj4gPj4NCj4gPj4gRm9yIHRoZSBvbmUgYmVsb3cgdGhlcmUg YXJlIGRpZmZlcmVudCBwb2ludCBvZiB2aWV3cy4NCj4gPj4gSG93IEkgc2Vl IGl0OiBWZXJ5IGZldyBzYW5lIHBlb3BsZSB3aWxsIGFkZCBhIHN5bWJvbHMg aW4gYSBzaGFyZWQNCj4gPj4gbGlicmFyeSB0aGF0IHdpbGwgY29sbGlkZSBs aWtlIHRoZSBjYXNlIHdlIHByZXNlbnRlZCBoZXJlLiAgSWYgb25lDQo+ID4+ IGRvZXMgc28gaG93IGNhbiB0aGUgZGVidWdnZXIgaGVscD8NCj4gPg0KPiA+ IEkgdGhpbmsgb25lIHVzdWFsIHVzZSBjYXNlIGlzIHBsdWdpbnMgaW1wbGVt ZW50ZWQgd2l0aCBzaGFyZWQgbGlicmFyeS4NCj4gPiBBbHRob3VnaCB0aGUg ZGF0YSBzeW1ib2xzIHdpbGwgY29tbW9ubHkgYmUgc3RhdGljLCBhbmQgdGhl IHBsdWdpbiB3aWxsDQo+ID4gb25seSBleHBvc2Ugc29tZSBmdW5jdGlvbiBz eW1ib2xzLg0KPiA+DQo+ID4+IFByb3ZpZGluZyB0aGUgc2FtZSB2YWx1ZSBh cyB0aGUgcnVudGltZSBvciBsaW5rZXIgZG9lcz8NCj4gPj4gVGhpcyBvbmUg dXNlciBhbHJlYWR5IGtub3dzLg0KPiA+PiBPciBwcm92aWRpbmcgd2hhdCB0 aGUgZGVidWcgaW5mb3JtYXRpb24gcHJvdmlkZXMgYXMgdmFsdWUgY3JlYXRl ZCBieSB0aGUNCj4gbGlicmFyeSBpdHNlbGYuDQo+ID4+IEluIGZpbmFsIGVu ZCBib3RoIGFyZSByaWdodC4gOnwNCj4gPj4NCj4gPj4gQnV0IHdoZW4gc3Bl Y2lmeWluZyB0aGUgc2NvcGUgaWYgdXNlciBpcyBwcm92aWRlZCB0aGUgdmFs dWUgb2YgdGhlDQo+ID4+IGRlYnVnIGluZm8gaXQgc2hvdWxkIGJlIGVhc2ll ciB0byBzcG90IHRoYXQgdGhlcmUgaXMgc29tZXRoaW5nIHdlaXJkIGdvaW5n IG9uDQo+IGluIHRoZSBjb2RlLg0KPiA+DQo+ID4gSSB0aGluayB3aGF0IHlv dSBqdXN0IHNhaWQgc3VtbWFyaXplcyB0aGUgcHJvYmxlbSB3ZWxsIGFuZCBJ IHRoaW5rIGl0IG1ha2VzDQo+IHNlbnNlLg0KPiA+IEkganVzdCBkb24ndCB0 aGluayBJIGhhdmUgZW5vdWdoIGV4cGVyaWVuY2UgYWJvdXQgc3ltYm9sIGhh bmRsaW5nIHRvDQo+ID4gdW5kZXJzdGFuZCB0aGUgc2l0dWF0aW9uIGZ1bGx5 LiAgQ291bGQgYW5vdGhlciBtYWludGFpbmVyIHdpdGggbW9yZQ0KPiA+IGV4 cGVyaWVuY2UgYWJvdXQgc3ltYm9scyBnaXZlIHRoZSBmaW5hbCBvaz8NCj4g DQo+IEkgZGlzYWdyZWUuICBIYXZpbmcNCj4gIChnZGIpIGZyYW1lDQo+ICAj MCAweDAwMDAwMDAwMDA0MDA3M2IgaW4gZnVuY3Rpb24gKCkgYXQgc291cmNl LmM6MjINCj4gIChnZGIpIHByaW50IGZvbw0KPiBhbmQ6DQo+ICAoZ2RiKSBw cmludCAnc291cmNlLmMnOmZvbw0KPiANCj4gc2hvdyBkaWZmZXJlbnQgdmFs dWVzIHdoZW4geW91J3JlIHN0b3BwZWQgaW4gYSBmdW5jdGlvbiBpbiB0aGUg c291cmNlLmMgZmlsZQ0KPiB3b3VsZCBsb29rIGluY29uc2lzdGVudCB0byBt ZS4NCj4gDQo+IEFjdHVhbGx5LCB0aGUgcGF0Y2ggaW50cm9kdWNlcyB3aGF0 IGxvb2tzIGxpa2UgYSByZWxhdGVkIGNsZWFyIHJlZ3Jlc3Npb24gdG8gbWUu DQo+IFdpdGggdGhlIHByaW50LWZpbGUtdmFyLmV4cCB0ZXN0IHByb2dyYW0s IHRyeSBzdGVwcGluZyBpbnRvIGdldF92ZXJzaW9uXzIsIGFuZA0KPiBwcmlu dGluZyB0aGUgdGhpc192ZXJzaW9uX2lkIGdsb2JhbC4gIEFuZCB0aGVuIHR5 cGUgZmluaXNoLiAgVmlzOg0KPiANCj4gIChnZGIpIHMNCj4gIGdldF92ZXJz aW9uXzIgKCkgYXQgZ2RiLmJhc2UvcHJpbnQtZmlsZS12YXItbGliMi5jOjIy DQo+ICAyMiAgICAgICAgcmV0dXJuIHRoaXNfdmVyc2lvbl9pZDsNCj4gIChn ZGIpIHAgdGhpc192ZXJzaW9uX2lkDQo+ICAkMSA9IDIwMw0KPiAgKGdkYikg ZmluaXNoDQo+ICBSdW4gdGlsbCBleGl0IGZyb20gIzAgIGdldF92ZXJzaW9u XzIgKCkgYXQgZ2RiLmJhc2UvcHJpbnQtZmlsZS12YXItbGliMi5jOjIyDQo+ IDB4MDAwMDAwMDAwMDQwMDczYiBpbiBtYWluICgpIGF0IGdkYi5iYXNlL3By aW50LWZpbGUtdmFyLW1haW4uYzoyNA0KPiAgMjQgICAgICAgIGludCB2MiA9 IGdldF92ZXJzaW9uXzIgKCk7DQo+ICBWYWx1ZSByZXR1cm5lZCBpcyAkMiA9 IDEwNA0KPiAgKGdkYikNCj4gDQo+IEdEQiBzYXlzICIyMDMiLCB3aGlsZSB0 aGUgcHJvZ3JhbSByZXR1cm5zICIxMDQiLg0KPiBUaGF0IGxvb2tzIGxpa2Ug YSBidWcgdG8gbWUuICBJJ2QgZXhwZWN0IHRoZSBwcmludCB0byBzaG93IG1l IHRoZSBjdXJyZW50IHZhbHVlIG9mDQo+IHRoZSB2YXJpYWJsZSBpbiBzY29w ZS4NCj4gDQo+IEluIGN1cnJlbnQgbWFzdGVyICh3aXRob3V0IHRoZSBwYXRj aCksIHdlIGdldDoNCj4gDQo+ICAoZ2RiKSBzDQo+ICBnZXRfdmVyc2lvbl8y ICgpIGF0IGdkYi5iYXNlL3ByaW50LWZpbGUtdmFyLWxpYjIuYzoyMg0KPiAg MjIgICAgICAgIHJldHVybiB0aGlzX3ZlcnNpb25faWQ7DQo+ICAoZ2RiKSBw IHRoaXNfdmVyc2lvbl9pZA0KPiAgJDEgPSAxMDQNCj4gIChnZGIpIGZpbmlz aA0KPiAgUnVuIHRpbGwgZXhpdCBmcm9tICMwICBnZXRfdmVyc2lvbl8yICgp IGF0IGdkYi5iYXNlL3ByaW50LWZpbGUtdmFyLWxpYjIuYzoyMg0KPiAweDAw MDAwMDAwMDA0MDA3M2IgaW4gbWFpbiAoKSBhdCBnZGIuYmFzZS9wcmludC1m aWxlLXZhci1tYWluLmM6MjQNCj4gIDI0ICAgICAgICBpbnQgdjIgPSBnZXRf dmVyc2lvbl8yICgpOw0KPiAgVmFsdWUgcmV0dXJuZWQgaXMgJDIgPSAxMDQN Cg0KSGVsbG8gUGVkcm8sDQoNClRoYW5rcyBhIGxvdCBmb3IgcmV2aWV3aW5n IHRoYXQhDQpJIHdpbGwgYnJpbmcgbW9yZSBpbmZvcm1hdGlvbiByZWxhdGVk IHRvIHdoYXQgZGVidWcgaW5mb3JtYXRpb24gcHJvdmlkZSBhbmQgc28gb24u DQpUaGUgbGlua2VyIGlzIHRoZSBjYXVzZSBvZiB0aGlzIGRpc2Nvbm5lY3Rp b24uICBJbiBhIHByZXZpb3VzIHRlc3QgcGF0Y2ggSSBoYXZlIGFkZGVkIGEg c2V0L3Nob3cgdmFyaWFibGUgc3dpdGNoIGJldHdlZW4uDQpEbG9wZW4gYW5k IGxpbmtlciBiZWhhdmlvci4gIEkgYWxzbyBmb3VuZCB0aGF0IHdyb25nIGFu ZCBsb29raW5nIGF0IGl0IGFnYWluLiAgDQoNCkkgd2lsbCB0cnkgdG8gYnJp bmcgbW9yZSBmYWN0cyB3aXRoIHRoZSBkZWJ1ZyBpbmZvIGFuZCBtZW1vcnkg ZXhhbWluYXRpb24uDQoNCkluIGFueSBjYXNlIGFjdHVhbCBiZWhhdmlvciBv ZiBtYXN0ZXIgaXMgYWxzbyB3cm9uZyBmb3IgZGxvcGVuIGNhc2UhDQoNClRo YW5rcyBhbmQgcmVnYXJkcywNCi9GcmVkDQo+IA0KPiBUaGFua3MsDQo+IFBl ZHJvIEFsdmVzDQpJbnRlbCBEZXV0c2NobGFuZCBHbWJIClJlZ2lzdGVyZWQg QWRkcmVzczogQW0gQ2FtcGVvbiAxMC0xMiwgODU1NzkgTmV1YmliZXJnLCBH ZXJtYW55ClRlbDogKzQ5IDg5IDk5IDg4NTMtMCwgd3d3LmludGVsLmRlCk1h bmFnaW5nIERpcmVjdG9yczogQ2hyaXN0aW4gRWlzZW5zY2htaWQsIENocmlz dGlhbiBMYW1wcmVjaHRlcgpDaGFpcnBlcnNvbiBvZiB0aGUgU3VwZXJ2aXNv cnkgQm9hcmQ6IE5pY29sZSBMYXUKUmVnaXN0ZXJlZCBPZmZpY2U6IE11bmlj aApDb21tZXJjaWFsIFJlZ2lzdGVyOiBBbXRzZ2VyaWNodCBNdWVuY2hlbiBI UkIgMTg2OTI4Cg== >From gdb-patches-return-142886-listarch-gdb-patches=sources.redhat.com@sourceware.org Sat Oct 21 14:13:29 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 111780 invoked by alias); 21 Oct 2017 14:13:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 111760 invoked by uid 89); 21 Oct 2017 14:13:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:737 X-Spam-User: qpsmtpd, 2 recipients X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 21 Oct 2017 14:13:27 +0000 Received: from [10.0.0.11] (cable-192.222.251.162.electronicbox.net [192.222.251.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7E1971E4F3; Sat, 21 Oct 2017 10:13:25 -0400 (EDT) Subject: Re: Breakpoint commands in MI mode and "backtrace" To: Eli Zaretskii Cc: gdb@sourceware.org, gdb-patches@sourceware.org References: <8360bqt0im.fsf@gnu.org> <8a3d7153-7486-032f-aabc-6c3453f96459@simark.ca> <83shetsdg2.fsf@gnu.org> <83o9phs8zw.fsf@gnu.org> <83d15wsrvw.fsf@gnu.org> <83bmlgsqpm.fsf@gnu.org> <83vaj8c3fj.fsf@gnu.org> From: Simon Marchi Message-ID: Date: Sat, 21 Oct 2017 14:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <83vaj8c3fj.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00693.txt.bz2 Content-length: 691 On 2017-10-21 04:26 AM, Eli Zaretskii wrote: >> Cc: gdb@sourceware.org >> From: Simon Marchi >> Date: Mon, 9 Oct 2017 08:02:24 -0400 >> >> Anyhow, can you try this patch here? It changes the uiout manually instead of >> going through safe_execute_command. > > Since this worked for me, in GDB 8.0, can something similar be put in > the current master, so the next GDB release will have this bug fixed? > > Thanks. I'll look into it, but I'll try a slightly different patch. The one I sent previously sets and restores the interpreter at every executed command, which is inefficient. I'll try to set and restore only once at a higher level in the call stack. Simon