From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52147 invoked by alias); 16 Feb 2017 15:37:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52120 invoked by uid 89); 16 Feb 2017 15:37:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=stepped, trough, H*i:sk:65ae988, H*MI:sk:65ae988 X-HELO: mga07.intel.com Received: from mga07.intel.com (HELO mga07.intel.com) (134.134.136.100) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Feb 2017 15:36:59 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP; 16 Feb 2017 07:36:57 -0800 X-ExtLoop1: 1 Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga002.jf.intel.com with ESMTP; 16 Feb 2017 07:36:56 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.142]) by irsmsx105.ger.corp.intel.com ([169.254.7.38]) with mapi id 14.03.0248.002; Thu, 16 Feb 2017 15:36:56 +0000 From: "Tedeschi, Walfred" To: Pedro Alves , "qiyaoltc@gmail.com" , "brobecker@adacore.com" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH V7] amd64-mpx: initialize bnd register before performing inferior calls. Date: Thu, 16 Feb 2017 15:37:00 -0000 Message-ID: References: <1485875613-31975-1-git-send-email-walfred.tedeschi@intel.com> <53d42bb6-3b83-6213-4087-6d30e7d837de@redhat.com> <217a8c13-b7d0-7fe6-56b5-85ff53ce097a@intel.com> <88c7180f-8843-a148-425a-2adf56c6d0bf@redhat.com> <32693426-fbaf-8345-04c7-e2c329d6ec6e@intel.com> <65ae9889-ab18-7228-c612-d47ec728174f@redhat.com> In-Reply-To: <65ae9889-ab18-7228-c612-d47ec728174f@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00443.txt.bz2 DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBnZGItcGF0 Y2hlcy1vd25lckBzb3VyY2V3YXJlLm9yZyBbbWFpbHRvOmdkYi1wYXRjaGVz LW93bmVyQHNvdXJjZXdhcmUub3JnXSBPbiBCZWhhbGYgT2YgUGVkcm8gQWx2 ZXMNClNlbnQ6IFRodXJzZGF5LCBGZWJydWFyeSAxNiwgMjAxNyAyOjUyIFBN DQpUbzogVGVkZXNjaGksIFdhbGZyZWQgPHdhbGZyZWQudGVkZXNjaGlAaW50 ZWwuY29tPjsgcWl5YW9sdGNAZ21haWwuY29tOyBicm9iZWNrZXJAYWRhY29y ZS5jb20NCkNjOiBnZGItcGF0Y2hlc0Bzb3VyY2V3YXJlLm9yZw0KU3ViamVj dDogUmU6IFtQQVRDSCBWN10gYW1kNjQtbXB4OiBpbml0aWFsaXplIGJuZCBy ZWdpc3RlciBiZWZvcmUgcGVyZm9ybWluZyBpbmZlcmlvciBjYWxscy4NCg0K T24gMDIvMTYvMjAxNyAwMTo0OSBQTSwgVGVkZXNjaGksIFdhbGZyZWQgd3Jv dGU6DQoNCj4+IENvcnJlY3Q/DQo+IFllcy4NCj4gQnV0IGFjdHVhbCBiZWhh dmlvciBhdCA3IGhhcyBhbiBpc3N1ZSENCg0KNy4gaXM6DQoNCj4+PiA3LiBl eHBlY3RlZCAtIGNvbnRyb2wgc2hvdWxkIGJlIGJhY2sgdG8gMSwgaS5lLiBv biBzdG9wIG1vZGUuDQo+Pj4gNy4gYWN0dWFsIGJlaGF2aW9yIC0gYXBwbGlj YXRpb24gZmluaXNoZXMgd2l0aCB0aGUgc2lnbmFsDQoNCkJ1dCB0aGUgcmVz dCBvZiB5b3VyIGVtYWlsIGRvZXNuJ3QgdGFsayBhYm91dCB0aGlzIGF0IGFs bC4NCkknbSBjb25mdXNlZC4uLi4NCg0KRlJFRDoNCklzc3VlIGlzIHRoYXQg SSBmb3Jnb3QgdG8gc2F5IGluIGhlcmUgdGhhdCBzZWd2IGlzIG5vdCBwcmVz ZW50ZWQgd2hlbiB3ZSBzZXQgdGhlIEJORCByZWdpc3RlciBpbiB0aGUgcHJv bG9nLg0KKFRoZSBtYW51YWwgc2V0IGlzIG1lYW50KSANCkkgaW50ZW5kZWQg dG8gZm9yY2UgYSBib3VuZGFyeSB2aW9sYXRpb24uIEJ1dCBkaWQgbm90IHdv cmsuDQoNCj4gDQo+IFdoZW4gd2Ugc2V0IHRoZSBCTkQgcmVnaXN0ZXJzIGZy b20gZ2RiIGl0c2VsZiAoYXBwbHlpbmcgdGhlIHBhdGNoKSBpdCANCj4gbG9v a3MgbGlrZSBjaGFuZ2luZyB0aGUgdmFsdWVzIG9mIEJORCBhZ2FpbiB3aGls ZSBpbiB0aGUgcHJvbG9nIGhhdmUgDQo+IG5vIGVmZmVjdC4NCj4gTGV0cyBn byB0byB0aGUgcmVwcm9kdWNlcjoNCj4gDQo+IFRoZSBpbmZlcmlvciBjYWxs IGkgd2FudCB0byBkbyBpcyAidXBwZXIgKHgsIGEsIGIsIGMsIGQsIDEwMCki Lg0KPiBpdCBoYXMgdGhlIGZvbGxvd2luZyByZWxldmFudCBwcm9sb2c6DQo+ IA0KPiAgIDB4MDAwMDAwMDAwMDQwMGEwYiA8KzE+OiAgICBtb3YgICAgJXJz cCwlcmJwDQo+ICAgIDB4MDAwMDAwMDAwMDQwMGEwZSA8KzQ+OiAgICBzdWIg ICAgJDB4MTgsJXJzcA0KPiAgICAweDAwMDAwMDAwMDA0MDBhMTIgPCs4Pjog ICAgbW92ICAgICVyZGksLTB4MTgoJXJicCkNCj4gICAgMHgwMDAwMDAwMDAw NDAwYTE2IDwrMTI+OiAgICBtb3YgICAgJXJzaSwtMHgyMCglcmJwKQ0KPiAg ICAweDAwMDAwMDAwMDA0MDBhMWEgPCsxNj46ICAgIG1vdiAgICAlcmR4LC0w eDI4KCVyYnApDQo+ICAgIDB4MDAwMDAwMDAwMDQwMGExZSA8KzIwPjogICAg bW92ICAgICVyY3gsLTB4MzAoJXJicCkNCj4gICAgMHgwMDAwMDAwMDAwNDAw YTIyIDwrMjQ+OiAgICBtb3YgICAgJXI4LC0weDM4KCVyYnApDQo+ICAgIDB4 MDAwMDAwMDAwMDQwMGEyNiA8KzI4PjogICAgbW92ICAgICVyOWQsLTB4M2Mo JXJicCkNCj4gICAgMHgwMDAwMDAwMDAwNDAwYTJhIDwrMzI+OiAgICBibmRt b3YgJWJuZDAsLTB4NTAoJXJicCkNCj4gICAgMHgwMDAwMDAwMDAwNDAwYTJm IDwrMzc+OiAgICBibmRtb3YgJWJuZDEsLTB4NjAoJXJicCkNCj4gICAgMHgw MDAwMDAwMDAwNDAwYTM0IDwrNDI+OiAgICBibmRtb3YgJWJuZDIsLTB4NzAo JXJicCkNCj4gICAgMHgwMDAwMDAwMDAwNDAwYTM5IDwrNDc+OiAgICBibmRt b3YgJWJuZDMsLTB4ODAoJXJicCkNCj4gDQo+IEkgY2FuIHN0b3AgYXQgdGhl IGZpcnN0IGluc3RydWN0aW9uIG9mICJ1cHBlciIgYnkgaXNzdWluZyBiICh2 b2lkKikmdXBwZXIuDQoNCkZZSSwgdGhlIHVzdWFsIHdheSB0byBkbyB0aGF0 IGlzIHdpdGggImIgKnVwcGVyIi4NCg0KDQo+IEluIG9yZGVyIHRvIHZlcmlm eSB0aGUgZWZmZWN0aXZlIGNoYW5nZSBpbiB0aGUgQk5EIGkgaGF2ZSBwcmlu dGVkIA0KPiBibmQwLi5ibmQzLiBSZWdpc3RlciB2YWx1ZXMgd2VyZSBzYW1l IGFzIGVudGVyZWQgd2l0aCB0aGUgR0RCIGNvbW1hbmQuDQoNCnByaW50ZWQg aG93PyAgYW5kIHByaW50ZWQgd2hlbiBleGFjdGx5Pw0KDQpGUkVEOg0KU28s IHN0b3BwZWQgYXQgMHgwMDAwMDAwMDAwNDAwYTBiIHNldCBCTkQwIGFuZCBk aWQgYSBzdGVwIGluc3RydWN0aW9uIGFuZCBwcmludGVkIEJORDANCkNvbW1h bmRzIHdlcmU6IA0KUCAkYm5kMD17MHhGRkZGRi4uLiwgMH0gDQpTaQ0KUCAk Ym5kMCAob3V0cHV0IHdhcyB0aGUgc2FtZSBhcyBpbnB1dCkNCg0KRm9yIHRo ZSB2YWx1ZSBJIHNldCBJIHNob3VsZCBoYXZlIGdvdCBhbiBzZWd2LiBCdXQg SSBkaWQgbm90LiANCj4gT3RoZXIgd2F5IGlzIHRvIGRvIGluc3RydWN0aW9u IHN0ZXBwaW5nIHRpbGwgIiBibmRtb3YgJWJuZDMsLTB4ODAoJXJicCkiDQo+ IGFuZCBleGFtaW5lIHRoZSBtZW1vcnkgYXQgdGhlIGluZGljYXRlZCBwbGFj ZXMuDQoNCk1lbW9yeT8gIEkgdGhvdWdodCB5b3UnZCBleGFtaW5lIHRoZSBy ZWdpc3RlcnM/ICBXaGF0IGluZGljYXRlZCBwbGFjZXMsIEJUVz8NCg0KRlJF RDoNClllcywgdHJpbmcgdG8gZGlzY292ZXIgd2hhdCBoYXBwZW5lZCB0byB0 aGUgc2V0IEkgc3RlcHBlZCBpbnN0cnVjdGlvbnMgdGlsbCAweDAwMDAwMDAw MDA0MDBhMmYNClRoaXMgdGVsbHMgbWUgdGhhdCB0aGUgQk5EMCBzaG91bGQg YmUgYXQgIDB4NTAoJXJicCkgYnV0IHZhbHVlIHdhcyBub3QgdGhlIG9uZSBJ IGFkZGVkIGJ5IGhhbmQgYnV0IHRoZSBhdXRvbWF0aWNhbGx5IHNldCAod2l0 aCB0aGUgcGF0Y2gpDQpJbnRlcmVzdGluZ2x5IHdpdGhvdXQgdGhlIHBhdGNo LCBhbmQgcmVwZWF0aW5nIHRoZSBzYW1lIHByb2NlZHVyZSwgdGhlIHZhbHVl IGlzIHRoZSBvbmUgSSBoYXZlIHNldCBieSBoYW5kIHdoaWxlIHN0b3BwZWQg YXQgdGhlIHByb2xvZy4NCg0KIA0KPiANCj4gU3VycHJpc2UhIEluIHRoZSBn ZGIgaSBoYXZlIGFwcGxpZWQgdGhlIHBhdGNoIHRob3VnaCBjaGFuZ2luZyB0 aGUNCj4gQk5EMC4uQk5EMyB2YWx1ZXMgYXQgMHgwNDAwYTBiIHZhbHVlIHBy ZXNlbnQgb24gbWVtb3J5IHdhcyBzdGlsbCBzZXQgDQo+IHRvIHRoZSBpbml0 IHN0YXRlLg0KDQpfbWVtb3J5XyBzZXQgdG8gdGhlIGluaXQgc3RhdGU/DQoN CkZSRUQ6DQpYIC80dyAoJHJicCAtMHg1MCkNCg0KV2hlbiBzdG9wcGVkIGF0 IDB4MDAwMDAwMDAwMDQwMGEyZiB3ZSBzaG91bGQgc2VlIHRoZSB2YWx1ZSBz ZXQgb2YgJEJORDAgd2hhdCB3ZSBzZWUgaXMgdGhlIGF1dG9tYXRpYyBzZXQg dmFsdWUgYW5kIG5vdCB0aGUgdmFsdWUgSSBzZXQgd2hlbiBhdCB0aGUgcHJv bG9nLg0KDQpQZWRybzoNCkNhbiB5b3UgcGxlYXNlIGV4cGxhaW4gd2hhdCB5 b3UncmUgc2VlaW5nIGluIGEgYml0IG1vcmUgZGV0YWlsPw0KWW91J3JlIGxl YXZpbmcgb3V0IGRldGFpbHMgSSdtIGZpbmRpbmcgbXlzZWxmIG5lZWRpbmcg dG8gZ3Vlc3MsIGFuZCBJJ2QgcHJvYmFibHkgZ3Vlc3Mgd3JvbmcuDQoNCkJ1 dCBzdGlsbCwgaWYgSSBoYXZlIHRvIGd1ZXNzLCBJJ2QgdGhpbmsgdGhhdCB0 aGUgcHJvYmxlbSB3aXRoIHN0b3BwaW5nIGF0IGZ1bmN0aW9uIGVudHJ5IGFu ZCBwb2tpbmcgdGhlIGJuZCByZWdpc3RlcnMgX2JlZm9yZV8gdGhlIHByb2xv Z3VlIHJ1bnMsIHdvdWxkIGJlIHRoYXQgd2hhdGV2ZXIgYm5kIHJlZ2lzdGVy IHZhbHVlIHlvdSBwYXRjaCBpbiwgd291bGQgYmUgb3ZlcnJpZGRlbiBieSB0 aGUgYm5kbW92IGluc3RydWN0aW9ucyBpbiB0aGUgcHJvbG9ndWUuICBJLmUu LCB5b3UgbmVlZCB0byBzaW5nbGUtc3RlcCBwYXN0IHRob3NlIGJuZG1vdiBp bnN0cnVjdGlvbnMsIGFuZCBwYXRjaCB0aGUgYm5kIHJlZ2lzdGVycyBfdGhl bl8sIG90aGVyd2lzZSB0aGUgYm5kbW92cyB1bmRvIHlvdXIgcGF0Y2hpbmcu DQoNCg0KQnV0IHRoaXMgY29tbWVudDoNCg0KPiBJbiB0aGUgdmVyc2lvbiB3 aXRob3V0IGFwcGx5aW5nIHRoZSBwYXRjaCBpdCBpIGNvdWxkIHNlZSB0aGUg dmFsdWUgaSANCj4gZW50ZXJlZCB3aGlsZSBzdG9wcGVkIGF0IHRoZSBmaXJz dCBpbnN0cnVjdGlvbi4NCg0KLi4uIHNlZW1zIHRvIGNvbnRyYWRpY3QgdGhh dC4gIFNvIEknbSBkb3VibGUgY29uZnVzZWQuDQoNClN0aWxsLCBJIGRvbid0 IHNlZSB3aGF0IGRvZXMgdGhpcyBoYXZlIHRvIGRvIHdpdGggcG9pbnQgNy4N Cg0KVGhhbmtzLA0KUGVkcm8gQWx2ZXMNCg0KDQpGcmVkOg0KVGhhbmtzIGEg bG90IGFnYWluISBJIGhvcGUgSSBjb3VsZCBnZXQgdGhlIG1lc3NhZ2UgdHJv dWdoIG5vdy4gV2l0aCBtZW1vcnkgcmVnaXN0ZXJzIHNldCBhbmQgbm90IHNl dCB0aGUgc2V0dXAgd2FzIGEgYml0IGNvbXBsaWNhdGVkIGluIGNhc2UgaXQg aXMgc3RpbGwgbm90IGNsZWFyLCBJIHdpbGwgc2VuZCB0aGUgZnVsbCBsb2cu DQoNClJlZ2FyZHMsDQovRnJlZA0KSW50ZWwgRGV1dHNjaGxhbmQgR21iSApS ZWdpc3RlcmVkIEFkZHJlc3M6IEFtIENhbXBlb24gMTAtMTIsIDg1NTc5IE5l dWJpYmVyZywgR2VybWFueQpUZWw6ICs0OSA4OSA5OSA4ODUzLTAsIHd3dy5p bnRlbC5kZQpNYW5hZ2luZyBEaXJlY3RvcnM6IENocmlzdGluIEVpc2Vuc2No bWlkLCBDaHJpc3RpYW4gTGFtcHJlY2h0ZXIKQ2hhaXJwZXJzb24gb2YgdGhl IFN1cGVydmlzb3J5IEJvYXJkOiBOaWNvbGUgTGF1ClJlZ2lzdGVyZWQgT2Zm aWNlOiBNdW5pY2gKQ29tbWVyY2lhbCBSZWdpc3RlcjogQW10c2dlcmljaHQg TXVlbmNoZW4gSFJCIDE4NjkyOAo= >From gdb-patches-return-137067-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Feb 16 16:15:44 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 118405 invoked by alias); 16 Feb 2017 16:15:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 107266 invoked by uid 89); 16 Feb 2017 16:15:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Feb 2017 16:15:19 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C28B80460; Thu, 16 Feb 2017 16:15:18 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1GGFFYa002094; Thu, 16 Feb 2017 11:15:15 -0500 Subject: Re: [PATCH V7] amd64-mpx: initialize bnd register before performing inferior calls. To: "Tedeschi, Walfred" , "qiyaoltc@gmail.com" , "brobecker@adacore.com" References: <1485875613-31975-1-git-send-email-walfred.tedeschi@intel.com> <53d42bb6-3b83-6213-4087-6d30e7d837de@redhat.com> <217a8c13-b7d0-7fe6-56b5-85ff53ce097a@intel.com> <88c7180f-8843-a148-425a-2adf56c6d0bf@redhat.com> <32693426-fbaf-8345-04c7-e2c329d6ec6e@intel.com> <65ae9889-ab18-7228-c612-d47ec728174f@redhat.com> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: <8ef81952-9bf6-3d1a-1b91-ba77cf9c716f@redhat.com> Date: Thu, 16 Feb 2017 16:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00444.txt.bz2 Content-length: 1850 On 02/16/2017 03:36 PM, Tedeschi, Walfred wrote: > FRED: > So, stopped at 0x0000000000400a0b set BND0 and did a step instruction and printed BND0 > Commands were: > P $bnd0={0xFFFFF..., 0} > Si > P $bnd0 (output was the same as input) That seems expected. > > For the value I set I should have got an segv. But I did not. >> Other way is to do instruction stepping till " bndmov %bnd3,-0x80(%rbp)" >> and examine the memory at the indicated places. > > Memory? I thought you'd examine the registers? What indicated places, BTW? > > FRED: > Yes, tring to discover what happened to the set I stepped instructions till 0x0000000000400a2f > This tells me that the BND0 should be at 0x50(%rbp) Ah, yes I see what you mean now. Well, actually it should be at -0x50(%rbp) [negative]. Now I don't know whether that was just a typo. :-P Otherwise something's very odd indeed. > but value was not the one I added by hand but the automatically set (with the patch) > Interestingly without the patch, and repeating the same procedure, the value is the one I have set by hand while stopped at the prolog. Could your patch be clearing something that disables bnd-related instructions completely? Perhaps %bndcfgu? In your patch you have: for (int i = 0; i < I387_BND0R_REGNUM (tdep); i++) regcache_raw_write (regcache, I387_BND0R_REGNUM (tdep) + i, bnd_buf); What does the "I387_BND0R_REGNUM (tdep)" in the for loop condition mean? That should have been "the number of bnd registers" I suppose, but doesn't look like that's what the code is really doing, as I387_BND0R_REGNUM is really the number of the _first_ bnd register, AFAICS. Shouldn't that be I387_NUM_BND_REGS instead, like: for (int i = 0; i < I387_NUM_BND_REGS; i++) regcache_raw_write (regcache, I387_BND0R_REGNUM (tdep) + i, bnd_buf); ? Thanks, Pedro Alves