Yao, Thanks for your review! Yes I run all test suites. I was afraid that we could break other languages as weel. However it was only 64bit tests, but all suites. I will rewrite the entry for the Changelog. May I push then, or do you want to review it again? Thanks and regards, /Fred PS: Sorry for top posting, I have to reconfigure my thunderbird. -----Original Message----- From: Yao Qi [mailto:qiyaoltc@gmail.com] Sent: Friday, July 1, 2016 11:20 AM To: Tedeschi, Walfred Cc: palves@redhat.com; qiyaoltc@gmail.com; gdb-patches@sourceware.org Subject: Re: [PATCH V2 1/1] Fix of default lookup for "this" symbol. Walfred Tedeschi writes: > Tests: Performed tests with gfortran and ifort. > I assume you run all gdb testsuite rather than fortran tests only. The patch is good to me if it is regression free with running all gdb tests. > 2016-06-16 Walfred Tedeschi > > gdb/ChangeLog: > > * cp-namespace.c (cp_lookup_bare_symbol): Add check for the > name_of_this in order to return a null symbol when looking up > for "this". The entry doesn't reflect your change below. Please rewrite it. -- Yao (齐尧) Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928 &j!z޶}b֫rnr