From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76192 invoked by alias); 21 Jun 2016 08:24:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76171 invoked by uid 89); 21 Jun 2016 08:24:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_50,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=fred, Fred, Deutschland, deutschland X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Jun 2016 08:24:32 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 21 Jun 2016 01:24:30 -0700 X-ExtLoop1: 1 Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jun 2016 01:24:29 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.117]) by irsmsx105.ger.corp.intel.com ([169.254.7.51]) with mapi id 14.03.0248.002; Tue, 21 Jun 2016 09:22:28 +0100 From: "Tedeschi, Walfred" To: Yao Qi CC: "palves@redhat.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH V3] Improve user experience in printing Fortran derived types. Date: Tue, 21 Jun 2016 08:24:00 -0000 Message-ID: References: <1466493448-17323-1-git-send-email-walfred.tedeschi@intel.com> <864m8nrmkt.fsf@gmail.com> In-Reply-To: <864m8nrmkt.fsf@gmail.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00350.txt.bz2 WWFvLA0KDQpUaGFua3MgZm9yIHlvdXIgcHJvbXB0IHJldmlldyENCg0KSSB3 aWxsIGFkZCBhIGxpbmsgdG8gdGhlIGxhc3QgcmV2aXNpb24gd2hlbiBzZW5k aW5nIHRoZSBuZXcgcGF0Y2gsIHNvcnJ5IGZvciB0aGF0Lg0KDQpGb3IgdGhl IGRlcml2ZWQtdHlwZS1mdW5jdGlvbi5leHAsIEkgYW0gZml4aW5nIHRoZSBu YW1lLg0KDQpUaGFua3MgYWdhaW4sDQpGcmVkDQotLS0tLU9yaWdpbmFsIE1l c3NhZ2UtLS0tLQ0KRnJvbTogWWFvIFFpIFttYWlsdG86cWl5YW9sdGNAZ21h aWwuY29tXSANClNlbnQ6IFR1ZXNkYXksIEp1bmUgMjEsIDIwMTYgOTowOCBB TQ0KVG86IFRlZGVzY2hpLCBXYWxmcmVkIDx3YWxmcmVkLnRlZGVzY2hpQGlu dGVsLmNvbT4NCkNjOiBwYWx2ZXNAcmVkaGF0LmNvbTsgcWl5YW9sdGNAZ21h aWwuY29tOyBnZGItcGF0Y2hlc0Bzb3VyY2V3YXJlLm9yZw0KU3ViamVjdDog UmU6IFtQQVRDSCBWM10gSW1wcm92ZSB1c2VyIGV4cGVyaWVuY2UgaW4gcHJp bnRpbmcgRm9ydHJhbiBkZXJpdmVkIHR5cGVzLg0KDQpXYWxmcmVkIFRlZGVz Y2hpIDx3YWxmcmVkLnRlZGVzY2hpQGludGVsLmNvbT4gd3JpdGVzOg0KDQpI aSBXYWxmcmVkLA0KV2hlbiB5b3UgcG9zdCBWMywgcGxlYXNlIGdpdmUgYSBs aW5rIHRvIFYyIGluIHlvdXIgZW1haWwsIHNvIHRoYXQgSSBjYW4gcmVjYWxs IHRoZSByZXZpZXcgbGFzdCB0aW1lLg0KDQpQYXRjaCBpcyBnb29kIHRvIG1l Lg0KDQo+ICshIEloaXMgZmlsZSBpcyB0aGUgRm9ydHJhbiBzb3VyY2UgZmls ZSBmb3IgZGVyaXZlZC10eXBlLmV4cC4gIEl0IHdhcw0KDQpkZXJpdmVkLXR5 cGUtZnVuY3Rpb24uZXhwPw0KDQotLQ0KWWFvICjpvZDlsKcpDQpJbnRlbCBE ZXV0c2NobGFuZCBHbWJIClJlZ2lzdGVyZWQgQWRkcmVzczogQW0gQ2FtcGVv biAxMC0xMiwgODU1NzkgTmV1YmliZXJnLCBHZXJtYW55ClRlbDogKzQ5IDg5 IDk5IDg4NTMtMCwgd3d3LmludGVsLmRlCk1hbmFnaW5nIERpcmVjdG9yczog Q2hyaXN0aW4gRWlzZW5zY2htaWQsIENocmlzdGlhbiBMYW1wcmVjaHRlcgpD aGFpcnBlcnNvbiBvZiB0aGUgU3VwZXJ2aXNvcnkgQm9hcmQ6IE5pY29sZSBM YXUKUmVnaXN0ZXJlZCBPZmZpY2U6IE11bmljaApDb21tZXJjaWFsIFJlZ2lz dGVyOiBBbXRzZ2VyaWNodCBNdWVuY2hlbiBIUkIgMTg2OTI4Cg== >From gdb-patches-return-132207-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Jun 21 08:34:46 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 97392 invoked by alias); 21 Jun 2016 08:34:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 97380 invoked by uid 89); 21 Jun 2016 08:34:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:471, HTo:U*tom X-HELO: mail-pf0-f172.google.com Received: from mail-pf0-f172.google.com (HELO mail-pf0-f172.google.com) (209.85.192.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 21 Jun 2016 08:34:35 +0000 Received: by mail-pf0-f172.google.com with SMTP id t190so4492880pfb.3 for ; Tue, 21 Jun 2016 01:34:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=qQYccXLpvSQOZJ+iSCsgTCfjfxb2K7MA/ZGexmKqPuU=; b=A+uQ4LOpYNpPz07fjFiefWuFS+XIH4KPxy1ekvxlLcJl6GIV2Dcr627Zid58rUHQQT HMZ67OGX2D3ITh3E0B18I3jDRNv9WtaYBT3lLagrs9Mw71eNwUKKTrg2m8ztUkNuQN8R n5qdqg5MII72yuWU7kzK+rHImnuxLCxjhjp/r+EIhpztWI/fpZWLKuVwStSube8OkMIf IOF+aCufBryf81ZpzwU7GkUnx2xQ+VvyX/b9OuCzD3QWaPdhRxFFoMaY6PiQvHtPXIfa KQsVh5GhS2Dt84gugXveVmhTfPWVnW9y9Mj6izcPFQYb+DzG1Ahq34mL1BNPE5FmFFZC SK/Q== X-Gm-Message-State: ALyK8tLxRTu/bdLeG+XhoqHTPHGU2X4ePv9fLCEkybQ8x2+GbzNxAKXLakob7/N6Uk6p8w== X-Received: by 10.98.99.132 with SMTP id x126mr26780608pfb.48.1466498073634; Tue, 21 Jun 2016 01:34:33 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id q127sm93716890pfb.34.2016.06.21.01.34.31 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 21 Jun 2016 01:34:32 -0700 (PDT) From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] PR python/18565 - make Frame.function work for inline frames References: <1466439050-11330-1-git-send-email-tom@tromey.com> Date: Tue, 21 Jun 2016 08:34:00 -0000 In-Reply-To: <1466439050-11330-1-git-send-email-tom@tromey.com> (Tom Tromey's message of "Mon, 20 Jun 2016 10:10:50 -0600") Message-ID: <86ziqfq6sz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00351.txt.bz2 Content-length: 477 Tom Tromey writes: > TRY > { > + char *funname; > + enum language funlang; > + > FRAPY_REQUIRE_VALID (self, frame); >=20=20 > - sym =3D find_pc_function (get_frame_address_in_block (frame)); > + find_frame_funname (frame, &funname, &funlang, &sym); > + xfree (funname); > } > CATCH (except, RETURN_MASK_ALL) > { Call xfree in CATCH block? Otherwise, patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)