From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102265 invoked by alias); 13 Jun 2016 15:18:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102252 invoked by uid 89); 13 Jun 2016 15:18:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_20,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=answered, Directors, U*gdb-patches, gdbpatchessourcewareorg X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jun 2016 15:18:07 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 13 Jun 2016 08:18:05 -0700 X-ExtLoop1: 1 Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga001.fm.intel.com with ESMTP; 13 Jun 2016 08:18:04 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 13 Jun 2016 16:18:03 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.117]) by IRSMSX156.ger.corp.intel.com ([10.108.20.68]) with mapi id 14.03.0248.002; Mon, 13 Jun 2016 16:18:03 +0100 From: "Tedeschi, Walfred" To: "Tedeschi, Walfred" , Yao Qi CC: Pedro Alves , gdb-patches , Joel Brobecker Subject: RE: [PATCH V5 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls. Date: Mon, 13 Jun 2016 15:18:00 -0000 Message-ID: References: <1458310577-20021-1-git-send-email-walfred.tedeschi@intel.com> <86potcflcw.fsf@gmail.com> <571F8B5C.8070003@intel.com> <572749D2.5040106@intel.com> In-Reply-To: <572749D2.5040106@intel.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00239.txt.bz2 WWFvIGFuZCBBbGwsDQoNCk5vdCBzdXJlIGlmIEkgaGF2ZSBhbnN3ZXJlZCBZ YW8gcXVlc3Rpb25zLiBDb3VsZCBub3QgZmluZCBhbnkgYWRkaXRpb25hbCBy ZXZpZXcgYWJvdXQgdGhpcyBwYXRjaC4NCg0KSXMgaXQgb2sgdG8gcHVzaCB0 aGUgcGF0Y2g/DQoNCldpdGhvdXQgdGhhdCB0aGUgdXNhZ2Ugb2YgdGhlIGNv bW1hbmQgInJldHVybiIgaW4gdGhlIE1QWCBjb250ZXh0IHdpbGwgY2F1c2Ug Ym91bmRhcnkgdmlvbGF0aW9ucyBpbiB0aGUgaW5mZXJpb3IuDQoNClRoYW5r cyBhbmQgcmVnYXJkcywNCi1GcmVkIA0KDQogDQoNCi0tLS0tT3JpZ2luYWwg TWVzc2FnZS0tLS0tDQpGcm9tOiBnZGItcGF0Y2hlcy1vd25lckBzb3VyY2V3 YXJlLm9yZyBbbWFpbHRvOmdkYi1wYXRjaGVzLW93bmVyQHNvdXJjZXdhcmUu b3JnXSBPbiBCZWhhbGYgT2YgV2FsZnJlZCBUZWRlc2NoaQ0KU2VudDogTW9u ZGF5LCBNYXkgMiwgMjAxNiAxOjM3IFBNDQpUbzogWWFvIFFpIDxxaXlhb2x0 Y0BnbWFpbC5jb20+DQpDYzogUGVkcm8gQWx2ZXMgPHBhbHZlc0ByZWRoYXQu Y29tPjsgZ2RiLXBhdGNoZXMgPGdkYi1wYXRjaGVzQHNvdXJjZXdhcmUub3Jn PjsgSm9lbCBCcm9iZWNrZXIgPGJyb2JlY2tlckBhZGFjb3JlLmNvbT4NClN1 YmplY3Q6IFJlOiBbUEFUQ0ggVjUgMi8yXSBBZGQgbXB4LWJuZC1pbml0LW9u LXJldHVybiBzZXQvc2hvdyBjb21tYW5kIGZvciBpbmZlcmlvciBjYWxscy4N Cg0KQW0gNC8yNi8yMDE2IHVtIDU6MzggUE0gc2NocmllYiBXYWxmcmVkIFRl ZGVzY2hpOg0KPiBBbSA0LzI2LzIwMTYgdW0gNToxOSBQTSBzY2hyaWViIFlh byBRaToNCj4+IFdhbGZyZWQgVGVkZXNjaGkgPHdhbGZyZWQudGVkZXNjaGlA aW50ZWwuY29tPiB3cml0ZXM6DQo+Pg0KPj4+IFdoZW4gdXNpbmcgdGhlIHJl dHVybiBjb21tYW5kLCBleGVjdXRpb24gb2YgYSBmdW5jdGlvbiBpcyBhYm9y dGVkIA0KPj4+IGFuZCBwcmVzZW50IHZhbHVlcyBhcmUgcmV0dXJuZWQgZnJv bSB0aGF0IHBvaW50LiAgVGhhdCBjYW4gY2F1c2UgDQo+Pj4gYm91bmQgdmlv bGF0aW9ucyBpbiB0aGUgTVBYIGNvbnRleHQuICBUbyBhdm9pZCBzdWNoIHNp ZGUtZWZmZWN0cywgYSANCj4+PiBuZXcgc2V0dGluZyAoIm1weC1ibmQtaW5p dC1vbi1yZXR1cm4iKSB3YXMgYWRkZWQgdG8gY29udHJvbCB0aGUgDQo+Pj4g aW5pdGlhbGl6YXRpb24gb2YgYm91bmQgcmVnaXN0ZXIgd2hlbiB1c2luZyB0 aGUgcmV0dXJuIGNvbW1hbmQuDQo+Pj4NCj4+DQo+PiBXZSBuZWVkIHRvIGlu dmVzdGlnYXRlIHdoeSBkb2VzICJyZXR1cm4iIGNhdXNlIGJvdW5kIHZpb2xh dGlvbnMuICBJZiANCj4+IHRoZSB2aW9sYXRpb25zIGFyZSBjYXVzZWQgYnkg dGhlIGludmFsaWQgb3IgZ2FyYmFnZSByZXR1cm4gdmFsdWUsIA0KPj4gdGhh dCBpcyBleHBlY3RlZCwgYW5kIGl0IGlzIGEgY29ycmVjdCBiZWhhdmlvciB0 byBtZS4gIElmIHRoZSByZXR1cm4gDQo+PiB2YWx1ZSBpcyBvdXQgb2YgdGhl IGJvdW5kcyBvZiByZWdpc3RlcnMgc2V0dGluZ3MsIHRoZSB2aW9sYXRpb24g aXMgDQo+PiBjYXVzZWQuICBDYW4gd2UgdHdlYWsgR0RCIHRvIGFkanVzdCB0 aGUgcmVnaXN0ZXIgc2V0dGluZ3MgdG8gYWxsb3cgDQo+PiB0aGVzZSBtZW1v cnkgYWNjZXNzZXMgaW4gdGhlICJyZXR1cm4iPw0KPj4NCj4NCj4gWWFvLA0K Pg0KPiBUaGFua3MgYWdhaW4gZm9yIHRoZSBwcm9tcHQgcmV2aWV3ISA6KQ0K Pg0KPg0KPiBUaGUgInJldHVybiIgY2F1c2VzIGEgcHJlbWF0dXJlIGV4aXQg ZnJvbSB0aGUgZnVuY3Rpb24uIEJORCBpcyBvbmx5IA0KPiByZXR1cm5pbmcg dGhlIGJvdW5kcyBvZiB0aGUgcG9pbnRlciB3aGljaCBpcyByZXR1cm5lZCBp biB0aGUgdXN1YWwgd2F5Lg0KPiAgIFRoZSBub3ZlbHR5IGhlcmUgaXMgdGhl IEJORCByZWdpc3RlcnMuIEluIGNhc2Ugd2UgYXJlIHJldHVybmluZyBhIA0K PiBwb2ludGVyIG9yIGFkZHJlc3MgQk5EMCB3aWxsIGNhcnJ5IHRoZSBib3Vu ZHMgb2YgdGhlIHBvaW50ZXIgYmVpbmcgDQo+IHJldHVybmVkLiBPbmNlIGl0 IGlzIG5vdCBzZXQgeWV0IHRoYW4gZ2FyYmFnZSB3aWxsIGJlIHJldHVybmVk IGluc3RlYWQuDQo+DQo+IEluIHRoaXMgd2F5IHRoZSB2YWx1ZSBpcyB3cm9u ZyBhbmQgYSBib3VuZCB2aW9sYXRpb25zIGlzIGxpa2VseSB0byBoYXBwZW4u DQo+DQo+IFJlZ2FyZHMsDQo+IC1GcmVkDQo+DQoNCg0KWWFvLA0KDQpBbnkg Y29tbWVudCBvbiB0aG9zZSBvYnNlcnZhdGlvbnM/DQoNClRoYW5rcyBhbmQg cmVnYXJkcywNCi1GcmVkDQoNCkludGVsIERldXRzY2hsYW5kIEdtYkgNClJl Z2lzdGVyZWQgQWRkcmVzczogQW0gQ2FtcGVvbiAxMC0xMiwgODU1NzkgTmV1 YmliZXJnLCBHZXJtYW55DQpUZWw6ICs0OSA4OSA5OSA4ODUzLTAsIHd3dy5p bnRlbC5kZQ0KTWFuYWdpbmcgRGlyZWN0b3JzOiBDaHJpc3RpbiBFaXNlbnNj aG1pZCwgQ2hyaXN0aWFuIExhbXByZWNodGVyIENoYWlycGVyc29uIG9mIHRo ZSBTdXBlcnZpc29yeSBCb2FyZDogTmljb2xlIExhdSBSZWdpc3RlcmVkIE9m ZmljZTogTXVuaWNoIENvbW1lcmNpYWwgUmVnaXN0ZXI6IEFtdHNnZXJpY2h0 IE11ZW5jaGVuIEhSQiAxODY5MjgNCkludGVsIERldXRzY2hsYW5kIEdtYkgK UmVnaXN0ZXJlZCBBZGRyZXNzOiBBbSBDYW1wZW9uIDEwLTEyLCA4NTU3OSBO ZXViaWJlcmcsIEdlcm1hbnkKVGVsOiArNDkgODkgOTkgODg1My0wLCB3d3cu aW50ZWwuZGUKTWFuYWdpbmcgRGlyZWN0b3JzOiBDaHJpc3RpbiBFaXNlbnNj aG1pZCwgQ2hyaXN0aWFuIExhbXByZWNodGVyCkNoYWlycGVyc29uIG9mIHRo ZSBTdXBlcnZpc29yeSBCb2FyZDogTmljb2xlIExhdQpSZWdpc3RlcmVkIE9m ZmljZTogTXVuaWNoCkNvbW1lcmNpYWwgUmVnaXN0ZXI6IEFtdHNnZXJpY2h0 IE11ZW5jaGVuIEhSQiAxODY5MjgK >From gdb-patches-return-132096-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Jun 13 15:24:53 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 2323 invoked by alias); 13 Jun 2016 15:24:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 2311 invoked by uid 89); 13 Jun 2016 15:24:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Etc X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Jun 2016 15:24:42 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5B9B85546; Mon, 13 Jun 2016 15:24:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5DFOdQT020693; Mon, 13 Jun 2016 11:24:40 -0400 Subject: Re: [PATCH 09/12] Make reinsert_breakpoint thread specific To: Yao Qi , gdb-patches@sourceware.org References: <1464859846-15619-1-git-send-email-yao.qi@linaro.org> <1464859846-15619-10-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <71a5322e-41e3-9e23-df73-e14b14c1d656@redhat.com> Date: Mon, 13 Jun 2016 15:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1464859846-15619-10-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00240.txt.bz2 Content-length: 4091 On 06/02/2016 10:30 AM, Yao Qi wrote: > V2: rewrite commit log to make it easy to read, > "id" -> "ptid", Thanks. > > This patch makes reinsert_breakpoint thread specific, which means we > insert and remove reinsert_breakpoint breakpoints for a specific > thread. This motivation of this change is that I'll use > reinsert_breakpoint for vCont;s on software single step target, so that > GDBserver may insert one reinsert_breakpoint for one thread doing > step-over, and insert one reinsert_breakpoint for another thread doing > vCont;s. After the operation of one thread is finished, GDBserver must > remove reinsert_breakpoint for that thread only. > > On the other hand, reinsert_breakpoint is used for step-over nowadays. > GDBserver inserts reinsert_breakpoint, and wait only from the thread > doing step-over. After the step-over is done, GDBserver removes the > reinsert_breakpoint. If there is still any threads need step-over, do > the same again until all threads are finished step-over. In other words, > reinsert_breakpoint is globally thread specific, but in an implicit way. > It is natural to make it explicitly thread specific. > > gdb/gdbserver: > > 2016-05-20 Yao Qi > > * mem-break.c (struct reinsert_breakpoint) : New field. > (set_reinsert_breakpoint): New parameter ptid. Callers updated. > (delete_reinsert_breakpoints): Likewise. > (has_reinsert_breakpoints): Change parameter to thread. Callers > updated. > (clone_one_breakpoint): Likewise. > (uninsert_reinsert_breakpoints): Likewise. > (reinsert_reinsert_breakpoints): Likewise. > * mem-break.h (set_reinsert_breakpoint): Update declaration. > (delete_reinsert_breakpoints): Likewise. > (reinsert_reinsert_breakpoints): Likewise. > (uninsert_reinsert_breakpoints): Likewise. > (has_reinsert_breakpoints): Likewise. > --- > gdb/gdbserver/linux-low.c | 25 +++++++++++-------------- > gdb/gdbserver/mem-break.c | 44 +++++++++++++++++++++++++++++++------------- > gdb/gdbserver/mem-break.h | 23 ++++++++++++----------- > 3 files changed, 54 insertions(+), 38 deletions(-) > > diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c > index b0af178..414117b 100644 > --- a/gdb/gdbserver/linux-low.c > +++ b/gdb/gdbserver/linux-low.c > @@ -555,7 +555,7 @@ handle_extended_wait (struct lwp_info **orig_event_lwp, int wstat) > hit it, so uninsert reinsert breakpoints from parent > (and child). Once vfork child is done, reinsert > them back to parent. */ > - uninsert_reinsert_breakpoints (); > + uninsert_reinsert_breakpoints (ptid_of_lwp (event_lwp)); > current_thread = saved_thread; Would it work to pass down the thread pointer directly? That would then allow pushing down the save current thread / restore current thread juggling to uninsert_reinsert_breakpoints too. > } > > @@ -597,11 +597,11 @@ handle_extended_wait (struct lwp_info **orig_event_lwp, int wstat) > to access its memory without stopping all other threads > from other processes. */ > current_thread = child_thr; > - delete_reinsert_breakpoints (); > + delete_reinsert_breakpoints (ptid); > current_thread = saved_thread; Likewise here, ptid is the child_thr's ptid here, I believe. > > - gdb_assert (has_reinsert_breakpoints (parent_proc)); > - gdb_assert (!has_reinsert_breakpoints (child_proc)); > + gdb_assert (has_reinsert_breakpoints (event_thr)); > + gdb_assert (!has_reinsert_breakpoints (child_thr)); > } > > /* Report the event. */ > @@ -656,13 +656,12 @@ handle_extended_wait (struct lwp_info **orig_event_lwp, int wstat) > if (event_lwp->bp_reinsert != 0 && can_software_single_step ()) > { > struct thread_info *saved_thread = current_thread; > - struct process_info *proc = get_thread_process (event_thr); > > current_thread = event_thr; > - reinsert_reinsert_breakpoints (); > + reinsert_reinsert_breakpoints (ptid_of_lwp (event_lwp)); > current_thread = saved_thread; Ditto. Etc. Thanks, Pedro Alves