From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59366 invoked by alias); 25 Feb 2016 16:39:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59353 invoked by uid 89); 25 Feb 2016 16:39:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,SPF_PASS autolearn=ham version=3.3.2 spammy=3967, 3968, 396,8, fred X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Feb 2016 16:39:05 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 25 Feb 2016 08:39:03 -0800 X-ExtLoop1: 1 Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga001.fm.intel.com with ESMTP; 25 Feb 2016 08:39:00 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.87]) by IRSMSX152.ger.corp.intel.com ([169.254.6.34]) with mapi id 14.03.0248.002; Thu, 25 Feb 2016 16:39:00 +0000 From: "Tedeschi, Walfred" To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH obv] Initialize variables in i386_linux_handle_segmentation_fault Date: Thu, 25 Feb 2016 16:39:00 -0000 Message-ID: References: <1456416469-16334-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1456416469-16334-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00804.txt.bz2 VGhhbmtzIFNpbW9uLA0KDQpIYXZlbid0IHNlZW4gdGhhdC4NCg0KUmVnYXJk cywNCi1GcmVkDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9t OiBnZGItcGF0Y2hlcy1vd25lckBzb3VyY2V3YXJlLm9yZyBbbWFpbHRvOmdk Yi1wYXRjaGVzLW93bmVyQHNvdXJjZXdhcmUub3JnXSBPbiBCZWhhbGYgT2Yg U2ltb24gTWFyY2hpDQpTZW50OiBUaHVyc2RheSwgRmVicnVhcnkgMjUsIDIw MTYgNTowOCBQTQ0KVG86IGdkYi1wYXRjaGVzQHNvdXJjZXdhcmUub3JnDQpD YzogU2ltb24gTWFyY2hpDQpTdWJqZWN0OiBbUEFUQ0ggb2J2XSBJbml0aWFs aXplIHZhcmlhYmxlcyBpbiBpMzg2X2xpbnV4X2hhbmRsZV9zZWdtZW50YXRp b25fZmF1bHQNCg0KRllJLCBJIGp1c3QgcHVzaGVkIHRoaXMgYXMgb2J2aW91 cy4NCg0KV2Ugc2VlIHRoaXMgZXJyb3Igd2hlbiBidWlsZGluZyB3aXRoIGdj YyA0LjMuDQoNCi4uLy4uL2dkYi9pMzg2LWxpbnV4LXRkZXAuYzogSW4gZnVu Y3Rpb24g4oCYaTM4Nl9saW51eF9oYW5kbGVfc2VnbWVudGF0aW9uX2ZhdWx0 4oCZOg0KLi4vLi4vZ2RiL2kzODYtbGludXgtdGRlcC5jOjM5OTogZXJyb3I6 IOKAmGFjY2Vzc+KAmSBtYXkgYmUgdXNlZCB1bmluaXRpYWxpemVkIGluIHRo aXMgZnVuY3Rpb24NCi4uLy4uL2dkYi9pMzg2LWxpbnV4LXRkZXAuYzozOTk6 IGVycm9yOiDigJh1cHBlcl9ib3VuZOKAmSBtYXkgYmUgdXNlZCB1bmluaXRp YWxpemVkIGluIHRoaXMgZnVuY3Rpb24NCi4uLy4uL2dkYi9pMzg2LWxpbnV4 LXRkZXAuYzozOTk6IGVycm9yOiDigJhsb3dlcl9ib3VuZOKAmSBtYXkgYmUg dXNlZCB1bmluaXRpYWxpemVkIGluIHRoaXMgZnVuY3Rpb24NCg0KSXQncyBh IGZhbHNlIHBvc2l0aXZlLCBzaW5jZSB0aGUgdmFyaWFibGVzIHdpbGwgYWx3 YXlzIGdldCBpbml0aWFsaXplZCBpbiB0aGUgVFJZIGNsYXVzZSwgYW5kIHRo ZSBDQVRDSCByZXR1cm5zLg0KDQpnZGIvQ2hhbmdlTG9nOg0KDQoJKiBpMzg2 LWxpbnV4LXRkZXAuYyAoaTM4Nl9saW51eF9oYW5kbGVfc2VnbWVudGF0aW9u X2ZhdWx0KToNCglJbml0aWFsaXplIHZhcmlhYmxlcy4NCi0tLQ0KIGdkYi9D aGFuZ2VMb2cgICAgICAgICB8IDUgKysrKysNCiBnZGIvaTM4Ni1saW51eC10 ZGVwLmMgfCAzICsrLQ0KIDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pDQoNCmRpZmYgLS1naXQgYS9nZGIvQ2hhbmdl TG9nIGIvZ2RiL0NoYW5nZUxvZyBpbmRleCBkYzEyMzk5Li4wMGFmMzk1IDEw MDY0NA0KLS0tIGEvZ2RiL0NoYW5nZUxvZw0KKysrIGIvZ2RiL0NoYW5nZUxv Zw0KQEAgLTEsMyArMSw4IEBADQorMjAxNi0wMi0yNSAgU2ltb24gTWFyY2hp ICA8c2ltb24ubWFyY2hpQGVyaWNzc29uLmNvbT4NCisNCisJKiBpMzg2LWxp bnV4LXRkZXAuYyAoaTM4Nl9saW51eF9oYW5kbGVfc2VnbWVudGF0aW9uX2Zh dWx0KToNCisJSW5pdGlhbGl6ZSB2YXJpYWJsZXMuDQorDQogMjAxNi0wMi0y NSAgQW50b2luZSBUcmVtYmxheSAgPGFudG9pbmUudHJlbWJsYXlAZXJpY3Nz b24uY29tPg0KIA0KIAkqIGF4LWdlbmVyYWwuYyAoYXhfcmVnKTogQ2FsbCBn ZGJhcmNoX3JlbW90ZV9yZWdpc3Rlcl9udW1iZXIuDQpkaWZmIC0tZ2l0IGEv Z2RiL2kzODYtbGludXgtdGRlcC5jIGIvZ2RiL2kzODYtbGludXgtdGRlcC5j IGluZGV4IDYzY2RhNDUuLjQyODc3ZGEgMTAwNjQ0DQotLS0gYS9nZGIvaTM4 Ni1saW51eC10ZGVwLmMNCisrKyBiL2dkYi9pMzg2LWxpbnV4LXRkZXAuYw0K QEAgLTM5Niw3ICszOTYsOCBAQCB2b2lkDQogaTM4Nl9saW51eF9oYW5kbGVf c2VnbWVudGF0aW9uX2ZhdWx0IChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwN CiAJCQkJICAgICAgc3RydWN0IHVpX291dCAqdWlvdXQpDQogew0KLSAgQ09S RV9BRERSIGxvd2VyX2JvdW5kLCB1cHBlcl9ib3VuZCwgYWNjZXNzOw0KKyAg LyogLVdtYXliZS11bmluaXRpYWxpemVkICAqLw0KKyAgQ09SRV9BRERSIGxv d2VyX2JvdW5kID0gMCwgdXBwZXJfYm91bmQgPSAwLCBhY2Nlc3MgPSAwOw0K ICAgaW50IGlzX3VwcGVyOw0KICAgbG9uZyBzaWdfY29kZSA9IDA7DQogDQot LQ0KMi41LjENCg0KSW50ZWwgRGV1dHNjaGxhbmQgR21iSApSZWdpc3RlcmVk IEFkZHJlc3M6IEFtIENhbXBlb24gMTAtMTIsIDg1NTc5IE5ldWJpYmVyZywg R2VybWFueQpUZWw6ICs0OSA4OSA5OSA4ODUzLTAsIHd3dy5pbnRlbC5kZQpN YW5hZ2luZyBEaXJlY3RvcnM6IENocmlzdGluIEVpc2Vuc2NobWlkLCBDaHJp c3RpYW4gTGFtcHJlY2h0ZXIKQ2hhaXJwZXJzb24gb2YgdGhlIFN1cGVydmlz b3J5IEJvYXJkOiBOaWNvbGUgTGF1ClJlZ2lzdGVyZWQgT2ZmaWNlOiBNdW5p Y2gKQ29tbWVyY2lhbCBSZWdpc3RlcjogQW10c2dlcmljaHQgTXVlbmNoZW4g SFJCIDE4NjkyOAo= >From gdb-patches-return-129921-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Feb 25 16:46:45 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 68075 invoked by alias); 25 Feb 2016 16:46:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 68058 invoked by uid 89); 25 Feb 2016 16:46:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=UD:addr_ipa_tdesc_idx, sk:write_i, UD:ipa_sym_addrs.addr_ipa_tdesc_idx, ipa_tdesc_idx X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Feb 2016 16:46:42 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 843C1C0E7223; Thu, 25 Feb 2016 16:46:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1PGkdD3017440; Thu, 25 Feb 2016 11:46:40 -0500 Message-ID: <56CF2FEF.3090407@redhat.com> Date: Thu, 25 Feb 2016 16:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= CC: gdb-patches@sourceware.org, antoine.tremblay@ericsson.com Subject: Re: [PATCH] [PR gdb/13808] gdb.trace: Pass tdesc selected in gdbserver to IPA. References: <56CF13A5.2020909@redhat.com> <1456414790-12228-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1456414790-12228-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-02/txt/msg00805.txt.bz2 Content-length: 369 On 02/25/2016 03:39 PM, Marcin Kościelnicki wrote: > > + /* Tell IPA about the correct tdesc. */ > + if (write_inferior_integer (ipa_sym_addrs.addr_ipa_tdesc_idx, > + target_get_ipa_tdesc_idx ())) > + { > + error ("Error setting ipa_tdesc_idx variable in lib"); > + } > + No {}s for single-line statement. Otherwise OK. Thanks, Pedro Alves