From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47968 invoked by alias); 13 Jan 2016 16:12:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47957 invoked by uid 89); 13 Jan 2016 16:12:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=commercial, Tel, office, Board X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Jan 2016 16:12:19 +0000 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 13 Jan 2016 08:12:07 -0800 X-ExtLoop1: 1 Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga004.fm.intel.com with ESMTP; 13 Jan 2016 08:12:05 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.92]) by IRSMSX153.ger.corp.intel.com ([169.254.9.170]) with mapi id 14.03.0248.002; Wed, 13 Jan 2016 16:12:05 +0000 From: "Tedeschi, Walfred" To: Eli Zaretskii CC: "brobecker@adacore.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH V3 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls. Date: Wed, 13 Jan 2016 16:12:00 -0000 Message-ID: References: <1452688799-15633-1-git-send-email-walfred.tedeschi@intel.com> <1452688799-15633-3-git-send-email-walfred.tedeschi@intel.com> <83lh7tihpw.fsf@gnu.org> In-Reply-To: <83lh7tihpw.fsf@gnu.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00261.txt.bz2 Eli, I will add those fixes. Thanks for your review! Best regards, -Fred -----Original Message----- From: Eli Zaretskii [mailto:eliz@gnu.org]=20 Sent: Wednesday, January 13, 2016 5:10 PM To: Tedeschi, Walfred Cc: brobecker@adacore.com; gdb-patches@sourceware.org Subject: Re: [PATCH V3 2/2] Add mpx-bnd-init-on-return set/show command for= inferior calls. > From: Walfred Tedeschi > Cc: gdb-patches@sourceware.org, Walfred Tedeschi=20 > > Date: Wed, 13 Jan 2016 13:39:59 +0100 >=20 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,10 @@ >=20=20 > *** Changes since GDB 7.10 >=20=20 > +* show mpx-bnd-init-on-return > + set mpx-bnd-init-on-return on i386 and amd64 > + Support for set bound registers to INIT state when using the command = return. Please quote "return" in the last sentence. > +While the using the @command{return} bounds can propagate through ^^^ This "the" should be deleted. Also, @command is for external commands, not= GDB commands. > +execution causing a boundary violation. Hmm... "propagate through execution" is not really clear. How about simpli= fying this, like below? When you use the @code{return} command, the bound registers might cause boundary violations because they were not updated for the early return from the function. > +The behaviour of initializing bounds when using @command{return} can=20 > +be controlled and vizualized via the following commands: I think we should explain how initializing these registers comes into play.= Like this, for example: To countermand that, @value{GDBN} can force initialization of the bound registers when it performs the @code{return} command. This is controlled by the following option: The documentation parts are OK with these fixes. Thanks. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928