From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15233 invoked by alias); 10 Jun 2015 12:51:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15063 invoked by uid 89); 10 Jun 2015 12:51:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jun 2015 12:51:34 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 10 Jun 2015 05:45:51 -0700 X-ExtLoop1: 1 Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 10 Jun 2015 05:45:50 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.36]) by irsmsx105.ger.corp.intel.com ([169.254.7.73]) with mapi id 14.03.0224.002; Wed, 10 Jun 2015 13:45:49 +0100 From: "Tedeschi, Walfred" To: "brobecker@adacore.com" , "eliz@gnu.org" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 1/1] Fix broken GDB build after adding Bound table support for i386. Date: Wed, 10 Jun 2015 12:51:00 -0000 Message-ID: References: <1433940196-22975-1-git-send-email-walfred.tedeschi@intel.com> In-Reply-To: <1433940196-22975-1-git-send-email-walfred.tedeschi@intel.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00179.txt.bz2 Eli and Joel, This should (I tested in one 32bit system Ubuntu 12.04) and could run make = and make install. Testes are still passing as before. Thanks and regards, -Fred =20 -----Original Message----- From: Tedeschi, Walfred=20 Sent: Wednesday, June 10, 2015 2:43 PM To: brobecker@adacore.com; eliz@gnu.org Cc: gdb-patches@sourceware.org; Tedeschi, Walfred Subject: [PATCH 1/1] Fix broken GDB build after adding Bound table support = for i386. Types used for some variables could not be used for 32 bits. This patch changes uses larger types to accommodate the biggest integer pos= sible. Documentation was also affected, once a different version of texinfo the do= cs could not be build. 2015-06-10 Walfred Tedeschi * i386-tdep.c (i386_mpx_get_bt_entry): Exchange CORE_ADDR by ULONGEST. doc: gdb.textinfo (i386): Fix "@end table" end and "@table" placement. --- gdb/doc/gdb.texinfo | 2 ++ gdb/i386-tdep.c | 14 +++++++------- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 9e9138b..8b4cb= 88 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -22127,6 +22127,7 @@ be returned in a register. @kindex show struct-convention Show the current setting of the convention to return @code{struct}s from = functions. +@end table =20 =20 @subsubsection Intel(R) @dfn{Memory Protection Extensions} (MPX). @@ -22168,6 +22169,7 @@ the bounds pointer's value along with its bounds. = Evaluating and changing bounds located in bound tables is therefore intere= sting while investigating bugs on MPX context. @value{GDBN} provides comm= ands for this purpose: =20 +@table @code @item show mpx bound @var{pointer} @kindex show mpx bound Display bounds of the given @var{pointer}. diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index 6304591..7de9792 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -8665,13 +8665,13 @@ i386_mpx_enabled (void) static CORE_ADDR i386_mpx= _get_bt_entry (CORE_ADDR ptr, CORE_ADDR bd_base) { - CORE_ADDR offset1; - CORE_ADDR offset2; - CORE_ADDR mpx_bd_mask, bd_ptr_r_shift, bd_ptr_l_shift; - CORE_ADDR bt_mask, bt_select_r_shift, bt_select_l_shift; - CORE_ADDR bd_entry_addr; - CORE_ADDR bt_addr; - CORE_ADDR bd_entry; + ULONGEST offset1; + ULONGEST offset2; + ULONGEST mpx_bd_mask, bd_ptr_r_shift, bd_ptr_l_shift; ULONGEST=20 + bt_mask, bt_select_r_shift, bt_select_l_shift; ULONGEST=20 + bd_entry_addr; ULONGEST bt_addr; ULONGEST bd_entry; struct gdbarch *gdbarch =3D get_current_arch (); struct type *data_ptr_type =3D builtin_type (gdbarch)->builtin_data_ptr; =20 -- 2.1.4 Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052