From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4275 invoked by alias); 10 Jun 2015 08:37:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4266 invoked by uid 89); 10 Jun 2015 08:37:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jun 2015 08:37:06 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 10 Jun 2015 01:37:04 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 10 Jun 2015 01:37:04 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.36]) by IRSMSX103.ger.corp.intel.com ([169.254.3.215]) with mapi id 14.03.0224.002; Wed, 10 Jun 2015 09:37:03 +0100 From: "Tedeschi, Walfred" To: Joel Brobecker CC: "eliz@gnu.org" , "gdb-patches@sourceware.org" Subject: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context. Date: Wed, 10 Jun 2015 08:37:00 -0000 Message-ID: Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00166.txt.bz2 Joel, I followed your suggestion and pushed as considering that the rest was ok. Hope this is fine. Joel and Eli, Thanks a lot for your review and valuable feedback! Best regards, -Fred -----Original Message----- From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware= .org] On Behalf Of Joel Brobecker Sent: Tuesday, June 09, 2015 6:26 PM To: Tedeschi, Walfred Cc: eliz@gnu.org; gdb-patches@sourceware.org Subject: Re: [PATCH V4] Add support for bound table in the Intel MPX contex= t. > 2015-04-20 Walfred Tedeschi > Mircea Gherzan >=20 > * i386-tdep.c (MPX_BASE_MASK, MPX_BD_MASK, MPX_BT_MASK, MPX_BD_MASK_32, > MPX_BT_MASK_32): New macros. > (i386_mpx_set_bounds): New function that implements > the command "set-mpx-bound". > (i386_mpx_enabled) Helper function to test MPX availability. > (i386_mpx_bd_base) Helper function to calculate the base directory > address. (i386_mpx_get_bt_entry) Helper function to access a bound > table entry. (i386_mpx_print_bounds) Effectively display bound > information. (_initialize_i386_tdep): Qdd new commands > to commands "set mpx" and "show mpx". (_initialize_i386_tdep): > Add "bound" to the commands "show mpx" and "set mpx" commands. > (mpx_set_cmdlist and mpx_show_cmdlist): > list for the new prefixed "set mpx" and "show mpx" commands. > * NEWS: List new commands for MPX support. >=20 > testsuite: >=20 > * gdb.arch/i386-mpx-map.c: New file. > * gdb.arch/i386-mpx-map.exp: New File. >=20 > doc: > * gdb.texinfo (i386): Add documentation about "show mpx bound" > and "set mpx bound". > +/* Print routine for the mpx bounds. */ > + > +static void > +i386_mpx_print_bounds (const CORE_ADDR bt_entry[]) I don't think we've been using the [] syntax for parameters, but I don't se= e a problem with that per se. What I'm wondering, however, is the size of the array. In particular, you'l= l need, at least, to update the documentation. But if the size is actually = statically known (which it seems is at most 4 elements), then perhaps it mi= ght be worth just saying it in the parameter type declaration... Other than that, the patch looks good to me. -- Joel Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052