From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10096 invoked by alias); 24 Nov 2014 13:48:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9960 invoked by uid 89); 24 Nov 2014 13:48:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Nov 2014 13:48:26 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 24 Nov 2014 05:46:01 -0800 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga001.jf.intel.com with ESMTP; 24 Nov 2014 05:48:19 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.209]) by IRSMSX101.ger.corp.intel.com ([169.254.1.105]) with mapi id 14.03.0195.001; Mon, 24 Nov 2014 13:48:18 +0000 From: "Tedeschi, Walfred" To: Joel Brobecker CC: "palves@redhat.com" , "mark.kettenis@xs4all.nl" , "gdb-patches@sourceware.org" Subject: RE: [PATCH] Fix MPX and AVX512 tests for path changes. Date: Mon, 24 Nov 2014 13:48:00 -0000 Message-ID: References: <1412062097-22417-1-git-send-email-walfred.tedeschi@intel.com> <20141123034212.GB5774@adacore.com> In-Reply-To: <20141123034212.GB5774@adacore.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00602.txt.bz2 Hello Joel, Thanks a lot for your review! Ok! I will proceed as you proposed! Best regards, -Fred -----Original Message----- From: Joel Brobecker [mailto:brobecker@adacore.com]=20 Sent: Sunday, November 23, 2014 4:42 AM To: Tedeschi, Walfred Cc: palves@redhat.com; mark.kettenis@xs4all.nl; gdb-patches@sourceware.org Subject: Re: [PATCH] Fix MPX and AVX512 tests for path changes. Hello Walfred, On Tue, Sep 30, 2014 at 09:28:17AM +0200, Walfred Tedeschi wrote: > Changes on the path for i386-cpuid.h file lead to failure in compiling=20 > tests for MPX and AVX512. Conformity between both tests is also=20 > addressed with this path. >=20 > 2014-08-12 Walfred Tedeschi >=20 > gdb/testsuite > * gdb.arch/i386-avx512.c: Change path in include file. > * gdb.arch/i386-mpx.c: Change path in include file. > * gdb.arch/i386-avx512.exp: Change include dir path > compilation flag. > * gdb.arch/i386-mpx.exp: Change include dir path > compilation flag. Overall, the changes look good. But would you mind please splitting this pa= tch into individual pieces. For instance, one patch to fix i386-avx512.exp'= s build failure, one patch to fix i386-mpx.exp's build failure, and then as= many individual patches for the other changes made for "conformity between= both tests". I am 300 patches behind on review and trying to spend this we= ekend catching up a bit, so a more detailed explanation will help me, as we= ll as anyone going back in time trying to figure out why some changes were = made. Thank you! -- Joel Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052