RE: [PATCH V7 0/8] Intel(R) MPX register support

["Tedeschi, Walfred" <walfred.tedeschi@intel.com>]

Hello Mark,

In fact this small diff was only intended to be reviewed, changes for that are already spread among the other commits.

So I am going to commit everything except documentation, Pedro did some comments on that today.

THANKS A LOT!!!

Regards,
-Fred

-----Original Message-----
From: Mark Kettenis [mailto:mark.kettenis@xs4all.nl] 
Sent: Tuesday, November 19, 2013 11:28 AM
To: Tedeschi, Walfred
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH V7 0/8] Intel(R) MPX register support

> From: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
> Date: Tue, 19 Nov 2013 08:31:19 +0000
> 
> Hello Mark,
> 
> Do you agree with this diff? Of course I will distribute it where it belongs to in the patch.
> 
> Thanks a lot for your support and best regards, -Fred

Sorry, thought I already replied to your message.

It's not enitrely clear to me why MPX for x32 can't work, but since I don't particularly care about x32 (and even think it's a silly idea and its implementation on Linux is actually broken) I'm not going to let that stand in the way of getting this stuff in.

I also think that this whole splitting up of diffs is going too far.
Why don't you just squash this one together with all the other ones and commit them in one go?

Cheers,

Mark

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org 
> [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Walfred 
> Tedeschi
> Sent: Monday, November 11, 2013 11:53 AM
> To: Mark Kettenis; gdb-patches@sourceware.org
> Subject: Re: [PATCH V7 0/8] Intel(R) MPX register support
> 
> Hi Mark,
> 
> What I mean is the appended patch. This is what I added on top of v7.
> 
> 1. It removes MPX support for x32.
> 2. Improves i386-xstate.h macros. (identation was weird) 3. Fix the 
> regression on MPX initialization on i386-tdep.c
> 
> I considered that to be easy to review than having all the patch series again.
> :)
> 
> Thanks a lot!
> 
> Best regards,
> -Fred
> 
> 
> Am 11/11/2013 11:08 AM, schrieb Mark Kettenis:
> >> From: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
> >> Date: Mon, 11 Nov 2013 08:15:36 +0000
> >>
> >> Hello Mark,
> >>
> >> I am not sure I got it right. Is this a ok to commit?
> > Pretty much.
> >
> >> If so, I still would like to do some changes before proceeding.
> >> Basically I want to remove the x32 support since it makes no sense 
> >> and a regression I caused.  Those changes where mentioned here:
> >> https://sourceware.org/ml/gdb-patches/2013-10/msg00513.html
> > I'll await your patch then ;).
> >
> >> To avoid sending you a full patch again my Idea is to send an 
> >> ad-hoc patch to be added on top of my V7.  While doing the commit 
> >> then I would join then on the respective place.
> > Not sure what you mean by that.  As long as all the intermediate 
> > states compile and you don't introduce regressions for non-MPX 
> > support, this should be fine.
> 
> Intel GmbH
> Dornacher Strasse 1
> 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: 
> Feldkirchen bei Muenchen
> Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas 
> Lusk
> Registergericht: Muenchen HRB 47456
> Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. 
> (BLZ 502 109 00) 600119052 Intel GmbH Dornacher Strasse 1
> 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: 
> Feldkirchen bei Muenchen
> Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas 
> Lusk
> Registergericht: Muenchen HRB 47456
> Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. 
> (BLZ 502 109 00) 600119052
> 
> 
> 
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052