From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19807 invoked by alias); 23 Sep 2013 13:33:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19794 invoked by uid 89); 23 Sep 2013 13:33:42 -0000 Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Sep 2013 13:33:42 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mga02.intel.com Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 23 Sep 2013 06:33:39 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga002.jf.intel.com with ESMTP; 23 Sep 2013 06:33:38 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.69]) by IRSMSX103.ger.corp.intel.com ([163.33.3.157]) with mapi id 14.03.0123.003; Mon, 23 Sep 2013 14:33:38 +0100 From: "Tedeschi, Walfred" To: "Jose E. Marchesi" , "gdb-patches@sourceware.org" Subject: RE: [PATCH][SPARC64] Fix breakpointing in syscalls other than sigreturn Date: Mon, 23 Sep 2013 13:33:00 -0000 Message-ID: References: <87ioxradrb.fsf@oracle.com> In-Reply-To: <87ioxradrb.fsf@oracle.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00818.txt.bz2 Hi Jose, Have you observed some failure to submit this patch? If so could you also p= rovide a test case? Regards, -Fred -----Original Message----- From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware= .org] On Behalf Of Jose E. Marchesi Sent: Monday, September 23, 2013 3:07 PM To: gdb-patches@sourceware.org Subject: [PATCH][SPARC64] Fix breakpointing in syscalls other than sigreturn ping. Could someone please take a look to this patch? Thanks. From: jose.marchesi@oracle.com (Jose E. Marchesi) To: gdb-patches@sourceware.org Subject: [PATCH][SPARC64] Fix breakpointing in syscalls other than sigreturn Date: Tue, 10 Sep 2013 20:29:33 +0200 Hi. This small patch makes sparc64_linux_step_trap to return 0 when a breakpoin= t is set in a `ta 0x6d' which is not a sigreturn syscall. In these cases n= o rt_frame exists in the stack and thus the read PC is wrong. 2013-09-10 Jose E. Marchesi * sparc64-linux-tdep.c (sparc64_linux_step_trap): Make sure the trap is a sigreturn syscall. Index: gdb/sparc64-linux-tdep.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/sparc64-linux-tdep.c,v retrieving revision 1.31 diff -u -r1.31 sparc64-linux-tdep.c --- gdb/sparc64-linux-tdep.c 1 Jan 2013 06:32:51 -0000 1.31 +++ gdb/sparc64-linux-tdep.c 10 Sep 2013 18:17:25 -0000 @@ -111,7 +111,9 @@ static CORE_ADDR sparc64_linux_step_trap (struct frame_info *frame, unsigned long insn) { - if (insn =3D=3D 0x91d0206d) + /* __NR_rt_sigreturn is 101 */ + if ((insn =3D=3D 0x91d0206d) + && (get_frame_register_unsigned (frame, SPARC_G1_REGNUM) =3D=3D 101)) { struct gdbarch *gdbarch =3D get_frame_arch (frame); enum bfd_endian byte_order =3D gdbarch_byte_order (gdbarch); Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052