From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74306 invoked by alias); 4 Mar 2019 13:57:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74294 invoked by uid 89); 4 Mar 2019 13:57:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=significantly X-HELO: EUR04-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr70073.outbound.protection.outlook.com (HELO EUR04-HE1-obe.outbound.protection.outlook.com) (40.107.7.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Mar 2019 13:57:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AiIBoEqelhkuWb/Ff41uq4QreftLGboholO8hAlG/ME=; b=Evlxpeg/vqXhvMxeL8jK0hrjrElvaOH8qeSNOt/PYY1C01Tqrt41N8rFR8yXvkSx0xYXQbB7Ka4fCLQLbQHVoqUyXHqLUPg7jHGdLg0JbdzPzYOI6DKHl9Dppy0x0D6CetXV8jGl2MnCemIKjLCYBaiTG9vasIsoDOIzcVSGQfw= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2198.eurprd08.prod.outlook.com (10.172.227.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.18; Mon, 4 Mar 2019 13:57:49 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7%3]) with mapi id 15.20.1665.020; Mon, 4 Mar 2019 13:57:49 +0000 From: Alan Hayward To: Andrew Burgess CC: Jim Wilson , Joel Brobecker , GDB Patches , nd Subject: Re: GDB 8.2.90 available for testing Date: Mon, 04 Mar 2019 13:57:00 -0000 Message-ID: References: <20190227055112.4A5E782D7B@joel.gnat.com> <332e186f-0c04-ab6d-754e-bf14d2981923@sifive.com> <20190304111454.GV10887@embecosm.com> In-Reply-To: <20190304111454.GV10887@embecosm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="us-ascii" Content-ID: <3AA8E1B632256B4D907D9C717AF116B7@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00027.txt.bz2 > On 4 Mar 2019, at 11:14, Andrew Burgess wro= te: >=20 > * Jim Wilson [2019-02-27 14:05:23 -0800]: >=20 >> On 2/26/19 9:51 PM, Joel Brobecker wrote: >>> I have just finished creating the gdb-8.2.90 pre-release. >>> Please give it a test if you can and report any problems you might find. >>=20 >> On a riscv64-linux system (HiFive Unleashed w/ Fedora Core 29), without = an >> Ada compiler in my path, I get >>=20 >> =3D=3D=3D gdb Summary =3D=3D=3D >>=20 >> # of expected passes 50264 >> # of unexpected failures 2297 >> # of expected failures 57 >> # of unknown successes 3 >> # of known failures 79 >> # of untested testcases 132 >> # of unresolved testcases 110 >> # of unsupported tests 359 >>=20 >> which looks OK. There was no riscv-linux native support in gdb-8.2 so t= his >> is a major improvement over the last one. I did used to have better res= ults >> though. I'm seeing >>=20 >> hifiveu017:1040$ grep ^FAIL gdb.sum | grep infcall | wc >> 878 8059 103059 >>=20 >> and I think that these mostly used to work, since I used to have about 1= 500 >> failures. I think something in the last 3 months broke this, but I have= n't >> had time to track it down. I see stuff like this in the log files >>=20 >> p/d check_arg_struct_01_01 (ref_val_struct_01_01)^M >> ../../binutils-gdb/gdb/riscv-tdep.c:2119: internal-error: void >> riscv_call_arg_struct(riscv_arg_info*, riscv_call_info*): Assertion >> `TYPE_LENGTH (ainfo->type) =3D=3D TYPE_LENGTH (sinfo.field_type (0))' fa= iled.^M >> A problem internal to GDB has been detected,^M >> further debugging may prove unreliable.^M >> Quit this debugging session? (y or n) FAIL: >> gdb.base/infcall-nested-structs.exp: l=3Dc++: types-tfc: p/d >> check_arg_struct_01_01 (ref_val_struct_01_01) (GDB internal error) >=20 > I don't think these are regressions, just new tests that expose a bug > that was present since the initial upstreaming. The issue relates to > the difference in size between an empty struct in gcc and g++ (0 vs 1 > respectively), and how this effects argument passing. I can confirm that for infcall-nested-structs.exp - I expanded that test fa= irly significantly. You're probably running into all the same issues I fixed for AArch64. There are some parts that fail for X86_64 too. >=20 > I have a fix in progress, but it will probably be a couple of days > before its ready to post. I guess we can back-port to 8.3 if I get > the patch ready soon. I'm not too worried if it doesn't make it in > though, if feels like an edge case. >=20 > Thanks, > Andrew