Re: [PATCH] fix build failure for win64, revise some format strings

Tom Tromey
2010-07-16T15:36:10Z

>>>>> "Ozkan" == Ozkan Sezer <sezeroz@gmail.com> writes:

Ozkan> PING
Ozkan> Can someone please review this patch? (Win64 fails to build for a week.)

Sorry about that. I was hoping someone else would do this ;-)

Thanks for pinging.

I think it would be better to change those places to use
host_address_to_string. E.g., change from:

fprintf_unfiltered (gdb_stdlog,
"target_insert_breakpoint (0x%lx, xxx) = %ld\n",
(unsigned long) bp_tgt->placed_address,
(unsigned long) retval);

to

fprintf_unfiltered (gdb_stdlog,
"target_insert_breakpoint (%s, xxx) = %ld\n",
host_address_to_string (bp_tgt->placed_address),
(unsigned long) retval);

This lets us avoid dealing with the gnulib changes, etc.

Tom