From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19209 invoked by alias); 17 Feb 2011 15:49:29 -0000 Received: (qmail 19192 invoked by uid 22791); 17 Feb 2011 15:49:28 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gx0-f169.google.com (HELO mail-gx0-f169.google.com) (209.85.161.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Feb 2011 15:49:20 +0000 Received: by gxk5 with SMTP id 5so1147045gxk.0 for ; Thu, 17 Feb 2011 07:49:19 -0800 (PST) Received: by 10.147.124.1 with SMTP id b1mr3052108yan.22.1297957758941; Thu, 17 Feb 2011 07:49:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.147.114.12 with HTTP; Thu, 17 Feb 2011 07:48:58 -0800 (PST) In-Reply-To: References: From: Hui Zhu Date: Thu, 17 Feb 2011 16:20:00 -0000 Message-ID: Subject: Re: [PATCH] tracepoint: add new trace command "printf"[3] doc To: Eli Zaretskii Cc: tromey@redhat.com, gdb-patches@sourceware.org, dje@google.com, stan@codesourcery.com, msnyder@vmware.com Content-Type: multipart/mixed; boundary=20cf305644b127bd3e049c7c5777 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00423.txt.bz2 --20cf305644b127bd3e049c7c5777 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2019 On Thu, Feb 17, 2011 at 19:41, Eli Zaretskii wrote: >> From: Hui Zhu >> Date: Thu, 17 Feb 2011 16:13:11 +0800 >> Cc: Doug Evans , Stan Shebs , >> =A0 =A0 =A0 Michael Snyder >> >> This is the patch for the doc for the tracepoint command printf and >> agent op printf. > > Thanks. > >> +Print the values in the stack under the control of the string template. > > "on the stack", not "in". > > Also, you say "values" here, but the rest of the description talks > about one value at most. =A0Which one is right? > > I would remove "the" before "control". > > Finally, "template" should be in @var. > >> +The end of @var{template} is 0x00. > > Not clear what you mean here. =A0Do you mean that "template" is a > null-terminated string? > >> +If @var{n} is 0, just output the string template. >> +If @var{n} is 1, pop a value from the stack and print it under the cont= rol >> +of the string template. > > Same comments as above: remove "the" before "control" and put > "template" in @var. > >> +@kindex printf > > We already have one such @kindex entry. =A0Please change this one to > > =A0@kindex printf, in tracepoint actions > >> +@item printf @var{template}, @var{expressions}@dots{} >> +Print the values of one or more @var{expressions} under the control of > > "under control", without "the". > >> +the string @var{template} in @code{gdbserver} part. > > I don't understand what do you mean by "in @code{gdbserver} part". > >> +The command format is with simple @code{printf} (@pxref{Output, printf}= ). > > Please rephrase as > > =A0@var{template} is a format string of the same form as used with the > =A0@value{GDBN} command @code{printf} (@pxref{Output, printf}). > > Thanks. > Thanks for your help, Eli. I make a new patch according to your comments. Best, Hui 2011-02-17 Hui Zhu * agentexpr.texi (Bytecode Descriptions): Add printf. * gdb.texinfo (Tracepoint Action Lists): Add printf. --20cf305644b127bd3e049c7c5777 Content-Type: text/plain; charset=US-ASCII; name="tp_print_doc.txt" Content-Disposition: attachment; filename="tp_print_doc.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gk9uigyf0 Content-length: 2091 LS0tCiBkb2MvYWdlbnRleHByLnRleGkgfCAgICA3ICsrKysrKysKIGRvYy9n ZGIudGV4aW5mbyAgICB8ICAgIDcgKysrKysrKwogMiBmaWxlcyBjaGFuZ2Vk LCAxNCBpbnNlcnRpb25zKCspCgotLS0gYS9kb2MvYWdlbnRleHByLnRleGkK KysrIGIvZG9jL2FnZW50ZXhwci50ZXhpCkBAIC00NzksNiArNDc5LDEzIEBA IG5hbWVkIEBjb2Rle3RyYWNlX3F1aWNrMTZ9LCBmb3IgY29uc2lzdGUKIFJl Y29yZCB0aGUgdmFsdWUgb2YgdHJhY2Ugc3RhdGUgdmFyaWFibGUgbnVtYmVy IEB2YXJ7bn0gaW4gdGhlIHRyYWNlCiBidWZmZXIuICBUaGUgaGFuZGxpbmcg b2YgQHZhcntufSBpcyBhcyBkZXNjcmliZWQgZm9yIEBjb2Rle2dldHZ9Lgog CitAaXRlbSBAY29kZXtwcmludGZ9ICgweDMxKSBAdmFye259IEB2YXJ7dGVt cGxhdGV9OiBAcmVzdWx0e30KK1ByaW50IGEgdmFsdWUgb24gdGhlIHN0YWNr IHVuZGVyIGNvbnRyb2wgb2YgdGhlIHN0cmluZyBAdmFye3RlbXBsYXRlfS4K K0B2YXJ7dGVtcGxhdGV9IGlzIGEgbnVsbC10ZXJtaW5hdGVkIHN0cmluZy4K K0lmIEB2YXJ7bn0gaXMgMCwganVzdCBvdXRwdXQgdGhlIHN0cmluZyB0ZW1w bGF0ZS4KK0lmIEB2YXJ7bn0gaXMgMSwgcG9wIGEgdmFsdWUgZnJvbSB0aGUg c3RhY2sgYW5kIHByaW50IGl0IHVuZGVyIGNvbnRyb2wKK29mIHRoZSBzdHJp bmcgQHZhcnt0ZW1wbGF0ZX0uCisKIEBpdGVtIEBjb2Rle2VuZH0gKDB4Mjcp OiBAcmVzdWx0e30KIFN0b3AgZXhlY3V0aW5nIGJ5dGVjb2RlOyB0aGUgcmVz dWx0IHNob3VsZCBiZSB0aGUgdG9wIGVsZW1lbnQgb2YgdGhlCiBzdGFjay4g IElmIHRoZSBwdXJwb3NlIG9mIHRoZSBleHByZXNzaW9uIHdhcyB0byBjb21w dXRlIGFuIGx2YWx1ZSBvciBhCi0tLSBhL2RvYy9nZGIudGV4aW5mbworKysg Yi9kb2MvZ2RiLnRleGluZm8KQEAgLTEwMjQyLDYgKzEwMjQyLDEzIEBAIHN0 YXRlIHZhcmlhYmxlcyAoQHB4cmVme1RyYWNlIFN0YXRlIFZhcmkKIHZhbHVl cyB0byB0aGUgdHJhY2UgYnVmZmVyLCBhcyB3b3VsZCBiZSB0aGUgY2FzZSBp ZiB0aGUgQGNvZGV7Y29sbGVjdH0KIGFjdGlvbiB3ZXJlIHVzZWQuCiAKK0Br aW5kZXggcHJpbnRmLCBpbiB0cmFjZXBvaW50IGFjdGlvbnMKK0BpdGVtIHBy aW50ZiBAdmFye3RlbXBsYXRlfSwgQHZhcntleHByZXNzaW9uc31AZG90c3t9 CitQcmludCB0aGUgdmFsdWVzIG9mIG9uZSBvciBtb3JlIEB2YXJ7ZXhwcmVz c2lvbnN9IHVuZGVyIGNvbnRyb2wgb2YKK3RoZSBzdHJpbmcgQHZhcnt0ZW1w bGF0ZX0uCitAdmFye3RlbXBsYXRlfSBpcyBhIGZvcm1hdCBzdHJpbmcgb2Yg dGhlIHNhbWUgZm9ybSBhcyB1c2VkIHdpdGggdGhlCitAdmFsdWV7R0RCTn0g Y29tbWFuZCBAY29kZXtwcmludGZ9IChAcHhyZWZ7T3V0cHV0LCBwcmludGZ9 KS4KKwogQGtpbmRleCB3aGlsZS1zdGVwcGluZyBAcnsodHJhY2Vwb2ludHMp fQogQGl0ZW0gd2hpbGUtc3RlcHBpbmcgQHZhcntufQogUGVyZm9ybSBAdmFy e259IHNpbmdsZS1zdGVwIGluc3RydWN0aW9uIHRyYWNlcyBhZnRlciB0aGUg dHJhY2Vwb2ludCwK --20cf305644b127bd3e049c7c5777--