From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2736 invoked by alias); 4 Jun 2010 02:44:10 -0000 Received: (qmail 2606 invoked by uid 22791); 4 Jun 2010 02:44:09 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-pv0-f169.google.com (HELO mail-pv0-f169.google.com) (74.125.83.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jun 2010 02:44:02 +0000 Received: by pva18 with SMTP id 18so924977pva.0 for ; Thu, 03 Jun 2010 19:44:01 -0700 (PDT) Received: by 10.142.55.13 with SMTP id d13mr7587057wfa.198.1275619441089; Thu, 03 Jun 2010 19:44:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.57.15 with HTTP; Thu, 3 Jun 2010 19:43:41 -0700 (PDT) From: Hui Zhu Date: Fri, 04 Jun 2010 02:44:00 -0000 Message-ID: Subject: [OB] dwarf2loc.c: fix read_sleb128 use ULONGEST To: gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00112.txt.bz2 Hi, Got some error with this file: gcc -g -O2 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib -Ignulib -DMI_OUT=1 -DTUI=1 -DGDBTK -I/usr/include -I/usr/include -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Werror -c -o dwarf2loc.o -MT dwarf2loc.o -MMD -MP -MF .deps/dwarf2loc.Tpo ../../src/gdb/dwarf2loc.c cc1: warnings being treated as errors ../../src/gdb/dwarf2loc.c: In function 'locexpr_describe_location_1': ../../src/gdb/dwarf2loc.c:1476: warning: 'l' may be used uninitialized in this function ../../src/gdb/dwarf2loc.c:1476: note: 'l' was declared here make[2]: *** [dwarf2loc.o] Error 1 This because: data = read_sleb128 (data, end, &ul); //use ul fprintf_filtered (stream, " %s", plongest (l)); //use l read_sleb128 (const gdb_byte *buf, const gdb_byte *buf_end, LONGEST * r) So change first line to l. Thanks, Hui 2010-06-04 Hui Zhu * dwarf2loc.c (disassemble_dwarf_expression): Change ul to l. =================================================================== RCS file: /cvs/src/src/gdb/dwarf2loc.c,v retrieving revision 1.85 retrieving revision 1.86 diff -u -r1.85 -r1.86 --- src/gdb/dwarf2loc.c 2010/06/02 19:37:55 1.85 +++ src/gdb/dwarf2loc.c 2010/06/04 02:39:16 1.86 @@ -1536,7 +1536,7 @@ fprintf_filtered (stream, " %s", pulongest (ul)); break; case DW_OP_consts: - data = read_sleb128 (data, end, &ul); + data = read_sleb128 (data, end, &l); fprintf_filtered (stream, " %s", plongest (l)); break;