From: Doug Evans <dje@google.com>
To: Pedro Alves <pedro@codesourcery.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] regression: Fix in-tree build [Re: [patch] Create general staging area for data-directory files.]
Date: Thu, 07 Oct 2010 00:21:00 -0000 [thread overview]
Message-ID: <AANLkTinQArAEYGJZqX4y5pOsVticFO=Up6ohF8AK4aoh@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimOoRNqPUc-RjNGgKeVic16goBbehmAcG9iRGak@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On Wed, Oct 6, 2010 at 5:01 PM, Doug Evans <dje@google.com> wrote:
> On Wed, Oct 6, 2010 at 4:33 PM, Pedro Alves <pedro@codesourcery.com> wrote:
>> On Thursday 07 October 2010 00:24:15, Jan Kratochvil wrote:
>>> On Tue, 05 Oct 2010 02:18:19 +0200, Doug Evans wrote:
>>> > --- /dev/null 2010-09-23 16:28:04.543730915 -0700
>>> > +++ data-directory/Makefile.in 2010-10-04 16:56:01.000000000 -0700
>>> > +Makefile: $(srcdir)/Makefile.in $(top_builddir)/config.status @frags@
>>> > + cd $(top_builddir) && $(MAKE) data-directory/Makefile
>>>
>>
>> Does this need to depend on @frags@ in the first place?
>
> Yeah, I think that's the right solution.
>
I have checked this in.
2010-10-06 Doug Evans <dje@google.com>
* data-directory/Makefile.in: Remove @host_makefile_frag@, @frags@.
[-- Attachment #2: gdb-101006-data-dir-frags-1.patch.txt --]
[-- Type: text/plain, Size: 967 bytes --]
2010-10-06 Doug Evans <dje@google.com>
* data-directory/Makefile.in: Remove @host_makefile_frag@, @frags@.
Index: data-directory/Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/data-directory/Makefile.in,v
retrieving revision 1.1
diff -u -p -r1.1 Makefile.in
--- data-directory/Makefile.in 6 Oct 2010 16:02:44 -0000 1.1
+++ data-directory/Makefile.in 7 Oct 2010 00:16:41 -0000
@@ -53,10 +53,6 @@ PYTHON_INSTALL_DIR = $(DESTDIR)/$(GDB_DA
PYTHON_FILES = \
gdb/__init__.py
-# Host-dependent makefile fragment comes in here.
-@host_makefile_frag@
-# End of host-dependent makefile fragment
-
.PHONY: all
all: stamp-syscalls stamp-python
@@ -182,5 +178,5 @@ clean-info:
# will remove them.
MAKEOVERRIDES=
-Makefile: $(srcdir)/Makefile.in $(top_builddir)/config.status @frags@
+Makefile: $(srcdir)/Makefile.in $(top_builddir)/config.status
cd $(top_builddir) && $(MAKE) data-directory/Makefile
prev parent reply other threads:[~2010-10-07 0:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 0:18 [patch] Create general staging area for data-directory files Doug Evans
2010-10-06 23:24 ` [patch] regression: Fix in-tree build [Re: [patch] Create general staging area for data-directory files.] Jan Kratochvil
2010-10-06 23:34 ` Pedro Alves
2010-10-07 0:05 ` Doug Evans
2010-10-07 0:21 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinQArAEYGJZqX4y5pOsVticFO=Up6ohF8AK4aoh@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox