From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27536 invoked by alias); 28 Mar 2011 09:03:32 -0000 Received: (qmail 27526 invoked by uid 22791); 28 Mar 2011 09:03:31 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_BJ,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Mar 2011 09:03:27 +0000 Received: by vws4 with SMTP id 4so2706787vws.0 for ; Mon, 28 Mar 2011 02:03:26 -0700 (PDT) Received: by 10.52.98.166 with SMTP id ej6mr4904433vdb.72.1301303006365; Mon, 28 Mar 2011 02:03:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.200.3 with HTTP; Mon, 28 Mar 2011 02:03:06 -0700 (PDT) In-Reply-To: References: From: Kevin Pouget Date: Mon, 28 Mar 2011 10:02:00 -0000 Message-ID: Subject: Re: [RFC - Python] New ObjFile event To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01122.txt.bz2 > I'm not sure on the status of 8.3 file naming conventions, whether they > matter anymore. I would say no, because python/py-threadevent.c already exists :) >> +/*static*/ struct objfile *gdbpy_current_objfile; > I realize this is something you are unsure of, but if you decide to emit > 'static' can you remove the comment too. sure, I let the 'static' in comments to highlight that I don't really want to do, this will be cleanup as soon as I get a better solution > + gdbpy_initialize_new_objfile_event() ; > Needs a space after event and before the bracket. done >> Copyright (C) 2009, 2010, 2011 Free Software Foundation, Inc. > Just 2011 here. done > Oops forgot to mention, this patch is missing tests, documentation and a > ChangeLog entry. I realize this was/is an RFC, but the tests help > "prove" the patch for maintainers. Looking good, though! I didn't know about it, I'll prepare it today Thanks for your advises, Kevin On Mon, Mar 28, 2011 at 4:54 AM, Phil Muldoon wrote: > Kevin Pouget writes: > >> Hello, >> >> following this discussion at >> http://sourceware.org/ml/gdb/2011-03/msg00136.html, I would like to >> suggest a patch for the Python event system. Based on the ''exited", >> "cont", ... events, this patch allows a python script to register an >> interest to the loading of new object files in the debuggee. GDB >> observer "observer_attach_new_objfile" is used to trigger the Python >> callback. >> >> This patch completes the auto-loading feature > > Oops forgot to mention, this patch is missing tests, documentation and a > ChangeLog entry. =A0I realize this was/is an RFC, but the tests help > "prove" the patch for maintainers. =A0Looking good, though! > > Cheers > > Phil >