From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15125 invoked by alias); 8 Mar 2011 02:35:33 -0000 Received: (qmail 15037 invoked by uid 22791); 8 Mar 2011 02:35:32 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gw0-f54.google.com (HELO mail-gw0-f54.google.com) (74.125.83.54) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Mar 2011 02:35:28 +0000 Received: by gwj22 with SMTP id 22so2203603gwj.13 for ; Mon, 07 Mar 2011 18:35:26 -0800 (PST) Received: by 10.150.58.4 with SMTP id g4mr5318796yba.155.1299551726665; Mon, 07 Mar 2011 18:35:26 -0800 (PST) MIME-Version: 1.0 Received: by 10.147.125.2 with HTTP; Mon, 7 Mar 2011 18:35:06 -0800 (PST) In-Reply-To: <4D7527EE.9020204@vmware.com> References: <4D6EC5ED.3070307@vmware.com> <4D7137F6.4020000@vmware.com> <4D7527EE.9020204@vmware.com> From: Hui Zhu Date: Tue, 08 Mar 2011 04:35:00 -0000 Message-ID: Subject: Re: [RFA] i386-tdep.c, i386_process_record, document fall-through case. To: Michael Snyder Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00512.txt.bz2 I am not sure. As my poor understanding of C language, break or not break are both OK for this part. Thanks, Hui On Tue, Mar 8, 2011 at 02:46, Michael Snyder wrote: > But should there be a break there? =A0Or not? > > > > Hui Zhu wrote: >> >> Hi Michael, >> >> Sorry for late. >> >> I don't know we need this patch or not. >> >> As some people's mail, they don't like this part code. =A0 This part >> should rewrite to share code with opcode or something. >> So I think in the near future, this code will be rewritten by these >> guys or somebody else. >> >> Thanks, >> Hui >> >> On Sat, Mar 5, 2011 at 03:05, Michael Snyder wrote: >>> >>> Michael Snyder wrote: >>>> >>>> Hui, is this right? >>>> >>>> Thanks, >>>> Michael >>>> >>> Ping? =A0 ;-) >>> >>> > >