From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30461 invoked by alias); 5 Jan 2011 23:49:51 -0000 Received: (qmail 30452 invoked by uid 22791); 5 Jan 2011 23:49:49 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,TW_BJ,TW_YM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Jan 2011 23:49:43 +0000 Received: from wpaz9.hot.corp.google.com (wpaz9.hot.corp.google.com [172.24.198.73]) by smtp-out.google.com with ESMTP id p05Nnevg009964 for ; Wed, 5 Jan 2011 15:49:40 -0800 Received: from qwj9 (qwj9.prod.google.com [10.241.195.73]) by wpaz9.hot.corp.google.com with ESMTP id p05NmP43003783 for ; Wed, 5 Jan 2011 15:49:39 -0800 Received: by qwj9 with SMTP id 9so16135943qwj.36 for ; Wed, 05 Jan 2011 15:49:38 -0800 (PST) Received: by 10.224.28.212 with SMTP id n20mr22450732qac.181.1294271378764; Wed, 05 Jan 2011 15:49:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.7.132 with HTTP; Wed, 5 Jan 2011 15:49:08 -0800 (PST) In-Reply-To: <201101052328.00646.pedro@codesourcery.com> References: <20110105193621.A8CBF190B3A@elbrus2.mtv.corp.google.com> <201101052257.30806.pedro@codesourcery.com> <201101052328.00646.pedro@codesourcery.com> From: Paul Pluzhnikov Date: Wed, 05 Jan 2011 23:49:00 -0000 Message-ID: Subject: Re: [patch] Add "debug jit" for easier tracing of JIT support internals To: Pedro Alves Cc: gdb-patches@sourceware.org, Doug Evans Content-Type: multipart/mixed; boundary=0015175ce00ec6365a049922096f X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00102.txt.bz2 --0015175ce00ec6365a049922096f Content-Type: text/plain; charset=ISO-8859-1 Content-length: 791 On Wed, Jan 5, 2011 at 3:28 PM, Pedro Alves wrote: > I don't see why making that uint64_t be a ULONGEST would be a problem. Done. This exposed a bug -- bfd_open_from_target_memory() had size_t where ULONGEST was intended. Thanks, -- Paul Pluzhnikov 2010-01-05 Paul Pluzhnikov * jit.h (struct jit_code_entry): use ULONGEST for symfile_size. * jit.c (jit_debug): New variable. (show_jit_debug): New function. (struct target_buffer): Use ULONGEST. (bfd_open_from_target_memory): Likewise. (jit_register_code, jit_inferior_init): Add debug output. (_initialize_jit): Register "debug jit" command. doc/ChangeLog: 2010-01-05 Paul Pluzhnikov * gdb.texi (Debugging Output): Document "set debug jit" --0015175ce00ec6365a049922096f Content-Type: text/plain; charset=US-ASCII; name="gdb-jit-debug-20110105-4.txt" Content-Disposition: attachment; filename="gdb-jit-debug-20110105-4.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gikvpu3l0 Content-length: 7003 SW5kZXg6IGppdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IC9jdnMvc3JjL3NyYy9nZGIvaml0LmgsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuNApkaWZmIC11IC1wIC1yMS40IGppdC5oCi0tLSBqaXQuaAkxIEphbiAy MDExIDE1OjMzOjA5IC0wMDAwCTEuNAorKysgaml0LmgJNSBKYW4gMjAxMSAy Mzo0MToxNyAtMDAwMApAQCAtNDIsNyArNDIsNyBAQCBzdHJ1Y3Qgaml0X2Nv ZGVfZW50cnkKICAgQ09SRV9BRERSIG5leHRfZW50cnk7CiAgIENPUkVfQURE UiBwcmV2X2VudHJ5OwogICBDT1JFX0FERFIgc3ltZmlsZV9hZGRyOwotICB1 aW50NjRfdCBzeW1maWxlX3NpemU7CisgIFVMT05HRVNUIHN5bWZpbGVfc2l6 ZTsKIH07CiAKIC8qIFRoaXMgaXMgdGhlIGdsb2JhbCBkZXNjcmlwdG9yIHRo YXQgdGhlIGluZmVyaW9yIHVzZXMgdG8gY29tbXVuaWNhdGUKSW5kZXg6IGpp dC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3Jj L3NyYy9nZGIvaml0LmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOApkaWZm IC11IC1wIC1yMS44IGppdC5jCi0tLSBqaXQuYwkxIEphbiAyMDExIDE1OjMz OjA5IC0wMDAwCTEuOAorKysgaml0LmMJNSBKYW4gMjAxMSAyMzo0MToxNyAt MDAwMApAQCAtMjEsNiArMjEsOCBAQAogCiAjaW5jbHVkZSAiaml0LmgiCiAj aW5jbHVkZSAiYnJlYWtwb2ludC5oIgorI2luY2x1ZGUgImNvbW1hbmQuaCIK KyNpbmNsdWRlICJnZGJjbWQuaCIKICNpbmNsdWRlICJnZGJjb3JlLmgiCiAj aW5jbHVkZSAib2JzZXJ2ZXIuaCIKICNpbmNsdWRlICJvYmpmaWxlcy5oIgpA QCAtNDgsNiArNTAsMTcgQEAgc3RhdGljIENPUkVfQUREUiBqaXRfZGVzY3Jp cHRvcl9hZGRyID0gMAogCiBzdGF0aWMgaW50IHJlZ2lzdGVyaW5nX2NvZGUg PSAwOwogCisvKiBOb24temVybyBpZiB3ZSB3YW50IHRvIHNlZSB0cmFjZSBv ZiBqaXQgbGV2ZWwgc3R1ZmYuICAqLworCitzdGF0aWMgaW50IGppdF9kZWJ1 ZyA9IDA7CisKK3N0YXRpYyB2b2lkCitzaG93X2ppdF9kZWJ1ZyAoc3RydWN0 IHVpX2ZpbGUgKmZpbGUsIGludCBmcm9tX3R0eSwKKwkJc3RydWN0IGNtZF9s aXN0X2VsZW1lbnQgKmMsIGNvbnN0IGNoYXIgKnZhbHVlKQoreworICBmcHJp bnRmX2ZpbHRlcmVkIChmaWxlLCBfKCJKSVQgZGVidWdnaW5nIGlzICVzLlxu IiksIHZhbHVlKTsKK30KKwogLyogSGVscGVyIGNsZWFudXAgZnVuY3Rpb24g dG8gY2xlYXIgYW4gaW50ZWdlciBmbGFnIGxpa2UgdGhlIG9uZSBhYm92ZS4g ICovCiAKIHN0YXRpYyB2b2lkCkBAIC01OSw3ICs3Miw3IEBAIGNsZWFyX2lu dCAodm9pZCAqaW50X2FkZHIpCiBzdHJ1Y3QgdGFyZ2V0X2J1ZmZlcgogewog ICBDT1JFX0FERFIgYmFzZTsKLSAgc2l6ZV90IHNpemU7CisgIFVMT05HRVNU IHNpemU7CiB9OwogCiAvKiBPcGVubmluZyB0aGUgZmlsZSBpcyBhIG5vLW9w LiAgKi8KQEAgLTExOCw3ICsxMzEsNyBAQCBtZW1fYmZkX2lvdmVjX3N0YXQg KHN0cnVjdCBiZmQgKmFiZmQsIHZvCiAvKiBPcGVuIGEgQkZEIGZyb20gdGhl IHRhcmdldCdzIG1lbW9yeS4gICovCiAKIHN0YXRpYyBzdHJ1Y3QgYmZkICoK LWJmZF9vcGVuX2Zyb21fdGFyZ2V0X21lbW9yeSAoQ09SRV9BRERSIGFkZHIs IHNpemVfdCBzaXplLCBjaGFyICp0YXJnZXQpCitiZmRfb3Blbl9mcm9tX3Rh cmdldF9tZW1vcnkgKENPUkVfQUREUiBhZGRyLCBVTE9OR0VTVCBzaXplLCBj aGFyICp0YXJnZXQpCiB7CiAgIGNvbnN0IGNoYXIgKmZpbGVuYW1lID0geHN0 cmR1cCAoIjxpbi1tZW1vcnk+Iik7CiAgIHN0cnVjdCB0YXJnZXRfYnVmZmVy ICpidWZmZXIgPSB4bWFsbG9jIChzaXplb2YgKHN0cnVjdCB0YXJnZXRfYnVm ZmVyKSk7CkBAIC0yMTksNiArMjMyLDEzIEBAIGppdF9yZWdpc3Rlcl9jb2Rl IChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXIKICAgY29uc3Qgc3RydWN0IGJmZF9h cmNoX2luZm8gKmI7CiAgIENPUkVfQUREUiAqZW50cnlfYWRkcl9wdHI7CiAK KyAgaWYgKGppdF9kZWJ1ZykKKyAgICBmcHJpbnRmX3VuZmlsdGVyZWQgKGdk Yl9zdGRsb2csCisJCQkiaml0X3JlZ2lzdGVyX2NvZGUsIHN5bWZpbGVfYWRk ciA9ICVzLCAiCisJCQkic3ltZmlsZV9zaXplID0gJXNcbiIsCisJCQlwYWRk cmVzcyAoZ2RiYXJjaCwgY29kZV9lbnRyeS0+c3ltZmlsZV9hZGRyKSwKKwkJ CXB1bG9uZ2VzdCAoY29kZV9lbnRyeS0+c3ltZmlsZV9zaXplKSk7CisKICAg bmJmZCA9IGJmZF9vcGVuX2Zyb21fdGFyZ2V0X21lbW9yeSAoY29kZV9lbnRy eS0+c3ltZmlsZV9hZGRyLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjb2RlX2VudHJ5LT5zeW1maWxlX3NpemUsIGdudXRhcmdl dCk7CiAgIG9sZF9jbGVhbnVwcyA9IG1ha2VfY2xlYW51cF9iZmRfY2xvc2Ug KG5iZmQpOwpAQCAtMzE0LDYgKzMzNCwxMSBAQCBqaXRfaW5mZXJpb3JfaW5p dCAoc3RydWN0IGdkYmFyY2ggKmdkYmFyCiAgIHN0cnVjdCBqaXRfY29kZV9l bnRyeSBjdXJfZW50cnk7CiAgIENPUkVfQUREUiBjdXJfZW50cnlfYWRkcjsK IAorICBpZiAoaml0X2RlYnVnKQorICAgIGZwcmludGZfdW5maWx0ZXJlZCAo Z2RiX3N0ZGxvZywKKwkJCSJqaXRfaW5mZXJpb3JfaW5pdCwgcmVnaXN0ZXJp bmdfY29kZSA9ICVkXG4iLAorCQkJcmVnaXN0ZXJpbmdfY29kZSk7CisKICAg LyogV2hlbiB3ZSByZWdpc3RlciBjb2RlLCBHREIgcmVzZXRzIGl0cyBicmVh a3BvaW50cyBpbiBjYXNlIHN5bWJvbHMgaGF2ZQogICAgICBjaGFuZ2VkLiAg VGhhdCBpbiB0dXJuIGNhbGxzIHRoaXMgaGFuZGxlciwgd2hpY2ggbWFrZXMg dXMgbG9vayBmb3IgbmV3CiAgICAgIGNvZGUgYWdhaW4uICBUbyBhdm9pZCBi ZWluZyByZS1lbnRlcmVkLCB3ZSBjaGVjayB0aGlzIGZsYWcuICAqLwpAQCAt MzI5LDYgKzM1NCwxMCBAQCBqaXRfaW5mZXJpb3JfaW5pdCAoc3RydWN0IGdk YmFyY2ggKmdkYmFyCiAgIGlmIChyZWdfYWRkciA9PSAwKQogICAgIHJldHVy bjsKIAorICBpZiAoaml0X2RlYnVnKQorICAgIGZwcmludGZfdW5maWx0ZXJl ZCAoZ2RiX3N0ZGxvZywgImppdF9pbmZlcmlvcl9pbml0LCByZWdfYWRkciA9 ICVzXG4iLAorCQkJcGFkZHJlc3MgKGdkYmFyY2gsIHJlZ19hZGRyKSk7CisK ICAgLyogTG9va3VwIHRoZSBkZXNjcmlwdG9yIHN5bWJvbCBhbmQgY2FjaGUg dGhlIGFkZHIuICBJZiBpdCBpcyBtaXNzaW5nLCB3ZQogICAgICBhc3N1bWUg d2UgYXJlIG5vdCBhdHRhY2hlZCB0byBhIEpJVCBhbmQgcmV0dXJuIGVhcmx5 LiAgKi8KICAgZGVzY19zeW1ib2wgPSBsb29rdXBfbWluaW1hbF9zeW1ib2wg KGppdF9kZXNjcmlwdG9yX25hbWUsIE5VTEwsIE5VTEwpOwpAQCAtMzM4LDYg KzM2NywxMSBAQCBqaXRfaW5mZXJpb3JfaW5pdCAoc3RydWN0IGdkYmFyY2gg KmdkYmFyCiAgIGlmIChqaXRfZGVzY3JpcHRvcl9hZGRyID09IDApCiAgICAg cmV0dXJuOwogCisgIGlmIChqaXRfZGVidWcpCisgICAgZnByaW50Zl91bmZp bHRlcmVkIChnZGJfc3RkbG9nLAorCQkJImppdF9pbmZlcmlvcl9pbml0LCBq aXRfZGVzY3JpcHRvcl9hZGRyID0gJXNcbiIsCisJCQlwYWRkcmVzcyAoZ2Ri YXJjaCwgaml0X2Rlc2NyaXB0b3JfYWRkcikpOworCiAgIC8qIFJlYWQgdGhl IGRlc2NyaXB0b3Igc28gd2UgY2FuIGNoZWNrIHRoZSB2ZXJzaW9uIG51bWJl ciBhbmQgbG9hZCBhbnkgYWxyZWFkeQogICAgICBKSVRlZCBmdW5jdGlvbnMu ICAqLwogICBqaXRfcmVhZF9kZXNjcmlwdG9yIChnZGJhcmNoLCAmZGVzY3Jp cHRvcik7CkBAIC00NTMsNiArNDg3LDE0IEBAIGV4dGVybiB2b2lkIF9pbml0 aWFsaXplX2ppdCAodm9pZCk7CiB2b2lkCiBfaW5pdGlhbGl6ZV9qaXQgKHZv aWQpCiB7CisgIGFkZF9zZXRzaG93X3ppbnRlZ2VyX2NtZCAoImppdCIsIGNs YXNzX21haW50ZW5hbmNlLCAmaml0X2RlYnVnLCBfKCJcCitTZXQgSklUIGRl YnVnZ2luZy4iKSwgXygiXAorU2hvdyBKSVQgZGVidWdnaW5nLiIpLCBfKCJc CitXaGVuIG5vbi16ZXJvLCBKSVQgZGVidWdnaW5nIGlzIGVuYWJsZWQuIiks CisJCQkgICAgTlVMTCwKKwkJCSAgICBzaG93X2ppdF9kZWJ1ZywKKwkJCSAg ICAmc2V0ZGVidWdsaXN0LCAmc2hvd2RlYnVnbGlzdCk7CisKICAgb2JzZXJ2 ZXJfYXR0YWNoX2luZmVyaW9yX2NyZWF0ZWQgKGppdF9pbmZlcmlvcl9jcmVh dGVkX29ic2VydmVyKTsKICAgb2JzZXJ2ZXJfYXR0YWNoX2luZmVyaW9yX2V4 aXQgKGppdF9pbmZlcmlvcl9leGl0X2hvb2spOwogICBqaXRfb2JqZmlsZV9k YXRhID0gcmVnaXN0ZXJfb2JqZmlsZV9kYXRhICgpOwpJbmRleDogZG9jL2dk Yi50ZXhpbmZvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvc3JjL3NyYy9nZGIvZG9jL2dkYi50ZXhpbmZvLHYKcmV0cmlldmluZyBy ZXZpc2lvbiAxLjc4MwpkaWZmIC11IC1wIC1yMS43ODMgZ2RiLnRleGluZm8K LS0tIGRvYy9nZGIudGV4aW5mbwk1IEphbiAyMDExIDA1OjA5OjUyIC0wMDAw CTEuNzgzCisrKyBkb2MvZ2RiLnRleGluZm8JNSBKYW4gMjAxMSAyMzo0MTox OCAtMDAwMApAQCAtMTk5NTUsNiArMTk5NTUsMTEgQEAgVGhlIGRlZmF1bHQg aXMgb2ZmLiAgQGZpbGV7aW5mcnVuLmN9IGNvbgogZm9yIGltcGxlbWVudGlu ZyBvcGVyYXRpb25zIHN1Y2ggYXMgc2luZ2xlLXN0ZXBwaW5nIHRoZSBpbmZl cmlvci4KIEBpdGVtIHNob3cgZGVidWcgaW5mcnVuCiBEaXNwbGF5cyB0aGUg Y3VycmVudCBzdGF0ZSBvZiBAdmFsdWV7R0RCTn0gaW5mZXJpb3IgZGVidWdn aW5nLgorQGl0ZW0gc2V0IGRlYnVnIGppdAorQGNpbmRleCBqdXN0LWluLXRp bWUgY29tcGlsYXRpb24KK1R1cm5zIG9uIG9yIG9mZiBkZWJ1Z2dpbmcgbWVz c2FnZXMgZnJvbSBKSVQgZGVidWcgc3VwcG9ydC4KK0BpdGVtIHNob3cgZGVi dWcgaml0CitEaXNwbGF5cyB0aGUgY3VycmVudCBzdGF0ZSBvZiBAdmFsdWV7 R0RCTn0gSklUIGRlYnVnZ2luZy4KIEBpdGVtIHNldCBkZWJ1ZyBsaW4tbHdw CiBAY2luZGV4IEBzY3tnbnV9L0xpbnV4IExXUCBkZWJ1ZyBtZXNzYWdlcwog QGNpbmRleCBMaW51eCBsaWdodHdlaWdodCBwcm9jZXNzZXMK --0015175ce00ec6365a049922096f--