From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15832 invoked by alias); 21 Oct 2010 21:06:02 -0000 Received: (qmail 15823 invoked by uid 22791); 21 Oct 2010 21:06:01 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Oct 2010 21:05:57 +0000 Received: from kpbe13.cbf.corp.google.com (kpbe13.cbf.corp.google.com [172.25.105.77]) by smtp-out.google.com with ESMTP id o9LL5txR016992 for ; Thu, 21 Oct 2010 14:05:55 -0700 Received: from pvg16 (pvg16.prod.google.com [10.241.210.144]) by kpbe13.cbf.corp.google.com with ESMTP id o9LL5NDF001402 for ; Thu, 21 Oct 2010 14:05:54 -0700 Received: by pvg16 with SMTP id 16so29993pvg.29 for ; Thu, 21 Oct 2010 14:05:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.192.14 with SMTP id p14mr1258235wff.303.1287695153053; Thu, 21 Oct 2010 14:05:53 -0700 (PDT) Received: by 10.220.187.199 with HTTP; Thu, 21 Oct 2010 14:05:52 -0700 (PDT) In-Reply-To: <4CBFCB92.5020204@codesourcery.com> References: <4CBEDBF5.9060504@codesourcery.com> <201010210114.24465.pedro@codesourcery.com> <4CBF86A6.8020102@codesourcery.com> <201010210128.53843.pedro@codesourcery.com> <4CBFA227.8050501@codesourcery.com> <4CBFCB92.5020204@codesourcery.com> Date: Thu, 21 Oct 2010 21:06:00 -0000 Message-ID: Subject: Re: Fix Makefile.in in data-directory From: Doug Evans To: Jie Zhang Cc: Pedro Alves , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00342.txt.bz2 On Wed, Oct 20, 2010 at 10:11 PM, Jie Zhang wrote: > On 10/21/2010 10:29 AM, Doug Evans wrote: >> >> On Wed, Oct 20, 2010 at 7:15 PM, Jie Zhang =A0wrot= e: >>> >>> I don't think it's really necessary to fix that. binutils and gcc also >>> don't >>> allow "make -j4 install" to directly after "configure". "make -j4 all >>> install" also fails for binutils and gcc. I think it's already an >>> convention >>> that those software are built with >>> >>> ./configure >>> make >>> make install >>> >>> Do we really need the effort to fix GDB? >> >> fwiw, I think the answer is yes. >> >> Note that we don't need to consider ./configure ; make -j4 install. >> >> The issue arises with a simple "$EDITOR foo.c ; make -j4 install". > > Reasonable although I never used it before. This is an updated patch which > does that. It fixes it by passing FLAGS_TO_PASS when recursively make > install-only. It fixes my issue. I also tested by touching a source file = and > do "make -j4 install" in gdb directory. It behaves as expected. OK now? Thanks for persevering. The patch is fine with me, though there is one obvious improvement. It could be left for another pass. FLAGS_TO_PASS is big, and there are now multiple copies of it. IWBN if there were only one copy. I wonder how much duplication there is in the makefiles, and if a Makefile.common is reasonable. It could be pasted in by configure. [I realize gdbserver has its own configure, but it could, I think, still use the same Makefile.common.] I'm not sure it's warranted just for FLAGS_TO_PASS, so it could be left for another day. Feel free to check this in as is if you prefer.