From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22927 invoked by alias); 14 Mar 2011 21:02:29 -0000 Received: (qmail 22912 invoked by uid 22791); 14 Mar 2011 21:02:27 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 21:02:20 +0000 Received: from hpaq14.eem.corp.google.com (hpaq14.eem.corp.google.com [172.25.149.14]) by smtp-out.google.com with ESMTP id p2EL2IKQ024518 for ; Mon, 14 Mar 2011 14:02:18 -0700 Received: from vws1 (vws1.prod.google.com [10.241.21.129]) by hpaq14.eem.corp.google.com with ESMTP id p2EL2E6M004455 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 14 Mar 2011 14:02:16 -0700 Received: by vws1 with SMTP id 1so3355731vws.33 for ; Mon, 14 Mar 2011 14:02:14 -0700 (PDT) Received: by 10.52.72.67 with SMTP id b3mr8928632vdv.116.1300136534128; Mon, 14 Mar 2011 14:02:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.60.9 with HTTP; Mon, 14 Mar 2011 14:01:44 -0700 (PDT) In-Reply-To: References: From: Paul Pluzhnikov Date: Mon, 14 Mar 2011 21:16:00 -0000 Message-ID: Subject: [patch] Re: Advice on fixing gdb/12528 To: Tom Tromey Cc: gdb-patches ml , Doug Evans Content-Type: multipart/mixed; boundary=20cf307f3bfc46b736049e77a061 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00748.txt.bz2 --20cf307f3bfc46b736049e77a061 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 616 On Fri, Mar 11, 2011 at 9:14 AM, Tom Tromey wrote: > Can you check the has_section_at_zero flag on dwarf2_per_objfile? Thanks! Attached patch fixes the problem and adds a test case. Tested on Linux/x86_64, no regressions. -- Paul Pluzhnikov ChangeLog: 2011-03-14 Paul Pluzhnikov PR gdb/12528 * dwarf2read.c (noop_record_line): New function. (dwarf_decode_lines): Ignore line tables for GCd functions. testsuite/ChangeLog: 2011-03-14 Paul Pluzhnikov PR gdb/12528 * gdb.cp/pr12528.exp: New test. * gdb.cp/pr12528.cc: New file. --20cf307f3bfc46b736049e77a061 Content-Type: text/plain; charset=US-ASCII; name="gdb-pr12528-20110314.txt" Content-Disposition: attachment; filename="gdb-pr12528-20110314.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gl9vnazt0 Content-length: 8707 SW5kZXg6IGR3YXJmMnJlYWQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2R3YXJmMnJlYWQuYyx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS41MDgKZGlmZiAtdSAtcCAtcCAtdSAtcjEuNTA4 IGR3YXJmMnJlYWQuYwotLS0gZHdhcmYycmVhZC5jCTkgTWFyIDIwMTEgMDc6 MDc6NTUgLTAwMDAJMS41MDgKKysrIGR3YXJmMnJlYWQuYwkxNCBNYXIgMjAx MSAyMDo1MjoxMSAtMDAwMApAQCAtMTAzNDEsNiArMTAzNDEsMTQgQEAgcHN5 bXRhYl9pbmNsdWRlX2ZpbGVfbmFtZSAoY29uc3Qgc3RydWN0IAogICByZXR1 cm4gaW5jbHVkZV9uYW1lOwogfQogCisvKiBJZ25vcmUgdGhpcyByZWNvcmRf bGluZSByZXF1ZXN0LiAgKi8KKworc3RhdGljIHZvaWQKK25vb3BfcmVjb3Jk X2xpbmUgKHN0cnVjdCBzdWJmaWxlICpzdWJmaWxlLCBpbnQgbGluZSwgQ09S RV9BRERSIHBjKQoreworICByZXR1cm47Cit9CisKIC8qIERlY29kZSB0aGUg TGluZSBOdW1iZXIgUHJvZ3JhbSAoTE5QKSBmb3IgdGhlIGdpdmVuIGxpbmVf aGVhZGVyCiAgICBzdHJ1Y3R1cmUgYW5kIENVLiAgVGhlIGFjdHVhbCBpbmZv cm1hdGlvbiBleHRyYWN0ZWQgYW5kIHRoZSB0eXBlCiAgICBvZiBzdHJ1Y3R1 cmVzIGNyZWF0ZWQgZnJvbSB0aGUgTE5QIGRlcGVuZHMgb24gdGhlIHZhbHVl IG9mIFBTVC4KQEAgLTEwMzc2LDYgKzEwMzg0LDggQEAgZHdhcmZfZGVjb2Rl X2xpbmVzIChzdHJ1Y3QgbGluZV9oZWFkZXIgKgogICBzdHJ1Y3QgZ2RiYXJj aCAqZ2RiYXJjaCA9IGdldF9vYmpmaWxlX2FyY2ggKG9iamZpbGUpOwogICBj b25zdCBpbnQgZGVjb2RlX2Zvcl9wc3RfcCA9IChwc3QgIT0gTlVMTCk7CiAg IHN0cnVjdCBzdWJmaWxlICpsYXN0X3N1YmZpbGUgPSBOVUxMLCAqZmlyc3Rf c3ViZmlsZSA9IGN1cnJlbnRfc3ViZmlsZTsKKyAgdm9pZCAoKnBfcmVjb3Jk X2xpbmUpIChzdHJ1Y3Qgc3ViZmlsZSAqc3ViZmlsZSwgaW50IGxpbmUsIENP UkVfQUREUiBwYykKKyAgICA9IHJlY29yZF9saW5lOwogCiAgIGJhc2VhZGRy ID0gQU5PRkZTRVQgKG9iamZpbGUtPnNlY3Rpb25fb2Zmc2V0cywgU0VDVF9P RkZfVEVYVCAob2JqZmlsZSkpOwogCkBAIC0xMDQ0NSwxMyArMTA0NTUsMTMg QEAgZHdhcmZfZGVjb2RlX2xpbmVzIChzdHJ1Y3QgbGluZV9oZWFkZXIgKgog CQkJewogCQkJICBhZGRyID0gZ2RiYXJjaF9hZGRyX2JpdHNfcmVtb3ZlIChn ZGJhcmNoLCBhZGRyZXNzKTsKIAkJCSAgaWYgKGxhc3Rfc3ViZmlsZSkKLQkJ CSAgICByZWNvcmRfbGluZSAobGFzdF9zdWJmaWxlLCAwLCBhZGRyKTsKKwkJ CSAgICAoKnBfcmVjb3JkX2xpbmUpIChsYXN0X3N1YmZpbGUsIDAsIGFkZHIp OwogCQkJICBsYXN0X3N1YmZpbGUgPSBjdXJyZW50X3N1YmZpbGU7CiAJCQl9 CiAJCSAgICAgIC8qIEFwcGVuZCByb3cgdG8gbWF0cml4IHVzaW5nIGN1cnJl bnQgdmFsdWVzLiAgKi8KIAkJICAgICAgYWRkciA9IGNoZWNrX2N1X2Z1bmN0 aW9ucyAoYWRkcmVzcywgY3UpOwogCQkgICAgICBhZGRyID0gZ2RiYXJjaF9h ZGRyX2JpdHNfcmVtb3ZlIChnZGJhcmNoLCBhZGRyKTsKLQkJICAgICAgcmVj b3JkX2xpbmUgKGN1cnJlbnRfc3ViZmlsZSwgbGluZSwgYWRkcik7CisJCSAg ICAgICgqcF9yZWNvcmRfbGluZSkgKGN1cnJlbnRfc3ViZmlsZSwgbGluZSwg YWRkcik7CiAJCSAgICB9CiAJCX0KIAkgICAgICBiYXNpY19ibG9jayA9IDA7 CkBAIC0xMDQ2OCwxMiArMTA0NzgsMTkgQEAgZHdhcmZfZGVjb2RlX2xpbmVz IChzdHJ1Y3QgbGluZV9oZWFkZXIgKgogCSAgICAgIHN3aXRjaCAoZXh0ZW5k ZWRfb3ApCiAJCXsKIAkJY2FzZSBEV19MTkVfZW5kX3NlcXVlbmNlOgorCQkg IHBfcmVjb3JkX2xpbmUgPSByZWNvcmRfbGluZTsKIAkJICBlbmRfc2VxdWVu Y2UgPSAxOwogCQkgIGJyZWFrOwogCQljYXNlIERXX0xORV9zZXRfYWRkcmVz czoKIAkJICBhZGRyZXNzID0gcmVhZF9hZGRyZXNzIChhYmZkLCBsaW5lX3B0 ciwgY3UsICZieXRlc19yZWFkKTsKIAkJICBvcF9pbmRleCA9IDA7CiAJCSAg bGluZV9wdHIgKz0gYnl0ZXNfcmVhZDsKKworCQkgIGlmIChhZGRyZXNzID09 IDAgJiYgIWR3YXJmMl9wZXJfb2JqZmlsZS0+aGFzX3NlY3Rpb25fYXRfemVy bykKKwkJICAgIC8qIFRoaXMgbGluZSB0YWJsZSBpcyBmb3IgYSBmdW5jdGlv biB3aGljaCBoYXMgYmVlbgorCQkgICAgICAgR0NkIGJ5IHRoZSBsaW5rZXIu ICBJZ25vcmUgaXQuICBQUiBnZGIvMTI1MjggKi8KKwkJICAgIHBfcmVjb3Jk X2xpbmUgPSBub29wX3JlY29yZF9saW5lOworCiAJCSAgYWRkcmVzcyArPSBi YXNlYWRkcjsKIAkJICBicmVhazsKIAkJY2FzZSBEV19MTkVfZGVmaW5lX2Zp bGU6CkBAIC0xMDUyOCwxMiArMTA1NDUsMTIgQEAgZHdhcmZfZGVjb2RlX2xp bmVzIChzdHJ1Y3QgbGluZV9oZWFkZXIgKgogCQkJewogCQkJICBhZGRyID0g Z2RiYXJjaF9hZGRyX2JpdHNfcmVtb3ZlIChnZGJhcmNoLCBhZGRyZXNzKTsK IAkJCSAgaWYgKGxhc3Rfc3ViZmlsZSkKLQkJCSAgICByZWNvcmRfbGluZSAo bGFzdF9zdWJmaWxlLCAwLCBhZGRyKTsKKwkJCSAgICAoKnBfcmVjb3JkX2xp bmUpIChsYXN0X3N1YmZpbGUsIDAsIGFkZHIpOwogCQkJICBsYXN0X3N1YmZp bGUgPSBjdXJyZW50X3N1YmZpbGU7CiAJCQl9CiAJCSAgICAgIGFkZHIgPSBj aGVja19jdV9mdW5jdGlvbnMgKGFkZHJlc3MsIGN1KTsKIAkJICAgICAgYWRk ciA9IGdkYmFyY2hfYWRkcl9iaXRzX3JlbW92ZSAoZ2RiYXJjaCwgYWRkcik7 Ci0JCSAgICAgIHJlY29yZF9saW5lIChjdXJyZW50X3N1YmZpbGUsIGxpbmUs IGFkZHIpOworCQkgICAgICAoKnBfcmVjb3JkX2xpbmUpIChjdXJyZW50X3N1 YmZpbGUsIGxpbmUsIGFkZHIpOwogCQkgICAgfQogCQl9CiAJICAgICAgYmFz aWNfYmxvY2sgPSAwOwpAQCAtMTA2MzIsNyArMTA2NDksNyBAQCBkd2FyZl9k ZWNvZGVfbGluZXMgKHN0cnVjdCBsaW5lX2hlYWRlciAqCiAgICAgICAgICAg aWYgKCFkZWNvZGVfZm9yX3BzdF9wKQogCSAgICB7CiAJICAgICAgYWRkciA9 IGdkYmFyY2hfYWRkcl9iaXRzX3JlbW92ZSAoZ2RiYXJjaCwgYWRkcmVzcyk7 Ci0JICAgICAgcmVjb3JkX2xpbmUgKGN1cnJlbnRfc3ViZmlsZSwgMCwgYWRk cik7CisJICAgICAgKCpwX3JlY29yZF9saW5lKSAoY3VycmVudF9zdWJmaWxl LCAwLCBhZGRyKTsKIAkgICAgfQogICAgICAgICB9CiAgICAgfQpJbmRleDog dGVzdHN1aXRlL2dkYi5jcC9wcjEyNTI4LmNjCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KUkNTIGZpbGU6IHRlc3RzdWl0ZS9nZGIuY3AvcHIxMjUyOC5jYwpk aWZmIC1OIHRlc3RzdWl0ZS9nZGIuY3AvcHIxMjUyOC5jYwotLS0gL2Rldi9u dWxsCTEgSmFuIDE5NzAgMDA6MDA6MDAgLTAwMDAKKysrIHRlc3RzdWl0ZS9n ZGIuY3AvcHIxMjUyOC5jYwkxNCBNYXIgMjAxMSAyMDo1MjoxMSAtMDAwMApA QCAtMCwwICsxLDQxIEBACisvKiBUaGlzIHRlc3RjYXNlIGlzIHBhcnQgb2Yg R0RCLCB0aGUgR05VIGRlYnVnZ2VyLgorCisgICBDb3B5cmlnaHQgMjAxMSBG cmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKworICAgVGhpcyBwcm9n cmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0 IGFuZC9vciBtb2RpZnkKKyAgIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUg R05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5Cisg ICB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lv biAzIG9mIHRoZSBMaWNlbnNlLCBvcgorICAgKGF0IHlvdXIgb3B0aW9uKSBh bnkgbGF0ZXIgdmVyc2lvbi4KKworICAgVGhpcyBwcm9ncmFtIGlzIGRpc3Ry aWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisg ICBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUg aW1wbGllZCB3YXJyYW50eSBvZgorICAgTUVSQ0hBTlRBQklMSVRZIG9yIEZJ VE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorICAg R05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4K KworICAgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUg R05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKyAgIGFsb25nIHdpdGggdGhp cyBwcm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9s aWNlbnNlcy8+LgorICAgKi8KKworLy8gVGVzdCBjYXNlIGZvciBQUiBnZGIv MTI1MjgKKworc3RydWN0IGZvbworeworICBmb28gKGludCB4KTsKKyAgaW50 IF94OworfTsKKworc3RydWN0IGZvbzIgOiBwdWJsaWMgZm9vCit7CisgIGZv bzIgKGludCB4KTsKK307CisKK2Zvbzo6Zm9vIChpbnQgeCkgOiBfeCAoeCkg eyB9CisKK2ZvbzI6OmZvbzIgKGludCB4KSA6IGZvbyAoeCkgeyB9CisKK2lu dAorbWFpbiAoKQoreworICBmb28yIGJhciAoMyk7CisgIHJldHVybiAwOwor fQpJbmRleDogdGVzdHN1aXRlL2dkYi5jcC9wcjEyNTI4LmV4cAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09ClJDUyBmaWxlOiB0ZXN0c3VpdGUvZ2RiLmNwL3By MTI1MjguZXhwCmRpZmYgLU4gdGVzdHN1aXRlL2dkYi5jcC9wcjEyNTI4LmV4 cAotLS0gL2Rldi9udWxsCTEgSmFuIDE5NzAgMDA6MDA6MDAgLTAwMDAKKysr IHRlc3RzdWl0ZS9nZGIuY3AvcHIxMjUyOC5leHAJMTQgTWFyIDIwMTEgMjA6 NTI6MTEgLTAwMDAKQEAgLTAsMCArMSw1NSBAQAorIyBDb3B5cmlnaHQgMjAx MSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKworIyBUaGlzIHBy b2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUg aXQgYW5kL29yIG1vZGlmeQorIyBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhl IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQor IyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lv biAzIG9mIHRoZSBMaWNlbnNlLCBvcgorIyAoYXQgeW91ciBvcHRpb24pIGFu eSBsYXRlciB2ZXJzaW9uLgorIworIyBUaGlzIHByb2dyYW0gaXMgZGlzdHJp YnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyMg YnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGlt cGxpZWQgd2FycmFudHkgb2YKKyMgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5F U1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorIyBHTlUg R2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorIwor IyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUg R2VuZXJhbCBQdWJsaWMgTGljZW5zZQorIyBhbG9uZyB3aXRoIHRoaXMgcHJv Z3JhbS4gIElmIG5vdCwgc2VlIDxodHRwOi8vd3d3LmdudS5vcmcvbGljZW5z ZXMvPi4KKworIyBUaGlzIGZpbGUgaXMgcGFydCBvZiB0aGUgZ2RiIHRlc3Rz dWl0ZQorCisjIFRlc3QgY2FzdGluZywgZXNwZWNpYWxseSBiZXR3ZWVuIGNs YXNzIHR5cGVzIG9yIHBvaW50ZXItdG8tY2xhc3MKKyMgdHlwZXMuCisKKyMg VGhpcyBmaWxlIGlzIHBhcnQgb2YgdGhlIGdkYiB0ZXN0c3VpdGUKKworaWYg JHRyYWNlbGV2ZWwgdGhlbiB7CisgICAgc3RyYWNlICR0cmFjZWxldmVsCit9 CisKKyMKKyMgdGVzdCBydW5uaW5nIHByb2dyYW1zCisjCitpZiB7IFtza2lw X2NwbHVzX3Rlc3RzXSB9IHsgY29udGludWUgfQorCitzZXQgdGVzdGZpbGUg InByMTI1MjgiCitzZXQgc3JjZmlsZSAke3Rlc3RmaWxlfS5jYworc2V0IGJp bmZpbGUgJHtvYmpkaXJ9LyR7c3ViZGlyfS8ke3Rlc3RmaWxlfQorCitpZiBb Z2V0X2NvbXBpbGVyX2luZm8gJHtiaW5maWxlfSAiYysrIl0geworICAgIHJl dHVybiAtMTsKK30KKworc2V0IGFkZGl0aW9uYWxfZmxhZ3Mgey1mZnVuY3Rp b24tc2VjdGlvbnMgLVdsLC0tZ2Mtc2VjdGlvbnN9CitpZiAgeyBbZ2RiX2Nv bXBpbGUgIiR7c3JjZGlyfS8ke3N1YmRpcn0vJHtzcmNmaWxlfSIgIiR7Ymlu ZmlsZX0iIGV4ZWN1dGFibGUgXAorCSAgIFtsaXN0IGRlYnVnIGMrKyBhZGRp dGlvbmFsX2ZsYWdzPSRhZGRpdGlvbmFsX2ZsYWdzXV0gIT0gIiIgfSB7Cisg ICAgdW50ZXN0ZWQgJHNyY2ZpbGUKKyAgICByZXR1cm4gLTEKK30KKworY2xl YW5fcmVzdGFydCAkdGVzdGZpbGUKKworaWYgeyAhW3J1bnRvX21haW5dIH0g eworICAgIGZhaWwgIkNhbid0IHJ1biB0byBtYWluIgorICAgIHJldHVybgor fQorCitnZGJfYnJlYWtwb2ludCAiZm9vOjpmb28iCitnZGJfdGVzdCAiY29u dGludWUiICJCcmVha3BvaW50IC4qZm9vOjpmb28uKiIK --20cf307f3bfc46b736049e77a061--