From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31369 invoked by alias); 17 Jul 2010 09:42:49 -0000 Received: (qmail 31359 invoked by uid 22791); 17 Jul 2010 09:42:48 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM X-Spam-Check-By: sourceware.org Received: from mail-ey0-f169.google.com (HELO mail-ey0-f169.google.com) (209.85.215.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Jul 2010 09:42:35 +0000 Received: by eydd26 with SMTP id d26so834728eyd.0 for ; Sat, 17 Jul 2010 02:42:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.25.143 with SMTP id z15mr496572ebb.6.1279359753226; Sat, 17 Jul 2010 02:42:33 -0700 (PDT) Received: by 10.213.11.1 with HTTP; Sat, 17 Jul 2010 02:42:33 -0700 (PDT) In-Reply-To: <201007170537.44785.vapier@gentoo.org> References: <201007170537.44785.vapier@gentoo.org> Date: Sat, 17 Jul 2010 09:42:00 -0000 Message-ID: Subject: Re: [PATCH] [Windows] fix format string for 64 bit var in gdbserver From: Ozkan Sezer To: Mike Frysinger Cc: gdb-patches@sourceware.org, Tom Tromey Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00258.txt.bz2 On Sat, Jul 17, 2010 at 12:37 PM, Mike Frysinger wrote: > On Friday, July 16, 2010 16:10:23 Ozkan Sezer wrote: >> For windows targets, (x86_64-w64-mingw32, i686-w64-mingw32) >> gcc complains: >> >> ../../../gdb-cvs/gdb/gdbserver/server.c: In function 'handle_query': >> ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: unknown >> conversion type character 'l' in format >> ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: too many >> arguments for format >> ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: unknown >> conversion type character 'l' in format >> ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: too many >> arguments for format >> >> This is due to the fact that MS printf doesn't support %lld, it uses >> its own %I64d which gcc already knows about. The attached patch >> changes that. OK for apply? > > ugh, no. =A0why not use a sane define like PRIx64 from inttypes.h ? > -mike > I would happily do that, however that would require inttypes module merge from gnulib to gdb/gnulib, am I wrong? -- Ozkan