From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18471 invoked by alias); 6 Aug 2010 17:27:16 -0000 Received: (qmail 18461 invoked by uid 22791); 6 Aug 2010 17:27:15 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Aug 2010 17:27:10 +0000 Received: from wpaz24.hot.corp.google.com (wpaz24.hot.corp.google.com [172.24.198.88]) by smtp-out.google.com with ESMTP id o76HR7dG014162 for ; Fri, 6 Aug 2010 10:27:07 -0700 Received: from vws18 (vws18.prod.google.com [10.241.21.146]) by wpaz24.hot.corp.google.com with ESMTP id o76HR1Ur004207 for ; Fri, 6 Aug 2010 10:27:06 -0700 Received: by vws18 with SMTP id 18so2853975vws.1 for ; Fri, 06 Aug 2010 10:27:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.59.202 with SMTP id m10mr8612876vch.59.1281115625714; Fri, 06 Aug 2010 10:27:05 -0700 (PDT) Received: by 10.220.201.197 with HTTP; Fri, 6 Aug 2010 10:27:05 -0700 (PDT) In-Reply-To: References: <20100805212008.GA12652@host1.dyn.jankratochvil.net> Date: Fri, 06 Aug 2010 17:27:00 -0000 Message-ID: Subject: Re: [patch] Fix python gdb.execute to not paginate From: Doug Evans To: Tom Tromey Cc: Jan Kratochvil , gdb-patches@sourceware.org, David Malcolm Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00080.txt.bz2 On Fri, Aug 6, 2010 at 10:15 AM, Tom Tromey wrote: >>>>>> "Doug" =3D=3D Doug Evans writes: > > Doug> Actually, I wonder if it makes sense to bury more implementation > Doug> details. =A0Make an API of it, running a gdb command and collecting= the > Doug> result as a string. > > If we're talking about the long term, really the whole pagination > interface is broken. =A0Pagination should be a per-stream thing, and > functions like wrap_here should have a stream parameter. =A0Having to > manipulate globals to get the right result here is clearly bogus. No disagreement there. > I don't think fixing this should be a requirement for a patch, though. I'm not sure you're suggesting otherwise, but I'd still like to see the modicum of changes I've requested implemented.