From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76061-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27433 invoked by alias); 13 Oct 2010 18:03:28 -0000
Received: (qmail 27423 invoked by uid 22791); 13 Oct 2010 18:03:26 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Oct 2010 18:03:12 +0000
Received: from hpaq5.eem.corp.google.com (hpaq5.eem.corp.google.com [172.25.149.5])	by smtp-out.google.com with ESMTP id o9DI39Nb021125	for <gdb-patches@sourceware.org>; Wed, 13 Oct 2010 11:03:10 -0700
Received: from pwi9 (pwi9.prod.google.com [10.241.219.9])	by hpaq5.eem.corp.google.com with ESMTP id o9DI375x012582	for <gdb-patches@sourceware.org>; Wed, 13 Oct 2010 11:03:08 -0700
Received: by pwi9 with SMTP id 9so842240pwi.18        for <gdb-patches@sourceware.org>; Wed, 13 Oct 2010 11:03:07 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.142.12.13 with SMTP id 13mr7847633wfl.393.1286992987161; Wed, 13 Oct 2010 11:03:07 -0700 (PDT)
Received: by 10.220.118.2 with HTTP; Wed, 13 Oct 2010 11:03:06 -0700 (PDT)
In-Reply-To: <20101013175308.17B772461AE@ruffy.mtv.corp.google.com>
References: <20101013175308.17B772461AE@ruffy.mtv.corp.google.com>
Date: Wed, 13 Oct 2010 18:03:00 -0000
Message-ID: <AANLkTimccBCvpkzYirh8VxrkN=2QdsmxS=a+5VSZD61g@mail.gmail.com>
Subject: Re: [patch] fix exp/12117
From: Doug Evans <dje@google.com>
To: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-10/txt/msg00226.txt.bz2

On Wed, Oct 13, 2010 at 10:53 AM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> This patch fixes pr exp/12117.
> http://sourceware.org/bugzilla/show_bug.cgi?id=3D12117
>
> I will check this in in two days if there are no objections.
>
> 2010-10-13 =A0Doug Evans =A0<dje@google.com>
>
> =A0 =A0 =A0 =A0PR exp/12117
> =A0 =A0 =A0 =A0* c-typeprint.c (c_print_type): Call CHECK_TYPEDEF after c=
alling
> =A0 =A0 =A0 =A0c_type_print_base.
> =A0 =A0 =A0 =A0(c_type_print_modifier_flags): New function.
> =A0 =A0 =A0 =A0(c_type_print_modifier): Call it.
> =A0 =A0 =A0 =A0(c_type_print_base): Collect instance_flags while we're st=
ripping
> =A0 =A0 =A0 =A0typedefs. =A0Change calls to c_type_print_modifier to call
> =A0 =A0 =A0 =A0c_type_print_modifier_flags instead.
> =A0 =A0 =A0 =A0(c_type_print_base, case TYPE_CODE_TYPEDEF): Verify assump=
tions of
> =A0 =A0 =A0 =A0when this case happens. =A0Print "<unnamed typedef>".
> =A0 =A0 =A0 =A0* gdbtypes.h (strip_typedefs): Declare.
> =A0 =A0 =A0 =A0* gdbtypes.c (strip_typedefs): New function.
> =A0 =A0 =A0 =A0(check_typedef): Call it.
>
> =A0 =A0 =A0 =A0testsuite/
> =A0 =A0 =A0 =A0* gdb.cp/pr12117.cc: New file.
> =A0 =A0 =A0 =A0* gdb.cp/pr12117.exp: New file.

Blech, I told myself not to forget adding this note this time ... :-(

Tested on amd64-linux, no regressions.