From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23206 invoked by alias); 21 Feb 2011 07:41:46 -0000 Received: (qmail 23198 invoked by uid 22791); 21 Feb 2011 07:41:46 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gx0-f169.google.com (HELO mail-gx0-f169.google.com) (209.85.161.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Feb 2011 07:41:42 +0000 Received: by gxk2 with SMTP id 2so674252gxk.0 for ; Sun, 20 Feb 2011 23:41:40 -0800 (PST) Received: by 10.146.167.16 with SMTP id p16mr1603003yae.6.1298274100076; Sun, 20 Feb 2011 23:41:40 -0800 (PST) MIME-Version: 1.0 Received: by 10.147.125.2 with HTTP; Sun, 20 Feb 2011 23:41:20 -0800 (PST) In-Reply-To: <201102202134.00239.pedro@codesourcery.com> References: <201102202134.00239.pedro@codesourcery.com> From: Hui Zhu Date: Mon, 21 Feb 2011 08:17:00 -0000 Message-ID: Subject: Re: RFC: move agent opcodes to common file To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00525.txt.bz2 On Mon, Feb 21, 2011 at 05:33, Pedro Alves wrote: > On Sunday 20 February 2011 06:23:18, Hui Zhu wrote: >> But when I try to add 0x31 to ax.def, I got some build error with gdbserver: > ... > >> DEFOP (invalid2, 0, 0, 0, 0, 0x2f) > > I think that 0x2f here is a pasto and should have been 0x31, so > you probably want to replace it with your opcode, not add a new > entry. > > -- > Pedro Alves > Cool. My part is OK. Thanks for your help Pedro. Tom, leave op 31 must waste a lot of time. Thanks a lot. Best, Hui