From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2770 invoked by alias); 28 May 2010 05:27:35 -0000 Received: (qmail 2745 invoked by uid 22791); 28 May 2010 05:27:33 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 May 2010 05:27:29 +0000 Received: from kpbe18.cbf.corp.google.com (kpbe18.cbf.corp.google.com [172.25.105.82]) by smtp-out.google.com with ESMTP id o4S5RRx6023688 for ; Thu, 27 May 2010 22:27:27 -0700 Received: from pxi18 (pxi18.prod.google.com [10.243.27.18]) by kpbe18.cbf.corp.google.com with ESMTP id o4S5RQ1M016935 for ; Thu, 27 May 2010 22:27:26 -0700 Received: by pxi18 with SMTP id 18so392494pxi.33 for ; Thu, 27 May 2010 22:27:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.141.101.17 with SMTP id d17mr8807082rvm.265.1275024445844; Thu, 27 May 2010 22:27:25 -0700 (PDT) Received: by 10.140.255.14 with HTTP; Thu, 27 May 2010 22:27:25 -0700 (PDT) In-Reply-To: References: <1274918921-23200-1-git-send-email-brobecker@adacore.com> <1274918921-23200-2-git-send-email-brobecker@adacore.com> Date: Fri, 28 May 2010 09:55:00 -0000 Message-ID: Subject: Re: [RFA/python:1/2] Add support for --with-pythondir. From: Doug Evans To: tromey@redhat.com Cc: Joel Brobecker , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00677.txt.bz2 On Thu, May 27, 2010 at 1:13 PM, Tom Tromey wrote: >>>>>> "Joel" =3D=3D Joel Brobecker writes: > > Joel> 2010-05-26 =A0Tom Tromey =A0 > Joel> =A0 =A0 =A0 =A0 =A0 =A0 Joel Brobecker =A0 > Joel> =A0 =A0 =A0 =A0 * configure.ac: Add handling of --with-pythondir. > Joel> =A0 =A0 =A0 =A0 * configure, config.in: Regenerate. > Joel> =A0 =A0 =A0 =A0 * python/python.c (_initialize_python): Add variabl= e "pythondir" > Joel> =A0 =A0 =A0 =A0 inside module gdb. =A0Initialize variable gdb.__pat= h__ and execute > Joel> =A0 =A0 =A0 =A0 __init__.py if found in subdirectory "gdb" of the p= ythondir. > > FWIW I read it and it seems ok to me. > Thanks for doing this. fwiw, I still have some concerns. Support doesn't have to be included in the patch, but IWBN to have a plan for how to support .so's associated with gdb python modules in a way that follows Python's scheme: i.e. .py*'s go in $prefix/lib/pythonX.Y and .so's go in $exec_prefix/lib/pythonX.Y/lib-dynload [i.e. architecture independent files go in $prefix and architecture dependent files go in $exec_prefix]. If the plan is to add --with-python-sodir [or some such] if/when it's needed, great. Or if the plan is to decide to just not support it, that's probably ok too. I'd just like to put in the thought now. Also, do we want to name this --with-gdb-pythondir? [and do we want to rename --with-python to --with-gdb-python?] The idea being that if gdb was ever configured with something else that had its own with for --with-python*, then gdb's wouldn't collide. I don't know if it's that important, just thought I'd bring it up. Apologies if it's already been discussed and decided and I've forgotten.