From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27911 invoked by alias); 16 Jul 2010 18:50:11 -0000 Received: (qmail 27899 invoked by uid 22791); 16 Jul 2010 18:50:10 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM X-Spam-Check-By: sourceware.org Received: from mail-ey0-f169.google.com (HELO mail-ey0-f169.google.com) (209.85.215.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Jul 2010 18:50:05 +0000 Received: by eydd26 with SMTP id d26so719007eyd.0 for ; Fri, 16 Jul 2010 11:50:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.25.138 with SMTP id z10mr4584575ebb.84.1279306202089; Fri, 16 Jul 2010 11:50:02 -0700 (PDT) Received: by 10.213.11.1 with HTTP; Fri, 16 Jul 2010 11:50:02 -0700 (PDT) In-Reply-To: References: Date: Fri, 16 Jul 2010 18:50:00 -0000 Message-ID: Subject: Re: [PATCH] fix build failure for win64, revise some format strings From: Ozkan Sezer To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00247.txt.bz2 On Fri, Jul 16, 2010 at 9:47 PM, Tom Tromey wrote: >>>>>> "Ozkan" =3D=3D Ozkan Sezer writes: > > Ozkan> gdb/gdbserver/ > Ozkan> =A0* server.c (handle_query): For windows, Use %I64d instead of > Ozkan> =A0%lld in the sprintf format string. > > I don't know much about gdbserver. =A0So I am going to ask that someone > else look at this part. > > Ozkan> (Note: debug_to_region_ok_for_hw_watchpoint() specifically > Ozkan> did not use 0x%lx but only %ld for the addr value. =A0Should I > Ozkan> not care, or should I change my patch to use > Ozkan> host_address_to_string ((void *) addr) + 2 > Ozkan> ... to skip the "0x" instead? > > Don't worry about it, using host_address_to_string is fine. > > Ozkan> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0host_address_to_strin= g ((void *) bp_tgt->placed_address), > > I think you should not need these casts to void*. Actually I do: placed_address is CORE_ADDR which is bfd_vma, ie. uintptr_t and not a pointer. > > The gdb parts of this patch are ok with that change. =A0Thanks. > Still OK without removing the casts? > Tom > -- Ozkan