From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73746-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27566 invoked by alias); 15 Jun 2010 15:56:16 -0000
Received: (qmail 27555 invoked by uid 22791); 15 Jun 2010 15:56:16 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM
X-Spam-Check-By: sourceware.org
Received: from mail-wy0-f169.google.com (HELO mail-wy0-f169.google.com) (74.125.82.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jun 2010 15:56:11 +0000
Received: by wyf28 with SMTP id 28so5365167wyf.0        for <gdb-patches@sourceware.org>; Tue, 15 Jun 2010 08:56:08 -0700 (PDT)
Received: by 10.227.156.5 with SMTP id u5mr7358419wbw.27.1276617368330; Tue, 	15 Jun 2010 08:56:08 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.216.167.144 with HTTP; Tue, 15 Jun 2010 08:55:48 -0700 (PDT)
In-Reply-To: <4BF59BBB.8020603@vmware.com>
References: <4BF59BBB.8020603@vmware.com>
From: Frederic Riss <frederic.riss@gmail.com>
Date: Tue, 15 Jun 2010 15:56:00 -0000
Message-ID: <AANLkTimG38HTcyRN2hr5If0lcUCHY_84j3V_JmEne-Ha@mail.gmail.com>
Subject: Re: [resubmit] gdb.base, r*.exp thru w*.exp
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00339.txt.bz2

Hi,

I get some strange issues with this series of commits. Some tests
start to randomly fail. It's quite hard to reproduce, I only have 1
out of ~10 boxes that exposes the issue in an random manner. To take a
real example, let's take this hunk:

On 20 May 2010 22:29, Michael Snyder <msnyder@vmware.com> wrote:
> Index: setshow.exp
> --- setshow.exp 5 May 2010 18:06:58 -0000 =A0 =A0 =A0 1.14
> +++ setshow.exp 20 May 2010 20:24:11 -0000
> @@ -54,27 +54,25 @@ if { ![runto_main] } {
> =A0#test set annotate 2
> -send_gdb "set annotate 2\n"
> -gdb_expect {
> - =A0 =A0 =A0 -re ".*\032\032pre-prompt.*$gdb_prompt .*\032\032prompt.*$"=
 \
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 { pass "set=
 annotate 2" }
> - =A0 =A0 =A0 timeout =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 { fail "(timeout) s=
et annotate 2" }
> +
> +gdb_test_multiple "set annotate 2" "set annotate 2" {
> + =A0 =A0-re ".*\032\032pre-prompt.*$gdb_prompt .*\032\032prompt.*$" {
> + =A0 =A0pass "set annotate 2"
> =A0 =A0 }
> +}

Before that commit, the test seemed 100% reliable. After the commit,
if I run it in a loop on the affected box, I start to get failures
like that in my runs:

set annotate 2

^Z^Zpre-prompt
(gdb) FAIL: gdb.base/setshow.exp: set annotate 2

^Z^Zprompt

As you see the required things are in the output, but expect fails to
match it;. There must be some subtle difference between gdb_expect and
gdb_test_multiple when matching patterns containing prompts. Does that
make any sense to someone? Note that I took this precise example, but
I have a few places in the testsuite that show similar random
failures.

Thanks,
Fred