From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1632 invoked by alias); 17 Jul 2010 09:53:19 -0000 Received: (qmail 1624 invoked by uid 22791); 17 Jul 2010 09:53:18 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM X-Spam-Check-By: sourceware.org Received: from mail-ew0-f41.google.com (HELO mail-ew0-f41.google.com) (209.85.215.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Jul 2010 09:53:07 +0000 Received: by ewy28 with SMTP id 28so1113645ewy.0 for ; Sat, 17 Jul 2010 02:53:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.113.193 with SMTP id b1mr501209ebq.13.1279360384602; Sat, 17 Jul 2010 02:53:04 -0700 (PDT) Received: by 10.213.11.1 with HTTP; Sat, 17 Jul 2010 02:53:04 -0700 (PDT) In-Reply-To: References: <201007170537.44785.vapier@gentoo.org> Date: Sat, 17 Jul 2010 09:53:00 -0000 Message-ID: Subject: Re: [PATCH] [Windows] fix format string for 64 bit var in gdbserver From: Ozkan Sezer To: Mike Frysinger Cc: gdb-patches@sourceware.org, Tom Tromey Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00259.txt.bz2 On Sat, Jul 17, 2010 at 12:42 PM, Ozkan Sezer wrote: > On Sat, Jul 17, 2010 at 12:37 PM, Mike Frysinger wrot= e: >> On Friday, July 16, 2010 16:10:23 Ozkan Sezer wrote: >>> For windows targets, (x86_64-w64-mingw32, i686-w64-mingw32) >>> gcc complains: >>> >>> ../../../gdb-cvs/gdb/gdbserver/server.c: In function 'handle_query': >>> ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: unknown >>> conversion type character 'l' in format >>> ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: too many >>> arguments for format >>> ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: unknown >>> conversion type character 'l' in format >>> ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: too many >>> arguments for format >>> >>> This is due to the fact that MS printf doesn't support %lld, it uses >>> its own %I64d which gcc already knows about. The attached patch >>> changes that. OK for apply? >> >> ugh, no. =A0why not use a sane define like PRIx64 from inttypes.h ? >> -mike >> > > I would happily do that, however that would require inttypes > module merge from gnulib to gdb/gnulib, am I wrong? > To be clear, I modified a patch I submitted before to not use the inttypes PRI macros: http://sourceware.org/ml/gdb-patches/2010-07/msg00244.html By analogy, I might use paddress() instead, but for that case please see the issue I reported at http://sourceware.org/ml/gdb-patches/2010-07/msg00254.html Comments? -- Ozkan