From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19058 invoked by alias); 24 Jun 2010 06:13:57 -0000 Received: (qmail 19046 invoked by uid 22791); 24 Jun 2010 06:13:56 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-pv0-f169.google.com (HELO mail-pv0-f169.google.com) (74.125.83.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Jun 2010 06:13:52 +0000 Received: by pvg4 with SMTP id 4so58312pvg.0 for ; Wed, 23 Jun 2010 23:13:50 -0700 (PDT) Received: by 10.142.249.19 with SMTP id w19mr8420169wfh.175.1277360030396; Wed, 23 Jun 2010 23:13:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.32.8 with HTTP; Wed, 23 Jun 2010 23:13:30 -0700 (PDT) In-Reply-To: <20100623165905.GH2595@adacore.com> References: <20100109105557.GA2007@adacore.com> <20100110054328.GD2007@adacore.com> <20100110140029.GF2007@adacore.com> <83zkyndjx2.fsf@gnu.org> <20100623165905.GH2595@adacore.com> From: Hui Zhu Date: Thu, 24 Jun 2010 06:13:00 -0000 Message-ID: Subject: Re: [RFC] Let "gcore" command accept a suffix argument To: Joel Brobecker Cc: Eli Zaretskii , Pedro Alves , Tom Tromey , stanshebs@earthlink.net, stan@codesourcery.com, msnyder@vmware.com, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00518.txt.bz2 On Thu, Jun 24, 2010 at 00:59, Joel Brobecker wrote: >> 2010-06-23 =A0Hui Zhu =A0 >> >> =A0 =A0 =A0 =A0* printcmd.c (ui_printf): New function. >> =A0 =A0 =A0 =A0(printf_command): Call ui_printf. >> =A0 =A0 =A0 =A0(_initialize_printcmd): New command "eval". > > This is OK. > >> 2010-06-23 =A0Hui Zhu =A0 >> >> =A0 =A0 =A0 * gdb.base/eval.exp: New file. > > This is also OK. =A0Just for the record, I first thought that your two > tests where still the same and thus would generate the same message. > But after a closer inspection, one used $a++ and the other ++$a. > Why not use something more different like '$a * 2' maybe? > > Another way to make things different is to specify distinct messages > explicitly - for instance "first eval" / "second eval"... > Thanks Joel, Changed it to: gdb_test "eval \"echo %d\\n\", \$a++" "10" "First eval." gdb_test "eval \"echo %d\\n\", \$a*2" "22" "Second eval." And checked in. Best, Hui