From: Frederic Riss <frederic.riss@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: RFC: optimized-out pieces
Date: Mon, 14 Jun 2010 12:07:00 -0000 [thread overview]
Message-ID: <AANLkTikomBCDF7DS_ZtFZe7tNOHKM6POgiI1K08H0wSQ@mail.gmail.com> (raw)
In-Reply-To: <m34oh960s1.fsf@fleche.redhat.com>
Hi Tom,
On 11 June 2010 17:34, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
>
> Tom> New patch appended.
>
> I am checking in the latest version of this patch.
I think this patch regresses on architectures that mark registers as
optimized in their CFI. Specifically when executing the 'return'
command. When iterating over the unwound registers to gather the
values to assign to the registers in pop_frame, frame_register_unwind
calls value_contents_all that will error out if it finds an unsaved
register. I think it's expected to have such registers when doing a
return.
I fixed that by preventing frame_register_unwind to call
value_contents_all in the optimized case (not providing the one-liner
as I don't have the copyright assignment in place anymore).
Cheers,
Fred
next prev parent reply other threads:[~2010-06-14 12:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 19:19 Tom Tromey
2010-06-04 21:42 ` Tom Tromey
2010-06-07 22:35 ` Jan Kratochvil
2010-06-08 18:36 ` Tom Tromey
2010-06-08 18:42 ` Jan Kratochvil
2010-06-08 18:57 ` Tom Tromey
2010-06-09 5:50 ` Jan Kratochvil
2010-06-10 17:14 ` Tom Tromey
2010-06-11 15:34 ` Tom Tromey
2010-06-14 12:07 ` Frederic Riss [this message]
2010-06-15 15:54 ` Tom Tromey
2010-06-09 18:44 ` Jan Kratochvil
2010-06-14 12:13 ` [commit] Fix "return" command (Re: RFC: optimized-out pieces) Ulrich Weigand
2010-06-15 15:58 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikomBCDF7DS_ZtFZe7tNOHKM6POgiI1K08H0wSQ@mail.gmail.com \
--to=frederic.riss@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox